<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26636">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/siemens: Get rid of whitespace before tab<br><br>Change-Id: Ic334f65e5c27d4f773f81fc1c9e3df7d63d47a11<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/mainboard/siemens/mc_tcu3/devicetree.cb<br>M src/mainboard/siemens/mc_tcu3/gpio.c<br>M src/mainboard/siemens/mc_tcu3/irqroute.h<br>M src/mainboard/siemens/sitemp_g1p1/acpi/event.asl<br>M src/mainboard/siemens/sitemp_g1p1/acpi/statdef.asl<br>M src/mainboard/siemens/sitemp_g1p1/devicetree.cb<br>M src/mainboard/siemens/sitemp_g1p1/dsdt.asl<br>M src/mainboard/siemens/sitemp_g1p1/mainboard.c<br>8 files changed, 45 insertions(+), 45 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/26636/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/siemens/mc_tcu3/devicetree.cb b/src/mainboard/siemens/mc_tcu3/devicetree.cb</span><br><span>index 2a8183d..433eebe 100644</span><br><span>--- a/src/mainboard/siemens/mc_tcu3/devicetree.cb</span><br><span>+++ b/src/mainboard/siemens/mc_tcu3/devicetree.cb</span><br><span>@@ -59,7 +59,7 @@</span><br><span> device pci 18.7 on end # 8086 0F47 - I2C Port 7</span><br><span> device pci 1a.0 on end # 8086 0F18 - Trusted Execution Engine</span><br><span> device pci 1b.0 on end # 8086 0F04 - HD Audio</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1c.0 on # 8086 0F48 - PCIe Root Port 1 (x4 slot)</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.0 on # 8086 0F48 - PCIe Root Port 1 (x4 slot)</span><br><span> device pci 0.0 on end # 8086 1538 - Intel i210 MACPHY</span><br><span> end</span><br><span> device pci 1c.1 on end # 8086 0F4A - PCIe Root Port 2 (half mini pcie slot)</span><br><span>diff --git a/src/mainboard/siemens/mc_tcu3/gpio.c b/src/mainboard/siemens/mc_tcu3/gpio.c</span><br><span>index c803998..23c6f96 100644</span><br><span>--- a/src/mainboard/siemens/mc_tcu3/gpio.c</span><br><span>+++ b/src/mainboard/siemens/mc_tcu3/gpio.c</span><br><span>@@ -160,14 +160,14 @@</span><br><span> /* SSUS GPIOs (GPIO_S5) */</span><br><span> static const struct soc_gpio_map gpssus_gpio_map[] = {</span><br><span> GPIO_INPUT_PD_10K, /* GPIO_S5[00] RESERVED */</span><br><span style="color: hsl(0, 100%, 40%);">- GPIO_INPUT_PD_10K, /* GPIO_S5[01] RESERVED RESERVED RESERVED PMC_WAKE_PCIE[1]# */</span><br><span style="color: hsl(120, 100%, 40%);">+ GPIO_INPUT_PD_10K, /* GPIO_S5[01] RESERVED RESERVED RESERVED PMC_WAKE_PCIE[1]# */</span><br><span> GPIO_INPUT_PD_10K, /* GPIO_S5[02] RESERVED RESERVED RESERVED PMC_WAKE_PCIE[2]# */</span><br><span> GPIO_INPUT_PD_10K, /* GPIO_S5[03] RESERVED RESERVED RESERVED PMC_WAKE_PCIE[3]# */</span><br><span> GPIO_INPUT_PD_10K, /* GPIO_S5[04] RESERVED RESERVED RESERVED RESERVED */</span><br><span> GPIO_INPUT_PD_10K, /* GPIO_S5[05] PMC_SUSCLK[1] RESERVED RESERVED RESERVED */</span><br><span> GPIO_INPUT_PD_10K, /* GPIO_S5[06] PMC_SUSCLK[2] RESERVED RESERVED RESERVED */</span><br><span> GPIO_INPUT_PD_10K, /* GPIO_S5[07] PMC_SUSCLK[3] RESERVED RESERVED RESERVED */</span><br><span style="color: hsl(0, 100%, 40%);">- GPIO_INPUT_PU_10K, /* GPIO_S5[08] RESERVED RESERVED RESERVED RESERVED */</span><br><span style="color: hsl(120, 100%, 40%);">+ GPIO_INPUT_PU_10K, /* GPIO_S5[08] RESERVED RESERVED RESERVED RESERVED */</span><br><span> GPIO_INPUT_PU_10K, /* GPIO_S5[09] RESERVED RESERVED ESERVED RESERVED */</span><br><span> GPIO_OUT_HIGH, /* GPIO_S5[10] RESERVED RESERVED RESERVED */</span><br><span> GPIO_DEFAULT, /* PMC_SUSPWRDNACK GPIO_S5[11] - - */</span><br><span>diff --git a/src/mainboard/siemens/mc_tcu3/irqroute.h b/src/mainboard/siemens/mc_tcu3/irqroute.h</span><br><span>index a24be3e..41b990b 100644</span><br><span>--- a/src/mainboard/siemens/mc_tcu3/irqroute.h</span><br><span>+++ b/src/mainboard/siemens/mc_tcu3/irqroute.h</span><br><span>@@ -20,14 +20,14 @@</span><br><span> #include <soc/intel/fsp_baytrail/include/soc/pci_devs.h></span><br><span> </span><br><span> /*</span><br><span style="color: hsl(0, 100%, 40%);">- *IR02h GFX INT(A) - PIRQ A</span><br><span style="color: hsl(120, 100%, 40%);">+ *IR02h GFX INT(A) - PIRQ A</span><br><span> *IR10h EMMC INT(ABCD) - PIRQ DEFG</span><br><span style="color: hsl(0, 100%, 40%);">- *IR11h SDIO INT(A) - PIRQ B</span><br><span style="color: hsl(0, 100%, 40%);">- *IR12h SD INT(A) - PIRQ C</span><br><span style="color: hsl(0, 100%, 40%);">- *IR13h SATA INT(A) - PIRQ D</span><br><span style="color: hsl(0, 100%, 40%);">- *IR14h XHCI INT(A) - PIRQ E</span><br><span style="color: hsl(0, 100%, 40%);">- *IR15h LP Audio INT(A) - PIRQ F</span><br><span style="color: hsl(0, 100%, 40%);">- *IR17h MMC INT(A) - PIRQ F</span><br><span style="color: hsl(120, 100%, 40%);">+ *IR11h SDIO INT(A) - PIRQ B</span><br><span style="color: hsl(120, 100%, 40%);">+ *IR12h SD INT(A) - PIRQ C</span><br><span style="color: hsl(120, 100%, 40%);">+ *IR13h SATA INT(A) - PIRQ D</span><br><span style="color: hsl(120, 100%, 40%);">+ *IR14h XHCI INT(A) - PIRQ E</span><br><span style="color: hsl(120, 100%, 40%);">+ *IR15h LP Audio INT(A) - PIRQ F</span><br><span style="color: hsl(120, 100%, 40%);">+ *IR17h MMC INT(A) - PIRQ F</span><br><span> *IR18h SIO INT(ABCD) - PIRQ BADC</span><br><span> *IR1Ah TXE INT(A) - PIRQ F</span><br><span> *IR1Bh HD Audio INT(A) - PIRQ G</span><br><span>diff --git a/src/mainboard/siemens/sitemp_g1p1/acpi/event.asl b/src/mainboard/siemens/sitemp_g1p1/acpi/event.asl</span><br><span>index fafb0ac..d0cad21 100644</span><br><span>--- a/src/mainboard/siemens/sitemp_g1p1/acpi/event.asl</span><br><span>+++ b/src/mainboard/siemens/sitemp_g1p1/acpi/event.asl</span><br><span>@@ -53,7 +53,7 @@</span><br><span> </span><br><span> /* On older chips, clear PciExpWakeDisEn */</span><br><span> /*if (LLessEqual(\_SB.SBRI, 0x13)) {</span><br><span style="color: hsl(0, 100%, 40%);">- * Store(0,\_SB.PWDE)</span><br><span style="color: hsl(120, 100%, 40%);">+ * Store(0,\_SB.PWDE)</span><br><span> *}</span><br><span> */</span><br><span> </span><br><span>@@ -69,13 +69,13 @@</span><br><span> * used, so it could be removed.</span><br><span> *</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">-* \_GTS OEM Going To Sleep method</span><br><span style="color: hsl(120, 100%, 40%);">+* \_GTS OEM Going To Sleep method</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">-* Entry:</span><br><span style="color: hsl(0, 100%, 40%);">-* Arg0=The value of the sleeping state S1=1, S2=2</span><br><span style="color: hsl(120, 100%, 40%);">+* Entry:</span><br><span style="color: hsl(120, 100%, 40%);">+* Arg0=The value of the sleeping state S1=1, S2=2</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">-* Exit:</span><br><span style="color: hsl(0, 100%, 40%);">-* -none-</span><br><span style="color: hsl(120, 100%, 40%);">+* Exit:</span><br><span style="color: hsl(120, 100%, 40%);">+* -none-</span><br><span> *</span><br><span> * Method(\_GTS, 1) {</span><br><span> * DBGO("\\_GTS\n")</span><br><span>@@ -200,7 +200,7 @@</span><br><span> </span><br><span> /* PCIe HotPlug event */</span><br><span> /* Method(_L0F) {</span><br><span style="color: hsl(0, 100%, 40%);">- * DBGO("\\_GPE\\_L0F\n")</span><br><span style="color: hsl(120, 100%, 40%);">+ * DBGO("\\_GPE\\_L0F\n")</span><br><span> * }</span><br><span> */</span><br><span> </span><br><span>@@ -223,19 +223,19 @@</span><br><span> </span><br><span> /* GPM0 SCI event - Moved to USB.asl */</span><br><span> /* Method(_L13) {</span><br><span style="color: hsl(0, 100%, 40%);">- * DBGO("\\_GPE\\_L13\n")</span><br><span style="color: hsl(120, 100%, 40%);">+ * DBGO("\\_GPE\\_L13\n")</span><br><span> * }</span><br><span> */</span><br><span> </span><br><span> /* GPM1 SCI event - Moved to USB.asl */</span><br><span> /* Method(_L14) {</span><br><span style="color: hsl(0, 100%, 40%);">- * DBGO("\\_GPE\\_L14\n")</span><br><span style="color: hsl(120, 100%, 40%);">+ * DBGO("\\_GPE\\_L14\n")</span><br><span> * }</span><br><span> */</span><br><span> </span><br><span> /* GPM2 SCI event - Moved to USB.asl */</span><br><span> /* Method(_L15) {</span><br><span style="color: hsl(0, 100%, 40%);">- * DBGO("\\_GPE\\_L15\n")</span><br><span style="color: hsl(120, 100%, 40%);">+ * DBGO("\\_GPE\\_L15\n")</span><br><span> * }</span><br><span> */</span><br><span> </span><br><span>@@ -247,7 +247,7 @@</span><br><span> </span><br><span> /* GPM8 SCI event - Moved to USB.asl */</span><br><span> /* Method(_L17) {</span><br><span style="color: hsl(0, 100%, 40%);">- * DBGO("\\_GPE\\_L17\n")</span><br><span style="color: hsl(120, 100%, 40%);">+ * DBGO("\\_GPE\\_L17\n")</span><br><span> * }</span><br><span> */</span><br><span> </span><br><span>@@ -264,7 +264,7 @@</span><br><span> </span><br><span> /* GPM4 SCI event - Moved to USB.asl */</span><br><span> /* Method(_L19) {</span><br><span style="color: hsl(0, 100%, 40%);">- * DBGO("\\_GPE\\_L19\n")</span><br><span style="color: hsl(120, 100%, 40%);">+ * DBGO("\\_GPE\\_L19\n")</span><br><span> * }</span><br><span> */</span><br><span> </span><br><span>@@ -295,10 +295,10 @@</span><br><span> </span><br><span> /* GPIO2 or GPIO66 SCI event */</span><br><span> /* Method(_L1E) {</span><br><span style="color: hsl(0, 100%, 40%);">- * DBGO("\\_GPE\\_L1E\n")</span><br><span style="color: hsl(120, 100%, 40%);">+ * DBGO("\\_GPE\\_L1E\n")</span><br><span> * }</span><br><span> */</span><br><span> </span><br><span> /* SATA SCI event */</span><br><span> /* SATA Hot Plug Support -> acpi/sata.asl */</span><br><span style="color: hsl(0, 100%, 40%);">-} /* End Scope GPE */</span><br><span style="color: hsl(120, 100%, 40%);">+} /* End Scope GPE */</span><br><span>diff --git a/src/mainboard/siemens/sitemp_g1p1/acpi/statdef.asl b/src/mainboard/siemens/sitemp_g1p1/acpi/statdef.asl</span><br><span>index 3de9620..f8c4b32 100644</span><br><span>--- a/src/mainboard/siemens/sitemp_g1p1/acpi/statdef.asl</span><br><span>+++ b/src/mainboard/siemens/sitemp_g1p1/acpi/statdef.asl</span><br><span>@@ -52,7 +52,7 @@</span><br><span> </span><br><span> /* Battery Device Notification Values */</span><br><span> #define NOTIFY_BAT_STATUSCHG 0x80</span><br><span style="color: hsl(0, 100%, 40%);">-#define NOTIFY_BAT_INFOCHG 0x81</span><br><span style="color: hsl(120, 100%, 40%);">+#define NOTIFY_BAT_INFOCHG 0x81</span><br><span> #define NOTIFY_BAT_MAINTDATA 0x82</span><br><span> </span><br><span> /* Power Source Object Notification Values */</span><br><span>@@ -62,7 +62,7 @@</span><br><span> #define NOTIFY_TZ_STATUSCHG 0x80</span><br><span> #define NOTIFY_TZ_TRIPPTCHG 0x81</span><br><span> #define NOTIFY_TZ_DEVLISTCHG 0x82</span><br><span style="color: hsl(0, 100%, 40%);">-#define NOTIFY_TZ_RELTBLCHG 0x83</span><br><span style="color: hsl(120, 100%, 40%);">+#define NOTIFY_TZ_RELTBLCHG 0x83</span><br><span> </span><br><span> /* Power Button Notification Values */</span><br><span> #define NOTIFY_POWER_BUTTON 0x80</span><br><span>@@ -74,14 +74,14 @@</span><br><span> #define NOTIFY_LID_STATUSCHG 0x80</span><br><span> </span><br><span> /* Processor Device Notification Values */</span><br><span style="color: hsl(0, 100%, 40%);">-#define NOTIFY_CPU_PPCCHG 0x80</span><br><span style="color: hsl(0, 100%, 40%);">-#define NOTIFY_CPU_CSTATECHG 0x81</span><br><span style="color: hsl(120, 100%, 40%);">+#define NOTIFY_CPU_PPCCHG 0x80</span><br><span style="color: hsl(120, 100%, 40%);">+#define NOTIFY_CPU_CSTATECHG 0x81</span><br><span> #define NOTIFY_CPU_THROTLCHG 0x82</span><br><span> </span><br><span> /* User Presence Device Notification Values */</span><br><span> #define NOTIFY_USR_PRESNCECHG 0x80</span><br><span> </span><br><span> /* Battery Device Notification Values */</span><br><span style="color: hsl(0, 100%, 40%);">-#define NOTIFY_ALS_ILLUMCHG 0x80</span><br><span style="color: hsl(0, 100%, 40%);">-#define NOTIFY_ALS_COLORTMPCHG 0x81</span><br><span style="color: hsl(120, 100%, 40%);">+#define NOTIFY_ALS_ILLUMCHG 0x80</span><br><span style="color: hsl(120, 100%, 40%);">+#define NOTIFY_ALS_COLORTMPCHG 0x81</span><br><span> #define NOTIFY_ALS_RESPCHG 0x82</span><br><span>diff --git a/src/mainboard/siemens/sitemp_g1p1/devicetree.cb b/src/mainboard/siemens/sitemp_g1p1/devicetree.cb</span><br><span>index e47703f..30125e4 100644</span><br><span>--- a/src/mainboard/siemens/sitemp_g1p1/devicetree.cb</span><br><span>+++ b/src/mainboard/siemens/sitemp_g1p1/devicetree.cb</span><br><span>@@ -59,7 +59,7 @@</span><br><span> device pci 13.3 on end # USB 0x438a</span><br><span> device pci 13.4 on end # USB 0x438b</span><br><span> device pci 13.5 on end # USB 2 0x4386</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 14.0 on # SM 0x4385</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 14.0 on # SM 0x4385</span><br><span> chip drivers/generic/generic #dimm 0-0-0</span><br><span> device i2c 50 on end</span><br><span> end</span><br><span>diff --git a/src/mainboard/siemens/sitemp_g1p1/dsdt.asl b/src/mainboard/siemens/sitemp_g1p1/dsdt.asl</span><br><span>index 121aaf9..902647e 100644</span><br><span>--- a/src/mainboard/siemens/sitemp_g1p1/dsdt.asl</span><br><span>+++ b/src/mainboard/siemens/sitemp_g1p1/dsdt.asl</span><br><span>@@ -181,9 +181,9 @@</span><br><span> PWMK, 1,</span><br><span> PWNS, 1,</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Offset(0x61), */ /* Options_1 */</span><br><span style="color: hsl(0, 100%, 40%);">- /* ,7, */</span><br><span style="color: hsl(0, 100%, 40%);">- /* R617,1, */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Offset(0x61), */ /* Options_1 */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* ,7, */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* R617,1, */</span><br><span> </span><br><span> Offset(0x65), /* UsbPMControl */</span><br><span> , 4,</span><br><span>@@ -1162,7 +1162,7 @@</span><br><span> 0xF300 /* length */</span><br><span> )</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Memory32Fixed(READONLY, 0x000A0000, 0x00020000, VGAM) /* VGA memory space */</span><br><span style="color: hsl(120, 100%, 40%);">+ Memory32Fixed(READONLY, 0x000A0000, 0x00020000, VGAM) /* VGA memory space */</span><br><span> Memory32Fixed(READONLY, 0x000C0000, 0x00020000, EMM1) /* Assume C0000-E0000 empty */</span><br><span> Memory32Fixed(READONLY, 0x000E0000, 0x00020000, RDBS) /* BIOS ROM area */</span><br><span> </span><br><span>diff --git a/src/mainboard/siemens/sitemp_g1p1/mainboard.c b/src/mainboard/siemens/sitemp_g1p1/mainboard.c</span><br><span>index d4cb582..b7976e7 100644</span><br><span>--- a/src/mainboard/siemens/sitemp_g1p1/mainboard.c</span><br><span>+++ b/src/mainboard/siemens/sitemp_g1p1/mainboard.c</span><br><span>@@ -38,16 +38,16 @@</span><br><span> </span><br><span> // ****LCD panel ID support: *****</span><br><span> // Callback Sub-Function 00h - Get LCD Panel ID</span><br><span style="color: hsl(0, 100%, 40%);">-#define PANEL_TABLE_ID_NO 0 // no LCD</span><br><span style="color: hsl(0, 100%, 40%);">-#define PANEL_TABLE_ID1 1 // 1024x768_65MHz_Dual</span><br><span style="color: hsl(0, 100%, 40%);">-#define PANEL_TABLE_ID2 2 // 920x1200_162MHz</span><br><span style="color: hsl(0, 100%, 40%);">-#define PANEL_TABLE_ID3 3 // 600x1200_162MHz</span><br><span style="color: hsl(0, 100%, 40%);">-#define PANEL_TABLE_ID4 4 // 1024x768_65MHz</span><br><span style="color: hsl(0, 100%, 40%);">-#define PANEL_TABLE_ID5 5 // 1400x1050_108MHz</span><br><span style="color: hsl(0, 100%, 40%);">-#define PANEL_TABLE_ID6 6 // 1680x1050_119MHz</span><br><span style="color: hsl(0, 100%, 40%);">-#define PANEL_TABLE_ID7 7 // 2048x1536_164MHz</span><br><span style="color: hsl(0, 100%, 40%);">-#define PANEL_TABLE_ID8 8 // 1280x1024_108MHz</span><br><span style="color: hsl(0, 100%, 40%);">-#define PANEL_TABLE_ID9 9 // 1366x768_86MHz_chimei_V32B1L01</span><br><span style="color: hsl(120, 100%, 40%);">+#define PANEL_TABLE_ID_NO 0 // no LCD</span><br><span style="color: hsl(120, 100%, 40%);">+#define PANEL_TABLE_ID1 1 // 1024x768_65MHz_Dual</span><br><span style="color: hsl(120, 100%, 40%);">+#define PANEL_TABLE_ID2 2 // 920x1200_162MHz</span><br><span style="color: hsl(120, 100%, 40%);">+#define PANEL_TABLE_ID3 3 // 600x1200_162MHz</span><br><span style="color: hsl(120, 100%, 40%);">+#define PANEL_TABLE_ID4 4 // 1024x768_65MHz</span><br><span style="color: hsl(120, 100%, 40%);">+#define PANEL_TABLE_ID5 5 // 1400x1050_108MHz</span><br><span style="color: hsl(120, 100%, 40%);">+#define PANEL_TABLE_ID6 6 // 1680x1050_119MHz</span><br><span style="color: hsl(120, 100%, 40%);">+#define PANEL_TABLE_ID7 7 // 2048x1536_164MHz</span><br><span style="color: hsl(120, 100%, 40%);">+#define PANEL_TABLE_ID8 8 // 1280x1024_108MHz</span><br><span style="color: hsl(120, 100%, 40%);">+#define PANEL_TABLE_ID9 9 // 1366x768_86MHz_chimei_V32B1L01</span><br><span> </span><br><span> // Callback Sub-Function 05h - Select Boot-up TV Standard</span><br><span> #define TV_MODE_00 0x00 /* NTSC */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26636">change 26636</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26636"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic334f65e5c27d4f773f81fc1c9e3df7d63d47a11 </div>
<div style="display:none"> Gerrit-Change-Number: 26636 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>