<p>Daniel Kurtz would like Daniel Kurtz to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/26498">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/kahlee: Init APU_BIOS_FLASH_WP_L GPIO to reset stage<br><br>GPIO APU_BIOS_FLASH_WP_L is read in RAM stage to determine the state of<br>the BIOS FLASH Write Protect signal.  Therefore it must be configured<br>as a "reset stage" GPIO, not "RAM" stage.<br><br>BUG=b:79866233<br>TEST=firmware_WriteProtect<br><br>Change-Id: I1d96ab4bbfeaf9db9f74cf0c58cbab2104079bf7<br>Signed-off-by: Daniel Kurtz <djkurtz@chromium.org><br>---<br>M src/mainboard/google/kahlee/variants/baseboard/gpio.c<br>1 file changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/26498/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c</span><br><span>index 12b0e42..ff6141e 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c</span><br><span>+++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c</span><br><span>@@ -58,6 +58,9 @@</span><br><span>   /* GPIO_92 - WLAN_PCIE_CLKREQ_3V3_ODL */</span><br><span>     PAD_NF(GPIO_92, CLK_REQ0_L, PULL_UP),</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+     /* GPIO_122 - APU_BIOS_FLASH_WP_L */</span><br><span style="color: hsl(120, 100%, 40%);">+  PAD_GPI(GPIO_122, PULL_NONE),</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>      /* GPIO_131 - CONFIG_STRAP3 */</span><br><span>       PAD_GPI(GPIO_131, PULL_NONE),</span><br><span> </span><br><span>@@ -111,6 +114,9 @@</span><br><span>      /* GPIO_92 - WLAN_PCIE_CLKREQ_3V3_ODL */</span><br><span>     PAD_NF(GPIO_92, CLK_REQ0_L, PULL_UP),</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+     /* GPIO_122 - APU_BIOS_FLASH_WP_L */</span><br><span style="color: hsl(120, 100%, 40%);">+  PAD_GPI(GPIO_122, PULL_NONE),</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>      /* GPIO_131 - CONFIG_STRAP3 */</span><br><span>       PAD_GPI(GPIO_131, PULL_NONE),</span><br><span> </span><br><span>@@ -251,9 +257,6 @@</span><br><span>      /* GPIO_119 - SPK_PA_EN */</span><br><span>   PAD_GPO(GPIO_119, HIGH),</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    /* GPIO_122 - APU_BIOS_FLASH_WP_L */</span><br><span style="color: hsl(0, 100%, 40%);">-    PAD_GPI(GPIO_122, PULL_NONE),</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>        /* GPIO_126 - DMIC_CLK2_EN */</span><br><span>        PAD_GPO(GPIO_126, HIGH),</span><br><span> </span><br><span>@@ -415,9 +418,6 @@</span><br><span>   /* GPIO_119 - SPK_PA_EN */</span><br><span>   PAD_GPO(GPIO_119, HIGH),</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    /* GPIO_122 - APU_BIOS_FLASH_WP_L */</span><br><span style="color: hsl(0, 100%, 40%);">-    PAD_GPI(GPIO_122, PULL_NONE),</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>        /* GPIO_126 - DMIC_CLK2_EN */</span><br><span>        PAD_GPO(GPIO_126, HIGH),</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26498">change 26498</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26498"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I1d96ab4bbfeaf9db9f74cf0c58cbab2104079bf7 </div>
<div style="display:none"> Gerrit-Change-Number: 26498 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Daniel Kurtz <djkurtz@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Kurtz <djkurtz@chromium.org> </div>