<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26496">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">buildgcc: Do not try to install GCC if build failed<br><br>We didn't bail out if configuring or building of GCC failed but run<br>`make install` and later steps instead. This resulted in very confusing<br>logs that concealed the actual error.<br><br>Change-Id: Ia064e0bfd96f0cbad391da3bb19e4dc304d988ff<br>Signed-off-by: Nico Huber <nico.h@gmx.de><br>---<br>M util/crossgcc/buildgcc<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/26496/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc</span><br><span>index 9068e86..93c8aad 100755</span><br><span>--- a/util/crossgcc/buildgcc</span><br><span>+++ b/util/crossgcc/buildgcc</span><br><span>@@ -751,12 +751,12 @@</span><br><span>              --with-gmp=$DESTDIR$TARGETDIR --with-mpfr=$DESTDIR$TARGETDIR \</span><br><span>               --with-mpc=$DESTDIR$TARGETDIR \</span><br><span>              --with-pkgversion="coreboot toolchain v$CROSSGCC_VERSION $CROSSGCC_DATE" \</span><br><span style="color: hsl(0, 100%, 40%);">-            || touch .failed</span><br><span style="color: hsl(0, 100%, 40%);">-        $MAKE $JOBS CFLAGS_FOR_BUILD="$HOSTCFLAGS" all-gcc || touch .failed</span><br><span style="color: hsl(120, 100%, 40%);">+         && \</span><br><span style="color: hsl(120, 100%, 40%);">+  $MAKE $JOBS CFLAGS_FOR_BUILD="$HOSTCFLAGS" all-gcc && \</span><br><span>    $MAKE install-gcc DESTDIR=$DESTDIR || touch .failed</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if [ "$(echo $TARGETARCH | grep -c -- -mingw32)" -eq 0 ]; then</span><br><span style="color: hsl(0, 100%, 40%);">-                $MAKE $JOBS CFLAGS_FOR_BUILD="$HOSTCFLAGS" all-target-libgcc || touch .failed</span><br><span style="color: hsl(120, 100%, 40%);">+       if [ ! -f .failed -a "$(echo $TARGETARCH | grep -c -- -mingw32)" -eq 0 ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+              $MAKE $JOBS CFLAGS_FOR_BUILD="$HOSTCFLAGS" all-target-libgcc && \</span><br><span>          $MAKE install-target-libgcc DESTDIR=$DESTDIR || touch .failed</span><br><span>        fi</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26496">change 26496</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26496"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia064e0bfd96f0cbad391da3bb19e4dc304d988ff </div>
<div style="display:none"> Gerrit-Change-Number: 26496 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>