<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26463">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src: Add space after 'switch'<br><br>Change-Id: Ieddcd3d0742bc91283212e1b5ddf4a4521fd2d70<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/mainboard/amd/south_station/BiosCallOuts.c<br>M src/mainboard/amd/union_station/BiosCallOuts.c<br>M src/mainboard/asrock/e350m1/BiosCallOuts.c<br>M src/soc/broadcom/cygnus/shmoo_and28.c<br>4 files changed, 29 insertions(+), 29 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/26463/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/amd/south_station/BiosCallOuts.c b/src/mainboard/amd/south_station/BiosCallOuts.c</span><br><span>index 5b5e034..e80cb73 100644</span><br><span>--- a/src/mainboard/amd/south_station/BiosCallOuts.c</span><br><span>+++ b/src/mainboard/amd/south_station/BiosCallOuts.c</span><br><span>@@ -91,7 +91,7 @@</span><br><span> TempData8 |= Data8;</span><br><span> Write64Mem8(GpioMmioAddr+SB_GPIO_REG179, TempData8);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- switch(MemData->ParameterListPtr->DDR3Voltage){</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (MemData->ParameterListPtr->DDR3Voltage){</span><br><span> case VOLT1_35:</span><br><span> Data8 = Read64Mem8 (GpioMmioAddr+SB_GPIO_REG178);</span><br><span> Data8 &= ~(UINT8)BIT6;</span><br><span>diff --git a/src/mainboard/amd/union_station/BiosCallOuts.c b/src/mainboard/amd/union_station/BiosCallOuts.c</span><br><span>index 5b5e034..e80cb73 100644</span><br><span>--- a/src/mainboard/amd/union_station/BiosCallOuts.c</span><br><span>+++ b/src/mainboard/amd/union_station/BiosCallOuts.c</span><br><span>@@ -91,7 +91,7 @@</span><br><span> TempData8 |= Data8;</span><br><span> Write64Mem8(GpioMmioAddr+SB_GPIO_REG179, TempData8);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- switch(MemData->ParameterListPtr->DDR3Voltage){</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (MemData->ParameterListPtr->DDR3Voltage){</span><br><span> case VOLT1_35:</span><br><span> Data8 = Read64Mem8 (GpioMmioAddr+SB_GPIO_REG178);</span><br><span> Data8 &= ~(UINT8)BIT6;</span><br><span>diff --git a/src/mainboard/asrock/e350m1/BiosCallOuts.c b/src/mainboard/asrock/e350m1/BiosCallOuts.c</span><br><span>index 1f1e929..32a289d 100644</span><br><span>--- a/src/mainboard/asrock/e350m1/BiosCallOuts.c</span><br><span>+++ b/src/mainboard/asrock/e350m1/BiosCallOuts.c</span><br><span>@@ -90,7 +90,7 @@</span><br><span> /* this seems to be just copy-pasted from the AMD reference boards and needs</span><br><span> * some investigation</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">- switch(MemData->ParameterListPtr->DDR3Voltage){</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (MemData->ParameterListPtr->DDR3Voltage){</span><br><span> case VOLT1_35:</span><br><span> Data8 = Read64Mem8 (GpioMmioAddr+SB_GPIO_REG178);</span><br><span> Data8 &= ~(UINT8)BIT6;</span><br><span>diff --git a/src/soc/broadcom/cygnus/shmoo_and28.c b/src/soc/broadcom/cygnus/shmoo_and28.c</span><br><span>index 7038a31..68938dd 100644</span><br><span>--- a/src/soc/broadcom/cygnus/shmoo_and28.c</span><br><span>+++ b/src/soc/broadcom/cygnus/shmoo_and28.c</span><br><span>@@ -1160,7 +1160,7 @@</span><br><span> yCapMin = (*scPtr).yCapMin;</span><br><span> yCapMax = (*scPtr).yCapMax;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- switch(calibMode)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (calibMode)</span><br><span> {</span><br><span> case SHMOO_AND28_BIT:</span><br><span> iter = shmoo_dram_info_ptr->interface_bitwidth;</span><br><span>@@ -1337,7 +1337,7 @@</span><br><span> </span><br><span> switch ((*scPtr).shmooType) {</span><br><span> case SHMOO_AND28_RD_EN:</span><br><span style="color: hsl(0, 100%, 40%);">- switch(calibMode)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (calibMode)</span><br><span> {</span><br><span> case SHMOO_AND28_BIT:</span><br><span> printf("Unsupported shmoo type and calibration mode combination during set new step: %02u / %02u\n", (*scPtr).shmooType, calibMode);</span><br><span>@@ -1466,7 +1466,7 @@</span><br><span> }</span><br><span> #endif</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- switch(calibMode)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (calibMode)</span><br><span> {</span><br><span> case SHMOO_AND28_BIT:</span><br><span> printf("Unsupported shmoo type and calibration mode combination during set new step: %02u / %02u\n", (*scPtr).shmooType, calibMode);</span><br><span>@@ -1838,7 +1838,7 @@</span><br><span> }</span><br><span> break;</span><br><span> case SHMOO_AND28_WR_EXTENDED:</span><br><span style="color: hsl(0, 100%, 40%);">- switch(calibMode)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (calibMode)</span><br><span> {</span><br><span> case SHMOO_AND28_BIT:</span><br><span> printf("Unsupported shmoo type and calibration mode combination during set new step: %02u / %02u\n", (*scPtr).shmooType, calibMode);</span><br><span>@@ -2053,7 +2053,7 @@</span><br><span> }</span><br><span> break;</span><br><span> case SHMOO_AND28_ADDR_EXTENDED:</span><br><span style="color: hsl(0, 100%, 40%);">- switch(calibMode)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (calibMode)</span><br><span> {</span><br><span> case SHMOO_AND28_BIT:</span><br><span> printf("Unsupported shmoo type and calibration mode combination during set new step: %02u / %02u\n", (*scPtr).shmooType, calibMode);</span><br><span>@@ -2117,7 +2117,7 @@</span><br><span> }</span><br><span> else</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- switch(calibMode)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (calibMode)</span><br><span> {</span><br><span> case SHMOO_AND28_BIT:</span><br><span> printf("Unsupported shmoo type and calibration mode combination during set new step: %02u / %02u\n", (*scPtr).shmooType, calibMode);</span><br><span>@@ -2257,13 +2257,13 @@</span><br><span> </span><br><span> printf("\n\n");</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- switch(plotMode)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (plotMode)</span><br><span> {</span><br><span> case SHMOO_AND28_BIT:</span><br><span> iter = shmoo_dram_info_ptr->interface_bitwidth;</span><br><span> shiftAmount = 0;</span><br><span> dataMask = 0x1;</span><br><span style="color: hsl(0, 100%, 40%);">- switch(calibMode)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (calibMode)</span><br><span> {</span><br><span> case SHMOO_AND28_BIT:</span><br><span> calibShiftAmount = 0;</span><br><span>@@ -2286,7 +2286,7 @@</span><br><span> iter = shmoo_dram_info_ptr->interface_bitwidth >> 3;</span><br><span> shiftAmount = 3;</span><br><span> dataMask = 0xFF;</span><br><span style="color: hsl(0, 100%, 40%);">- switch(calibMode)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (calibMode)</span><br><span> {</span><br><span> case SHMOO_AND28_BIT:</span><br><span> printf("WARNING: Plot mode coerced from byte mode to bit mode\n");</span><br><span>@@ -2313,7 +2313,7 @@</span><br><span> iter = shmoo_dram_info_ptr->interface_bitwidth >> 4;</span><br><span> shiftAmount = 4;</span><br><span> dataMask = 0xFFFF;</span><br><span style="color: hsl(0, 100%, 40%);">- switch(calibMode)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (calibMode)</span><br><span> {</span><br><span> case SHMOO_AND28_BIT:</span><br><span> printf("WARNING: Plot mode coerced from halfword mode to bit mode\n");</span><br><span>@@ -2344,7 +2344,7 @@</span><br><span> iter = 1;</span><br><span> shiftAmount = 5;</span><br><span> dataMask = 0xFFFFFFFF;</span><br><span style="color: hsl(0, 100%, 40%);">- switch(calibMode)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (calibMode)</span><br><span> {</span><br><span> case SHMOO_AND28_BIT:</span><br><span> printf("WARNING: Plot mode coerced from word mode to bit mode\n");</span><br><span>@@ -2427,7 +2427,7 @@</span><br><span> printf(" **** VDL step size...: %3u.%03u ps\n", (step1000 / 1000), (step1000 % 1000));</span><br><span> printf(" **** UI size.........: %3u.%03u steps\n", (size1000UI / 1000), (size1000UI % 1000));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- switch((*scPtr).shmooType)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch ((*scPtr).shmooType)</span><br><span> {</span><br><span> case SHMOO_AND28_RD_EN:</span><br><span> printf(" **** Shmoo type......: RD_EN\n");</span><br><span>@@ -2462,7 +2462,7 @@</span><br><span> </span><br><span> if (sizeY > 1)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- switch(calibMode)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (calibMode)</span><br><span> {</span><br><span> case SHMOO_AND28_BIT:</span><br><span> printf(" *** Calib mode......: 2D Bit-wise\n");</span><br><span>@@ -2481,7 +2481,7 @@</span><br><span> return SOC_E_FAIL;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- switch(plotMode)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (plotMode)</span><br><span> {</span><br><span> case SHMOO_AND28_BIT:</span><br><span> printf(" *** Plot mode.......: 2D Bit-wise\n");</span><br><span>@@ -2567,7 +2567,7 @@</span><br><span> {</span><br><span> if (i == 0)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- switch(calibMode)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (calibMode)</span><br><span> {</span><br><span> case SHMOO_AND28_BIT:</span><br><span> printf(" *** Calib mode......: 1D Bit-wise\n");</span><br><span>@@ -2586,7 +2586,7 @@</span><br><span> return SOC_E_FAIL;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- switch(plotMode)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (plotMode)</span><br><span> {</span><br><span> case SHMOO_AND28_BIT:</span><br><span> printf(" *** Plot mode.......: 1D Bit-wise\n");</span><br><span>@@ -4298,7 +4298,7 @@</span><br><span> </span><br><span> if (action == SHMOO_AND28_ACTION_RESTORE)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- switch(ctlType)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (ctlType)</span><br><span> {</span><br><span> case SHMOO_AND28_CTL_TYPE_RSVP:</span><br><span> break;</span><br><span>@@ -4318,12 +4318,12 @@</span><br><span> }</span><br><span> else if ((action == SHMOO_AND28_ACTION_RUN) || (action == SHMOO_AND28_ACTION_RUN_AND_SAVE))</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- switch(ctlType)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (ctlType)</span><br><span> {</span><br><span> case SHMOO_AND28_CTL_TYPE_RSVP:</span><br><span> break;</span><br><span> case SHMOO_AND28_CTL_TYPE_1:</span><br><span style="color: hsl(0, 100%, 40%);">- switch(dramType)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (dramType)</span><br><span> {</span><br><span> #if (SHMOO_AND28_DRAM_TYPE == SHMOO_AND28_DRAM_TYPE_DDR3)</span><br><span> case SHMOO_AND28_DRAM_TYPE_DDR3:</span><br><span>@@ -4409,7 +4409,7 @@</span><br><span> else</span><br><span> {</span><br><span> /* Report only */</span><br><span style="color: hsl(0, 100%, 40%);">- switch(ctlType)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (ctlType)</span><br><span> {</span><br><span> case SHMOO_AND28_CTL_TYPE_RSVP:</span><br><span> break;</span><br><span>@@ -4464,7 +4464,7 @@</span><br><span> return SOC_E_FAIL;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- switch(shmoo_dram_info_ptr->data_rate_mbps)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (shmoo_dram_info_ptr->data_rate_mbps)</span><br><span> {</span><br><span> case 800:</span><br><span> pll_config = 0x018D0012;</span><br><span>@@ -4607,7 +4607,7 @@</span><br><span> /*A02*/ printf("A02. Configure timing parameters\n");</span><br><span> if (SHMOO_AND28_PHY_BITWIDTH_IS_32)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- switch(shmoo_dram_info_ptr->data_rate_mbps)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (shmoo_dram_info_ptr->data_rate_mbps)</span><br><span> {</span><br><span> case 800:</span><br><span> dram_timing1 = 0x0F040606;</span><br><span>@@ -4640,7 +4640,7 @@</span><br><span> }</span><br><span> else</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- switch(shmoo_dram_info_ptr->data_rate_mbps)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (shmoo_dram_info_ptr->data_rate_mbps)</span><br><span> {</span><br><span> case 800:</span><br><span> dram_timing1 = 0x0F040606;</span><br><span>@@ -4675,7 +4675,7 @@</span><br><span> dram_config = 0x00001000;</span><br><span> if (!SHMOO_AND28_PHY_BITWIDTH_IS_32)</span><br><span> dram_config |= 0x02000000;</span><br><span style="color: hsl(0, 100%, 40%);">- switch(shmoo_dram_info_ptr->num_rows)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (shmoo_dram_info_ptr->num_rows)</span><br><span> {</span><br><span> case 4096: dram_config |= 0x00000000; break;</span><br><span> case 8192: dram_config |= 0x00000010; break;</span><br><span>@@ -4686,7 +4686,7 @@</span><br><span> printf("Unsupported number of rows: %d\n", shmoo_dram_info_ptr->num_rows);</span><br><span> return SOC_E_FAIL;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- switch(shmoo_dram_info_ptr->num_columns)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (shmoo_dram_info_ptr->num_columns)</span><br><span> {</span><br><span> case 512: dram_config |= 0x00000000; break;</span><br><span> case 1024: dram_config |= 0x00000100; break;</span><br><span>@@ -4695,7 +4695,7 @@</span><br><span> printf("Unsupported number of columns: %d\n", shmoo_dram_info_ptr->num_columns);</span><br><span> return SOC_E_FAIL;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- switch(shmoo_dram_info_ptr->num_banks)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (shmoo_dram_info_ptr->num_banks)</span><br><span> {</span><br><span> case 4: dram_config |= 0x00000000; break;</span><br><span> case 8: dram_config |= 0x00000400; break;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26463">change 26463</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26463"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ieddcd3d0742bc91283212e1b5ddf4a4521fd2d70 </div>
<div style="display:none"> Gerrit-Change-Number: 26463 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>