<p>Pratikkumar V Prajapati has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26391">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">intel/common: change mca_configure API's def<br><br>add an unused param so that mca_configure can be called<br>by mp_run_on_all_cpus to run it on all cores.<br><br>Change-Id: I2395ee7fbedc829f040959b0021967f800693eeb<br>Signed-off-by: Pratik Prajapati <pratikkumar.v.prajapati@intel.com><br>---<br>M src/soc/intel/common/block/cpu/cpulib.c<br>M src/soc/intel/common/block/include/intelblocks/cpulib.h<br>M src/soc/intel/skylake/cpu.c<br>3 files changed, 6 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/26391/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/common/block/cpu/cpulib.c b/src/soc/intel/common/block/cpu/cpulib.c</span><br><span>index c67904f..00d7c3e 100644</span><br><span>--- a/src/soc/intel/common/block/cpu/cpulib.c</span><br><span>+++ b/src/soc/intel/common/block/cpu/cpulib.c</span><br><span>@@ -2,7 +2,7 @@</span><br><span> * This file is part of the coreboot project.</span><br><span> *</span><br><span> * Copyright (C) 2014 Google Inc.</span><br><span style="color: hsl(0, 100%, 40%);">- * Copyright (C) 2015 Intel Corporation.</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2015-2018 Intel Corporation.</span><br><span> *</span><br><span> * This program is free software; you can redistribute it and/or modify</span><br><span> * it under the terms of the GNU General Public License as published by</span><br><span>@@ -297,7 +297,7 @@</span><br><span> return msr.lo & 0xff;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void mca_configure(void)</span><br><span style="color: hsl(120, 100%, 40%);">+void mca_configure(void *unused)</span><br><span> {</span><br><span> msr_t msr;</span><br><span> int i;</span><br><span>@@ -306,6 +306,8 @@</span><br><span> msr = rdmsr(IA32_MCG_CAP);</span><br><span> num_banks = msr.lo & 0xff;</span><br><span> msr.lo = msr.hi = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ printk(BIOS_DEBUG, "CPU: mca_configure num banks %d\n", num_banks);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> for (i = 0; i < num_banks; i++) {</span><br><span> /* Clear the machine check status */</span><br><span> wrmsr(IA32_MC0_STATUS + (i * 4), msr);</span><br><span>diff --git a/src/soc/intel/common/block/include/intelblocks/cpulib.h b/src/soc/intel/common/block/include/intelblocks/cpulib.h</span><br><span>index 191459b..e50e4ab 100644</span><br><span>--- a/src/soc/intel/common/block/include/intelblocks/cpulib.h</span><br><span>+++ b/src/soc/intel/common/block/include/intelblocks/cpulib.h</span><br><span>@@ -157,6 +157,6 @@</span><br><span> uint32_t cpu_get_max_turbo_ratio(void);</span><br><span> </span><br><span> /* Configure Machine Check Architecture support */</span><br><span style="color: hsl(0, 100%, 40%);">-void mca_configure(void);</span><br><span style="color: hsl(120, 100%, 40%);">+void mca_configure(void* unused);</span><br><span> </span><br><span> #endif /* SOC_INTEL_COMMON_BLOCK_CPULIB_H */</span><br><span>diff --git a/src/soc/intel/skylake/cpu.c b/src/soc/intel/skylake/cpu.c</span><br><span>index d9e90d2..c0e5241 100644</span><br><span>--- a/src/soc/intel/skylake/cpu.c</span><br><span>+++ b/src/soc/intel/skylake/cpu.c</span><br><span>@@ -425,7 +425,7 @@</span><br><span> /* TODO(adurbin): This should only be done on a cold boot. Also, some</span><br><span> * of these banks are core vs package scope. For now every CPU clears</span><br><span> * every bank. */</span><br><span style="color: hsl(0, 100%, 40%);">- mca_configure();</span><br><span style="color: hsl(120, 100%, 40%);">+ mca_configure(NULL);</span><br><span> </span><br><span> /* Enable the local CPU apics */</span><br><span> enable_lapic_tpr();</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26391">change 26391</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26391"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I2395ee7fbedc829f040959b0021967f800693eeb </div>
<div style="display:none"> Gerrit-Change-Number: 26391 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati@intel.com> </div>