<p>Matthias Gazzari has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26388">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/nehalem: Fix smashed stack in romstage<br><br>Stack smashing was detected during raminit when not loading from MRC.<br>Adding CAR_GLOBAL to the ram timings variable solves the issue.<br><br>Tested on Lenovo X201i with 2+2 and 4+4 GB RAM.<br><br>Change-Id: I21b380db61be2aedc045201821d83e18e7d07ad1<br>Signed-off-by: Matthias Gazzari <mail@qtux.eu><br>---<br>M src/northbridge/intel/nehalem/raminit.c<br>1 file changed, 5 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/26388/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/intel/nehalem/raminit.c b/src/northbridge/intel/nehalem/raminit.c</span><br><span>index df88ef3..6a27b57 100644</span><br><span>--- a/src/northbridge/intel/nehalem/raminit.c</span><br><span>+++ b/src/northbridge/intel/nehalem/raminit.c</span><br><span>@@ -44,6 +44,7 @@</span><br><span> #include <cpu/intel/speedstep.h></span><br><span> #include <cpu/intel/turbo.h></span><br><span> #include <mrc_cache.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <arch/early_variables.h></span><br><span> #endif</span><br><span> </span><br><span> #if !REAL</span><br><span>@@ -282,6 +283,9 @@</span><br><span>   const struct ram_training *cached_training;</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Global allocation of timings_car */</span><br><span style="color: hsl(120, 100%, 40%);">+timing_bounds_t timings_car[64] CAR_GLOBAL;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static void</span><br><span> write_500(struct raminfo *info, int channel, u32 val, u16 addr, int bits,</span><br><span>       int flag);</span><br><span>@@ -3128,7 +3132,7 @@</span><br><span>         u8 reg_178;</span><br><span>  int niter;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  timing_bounds_t timings[64];</span><br><span style="color: hsl(120, 100%, 40%);">+  timing_bounds_t *timings = timings_car;</span><br><span>      int lane, rank, slot, channel;</span><br><span>       u8 reg178_center;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26388">change 26388</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26388"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I21b380db61be2aedc045201821d83e18e7d07ad1 </div>
<div style="display:none"> Gerrit-Change-Number: 26388 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matthias Gazzari <mail@qtux.eu> </div>