<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26367">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">util/intelmetool: Remove space after __attribute__<br><br>Change-Id: I22abdde918ba30803e7feae06eba4be0eb06b404<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M util/intelmetool/me.h<br>1 file changed, 22 insertions(+), 22 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/26367/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/intelmetool/me.h b/util/intelmetool/me.h</span><br><span>index ff69d7e..dfd5cbb 100644</span><br><span>--- a/util/intelmetool/me.h</span><br><span>+++ b/util/intelmetool/me.h</span><br><span>@@ -76,7 +76,7 @@</span><br><span> uint32_t boot_options_present: 1;</span><br><span> uint32_t ack_data: 3;</span><br><span> uint32_t bios_msg_ack: 4;</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed));</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed));</span><br><span> </span><br><span> #define PCI_ME_UMA 0x44</span><br><span> </span><br><span>@@ -86,7 +86,7 @@</span><br><span> uint32_t valid: 1;</span><br><span> uint32_t reserved_0: 14;</span><br><span> uint32_t set_to_one: 1;</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed));</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed));</span><br><span> </span><br><span> #define PCI_ME_H_GS 0x4c</span><br><span> #define ME_INIT_DONE 1</span><br><span>@@ -99,7 +99,7 @@</span><br><span> uint32_t reserved: 8;</span><br><span> uint32_t status: 4;</span><br><span> uint32_t init_done: 4;</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed));</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed));</span><br><span> </span><br><span> #define PCI_ME_GMES 0x48</span><br><span> #define ME_GMES_PHASE_ROM 0</span><br><span>@@ -125,7 +125,7 @@</span><br><span> uint32_t current_state: 8;</span><br><span> uint32_t current_pmevent: 4;</span><br><span> uint32_t progress_code: 4;</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed));</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed));</span><br><span> </span><br><span> #define PCI_ME_HERES 0xbc</span><br><span> #define PCI_ME_EXT_SHA1 0x00</span><br><span>@@ -137,14 +137,14 @@</span><br><span> uint32_t reserved: 26;</span><br><span> uint32_t extend_feature_present: 1;</span><br><span> uint32_t extend_reg_valid: 1;</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed));</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed));</span><br><span> </span><br><span> struct me_thermal_reporting {</span><br><span> uint32_t polling_timeout: 8;</span><br><span> uint32_t smbus_ec_msglen: 8;</span><br><span> uint32_t smbus_ec_msgpec: 8;</span><br><span> uint32_t dimmnumber: 8;</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed));</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed));</span><br><span> </span><br><span> /*</span><br><span> * Management Engine MEI registers</span><br><span>@@ -165,7 +165,7 @@</span><br><span> uint32_t buffer_read_ptr: 8;</span><br><span> uint32_t buffer_write_ptr: 8;</span><br><span> uint32_t buffer_depth: 8;</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed));</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed));</span><br><span> </span><br><span> #define MEI_ADDRESS_HBM 0x00</span><br><span> #define MEI_ADDRESS_CORE_WD 0x01</span><br><span>@@ -187,7 +187,7 @@</span><br><span> uint32_t length: 9;</span><br><span> uint32_t reserved: 6;</span><br><span> uint32_t is_complete: 1;</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed));</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed));</span><br><span> </span><br><span> #define MKHI_GROUP_ID_CBM 0x00</span><br><span> #define MKHI_GROUP_ID_PM 0x01</span><br><span>@@ -231,7 +231,7 @@</span><br><span> uint32_t is_response: 1;</span><br><span> uint32_t reserved: 8;</span><br><span> uint32_t result: 8;</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed));</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed));</span><br><span> </span><br><span> struct me_fw_version {</span><br><span> uint16_t code_minor;</span><br><span>@@ -246,7 +246,7 @@</span><br><span> uint16_t fitcmajor;</span><br><span> uint16_t fitcbuildno;</span><br><span> uint16_t fitchotfix;</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed));</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed));</span><br><span> </span><br><span> </span><br><span> #define HECI_EOP_STATUS_SUCCESS 0x0</span><br><span>@@ -261,7 +261,7 @@</span><br><span> struct me_global_reset {</span><br><span> uint8_t request_origin;</span><br><span> uint8_t reset_type;</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed));</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed));</span><br><span> </span><br><span> typedef enum {</span><br><span> ME_NORMAL_BIOS_PATH,</span><br><span>@@ -277,7 +277,7 @@</span><br><span> uint32_t minor_version : 16;</span><br><span> uint32_t hotfix_version : 16;</span><br><span> uint32_t build_version : 16;</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed)) mbp_fw_version_name;</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed)) mbp_fw_version_name;</span><br><span> </span><br><span> typedef struct {</span><br><span> uint8_t num_icc_profiles;</span><br><span>@@ -285,7 +285,7 @@</span><br><span> uint8_t icc_profile_index;</span><br><span> uint8_t reserved;</span><br><span> uint32_t register_lock_mask[3];</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed)) mbp_icc_profile;</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed)) mbp_icc_profile;</span><br><span> </span><br><span> typedef struct {</span><br><span> uint32_t full_net : 1;</span><br><span>@@ -308,7 +308,7 @@</span><br><span> uint32_t reserved_4 : 1;</span><br><span> uint32_t wlan : 1;</span><br><span> uint32_t reserved_5 : 8;</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed)) mefwcaps_sku;</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed)) mefwcaps_sku;</span><br><span> </span><br><span> typedef struct {</span><br><span> uint16_t lock_state : 1;</span><br><span>@@ -319,13 +319,13 @@</span><br><span> uint16_t wwan3gpresent : 1;</span><br><span> uint16_t wwan3goob : 1;</span><br><span> uint16_t reserved : 9;</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed)) tdt_state_flag;</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed)) tdt_state_flag;</span><br><span> </span><br><span> typedef struct {</span><br><span> uint8_t state;</span><br><span> uint8_t last_theft_trigger;</span><br><span> tdt_state_flag flags;</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed)) tdt_state_info;</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed)) tdt_state_info;</span><br><span> </span><br><span> typedef struct {</span><br><span> uint32_t platform_target_usage_type : 4;</span><br><span>@@ -335,7 +335,7 @@</span><br><span> uint32_t intel_me_fw_image_type : 4;</span><br><span> uint32_t platform_brand : 4;</span><br><span> uint32_t reserved_1 : 16;</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed)) platform_type_rule_data;</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed)) platform_type_rule_data;</span><br><span> </span><br><span> typedef struct {</span><br><span> mefwcaps_sku fw_capabilities;</span><br><span>@@ -346,7 +346,7 @@</span><br><span> uint16_t device_id;</span><br><span> uint16_t fuse_test_flags;</span><br><span> uint32_t umchid[4];</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed)) mbp_rom_bist_data;</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed)) mbp_rom_bist_data;</span><br><span> </span><br><span> typedef struct {</span><br><span> uint32_t key[8];</span><br><span>@@ -372,28 +372,28 @@</span><br><span> uint32_t mbp_size : 8;</span><br><span> uint32_t num_entries : 8;</span><br><span> uint32_t rsvd : 16;</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed)) mbp_header;</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed)) mbp_header;</span><br><span> </span><br><span> typedef struct {</span><br><span> uint32_t app_id : 8;</span><br><span> uint32_t item_id : 8;</span><br><span> uint32_t length : 8;</span><br><span> uint32_t rsvd : 8;</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed)) mbp_item_header;</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed)) mbp_item_header;</span><br><span> </span><br><span> struct me_fwcaps {</span><br><span> uint32_t id;</span><br><span> uint8_t length;</span><br><span> mefwcaps_sku caps_sku;</span><br><span> uint8_t reserved[3];</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed));</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed));</span><br><span> </span><br><span> struct me_debug_mem {</span><br><span> uint32_t debug_phys;</span><br><span> uint32_t debug_size;</span><br><span> uint32_t me_phys;</span><br><span> uint32_t me_size;</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed));</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed));</span><br><span> </span><br><span> void intel_me_status(uint32_t hfs, uint32_t gmes);</span><br><span> void mkhi_thermal(void);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26367">change 26367</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26367"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I22abdde918ba30803e7feae06eba4be0eb06b404 </div>
<div style="display:none"> Gerrit-Change-Number: 26367 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>