<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26305">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gma ddi: Move conditionally used Program_Buffer_Translations()<br><br>When compiled for Broxton, Buffers.Translations() is a stub and GCC 8<br>correctly identifies the use of unitialized fields. However, it can't<br>see that it's never called in that case. Draw the definition of<br>Program_Buffer_Translations() inside the respective `if` to make that<br>clear.<br><br>Change-Id: I8edbb8ac9249d76465d1cd07526fb6eeef0618e1<br>Signed-off-by: Nico Huber <nico.h@gmx.de><br>---<br>M common/haswell_shared/hw-gfx-gma-connectors-ddi.adb<br>1 file changed, 21 insertions(+), 18 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/05/26305/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/common/haswell_shared/hw-gfx-gma-connectors-ddi.adb b/common/haswell_shared/hw-gfx-gma-connectors-ddi.adb</span><br><span>index b6d7284..88f2b22 100644</span><br><span>--- a/common/haswell_shared/hw-gfx-gma-connectors-ddi.adb</span><br><span>+++ b/common/haswell_shared/hw-gfx-gma-connectors-ddi.adb</span><br><span>@@ -296,29 +296,32 @@</span><br><span> </span><br><span> ----------------------------------------------------------------------------</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- procedure Program_Buffer_Translations (Port : Digital_Port)</span><br><span style="color: hsl(0, 100%, 40%);">- is</span><br><span style="color: hsl(0, 100%, 40%);">- Buffer_Translations : Buf_Trans_Array;</span><br><span style="color: hsl(0, 100%, 40%);">- begin</span><br><span style="color: hsl(0, 100%, 40%);">- Buffers.Translations (Buffer_Translations, Port);</span><br><span style="color: hsl(0, 100%, 40%);">- for I in Buf_Trans_Range loop</span><br><span style="color: hsl(0, 100%, 40%);">- Registers.Write</span><br><span style="color: hsl(0, 100%, 40%);">- (Register => DDI_Regs (Port).BUF_TRANS (I),</span><br><span style="color: hsl(0, 100%, 40%);">- Value => Buffer_Translations (I));</span><br><span style="color: hsl(0, 100%, 40%);">- end loop;</span><br><span style="color: hsl(0, 100%, 40%);">- end Program_Buffer_Translations;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> procedure Initialize</span><br><span> is</span><br><span> Iboost_Value : constant Word32 := 1;</span><br><span> begin</span><br><span> if Config.Has_DDI_Buffer_Trans then</span><br><span style="color: hsl(0, 100%, 40%);">- for Port in Digital_Port range DIGI_A .. Config.Last_Digital_Port loop</span><br><span style="color: hsl(0, 100%, 40%);">- Program_Buffer_Translations (Port);</span><br><span style="color: hsl(0, 100%, 40%);">- end loop;</span><br><span style="color: hsl(0, 100%, 40%);">- if Config.Is_FDI_Port (Analog) then</span><br><span style="color: hsl(0, 100%, 40%);">- Program_Buffer_Translations (DIGI_E);</span><br><span style="color: hsl(0, 100%, 40%);">- end if;</span><br><span style="color: hsl(120, 100%, 40%);">+ declare</span><br><span style="color: hsl(120, 100%, 40%);">+ procedure Program_Buffer_Translations (Port : Digital_Port)</span><br><span style="color: hsl(120, 100%, 40%);">+ is</span><br><span style="color: hsl(120, 100%, 40%);">+ Buffer_Translations : Buf_Trans_Array;</span><br><span style="color: hsl(120, 100%, 40%);">+ begin</span><br><span style="color: hsl(120, 100%, 40%);">+ Buffers.Translations (Buffer_Translations, Port);</span><br><span style="color: hsl(120, 100%, 40%);">+ for I in Buf_Trans_Range loop</span><br><span style="color: hsl(120, 100%, 40%);">+ Registers.Write</span><br><span style="color: hsl(120, 100%, 40%);">+ (Register => DDI_Regs (Port).BUF_TRANS (I),</span><br><span style="color: hsl(120, 100%, 40%);">+ Value => Buffer_Translations (I));</span><br><span style="color: hsl(120, 100%, 40%);">+ end loop;</span><br><span style="color: hsl(120, 100%, 40%);">+ end Program_Buffer_Translations;</span><br><span style="color: hsl(120, 100%, 40%);">+ begin</span><br><span style="color: hsl(120, 100%, 40%);">+ for Port in Digital_Port range DIGI_A .. Config.Last_Digital_Port</span><br><span style="color: hsl(120, 100%, 40%);">+ loop</span><br><span style="color: hsl(120, 100%, 40%);">+ Program_Buffer_Translations (Port);</span><br><span style="color: hsl(120, 100%, 40%);">+ end loop;</span><br><span style="color: hsl(120, 100%, 40%);">+ if Config.Is_FDI_Port (Analog) then</span><br><span style="color: hsl(120, 100%, 40%);">+ Program_Buffer_Translations (DIGI_E);</span><br><span style="color: hsl(120, 100%, 40%);">+ end if;</span><br><span style="color: hsl(120, 100%, 40%);">+ end;</span><br><span> end if;</span><br><span> </span><br><span> if Config.Has_Iboost_Config then</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26305">change 26305</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26305"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libgfxinit </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I8edbb8ac9249d76465d1cd07526fb6eeef0618e1 </div>
<div style="display:none"> Gerrit-Change-Number: 26305 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>