<p>Chris Zhou has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26282">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy: Fix SoC I2C CLK is abnormal<br><br>The I2C CLKs of SoC should be 400kHz, but waveform show 460kHz to<br>470kHz. Add I2C parameters to adjust I2C CLKs which 5% lower than<br>400kHz.<br><br>BUG=b:78819970<br>TEST=The I2C CLKs are 5% lower than 400kHz.<br><br>Change-Id: I2c3012b5b59c089801cda8fd7b0c433aad9df36d<br>Signed-off-by: Chris Zhou <chris_zhou@compal.corp-partner.google.com><br>---<br>M src/mainboard/google/poppy/variants/nami/devicetree.cb<br>1 file changed, 40 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/26282/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb</span><br><span>index 1cc2a5e..94a859e 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nami/devicetree.cb</span><br><span>+++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb</span><br><span>@@ -197,15 +197,52 @@</span><br><span> </span><br><span> # Touchscreen</span><br><span> register "i2c_voltage[0]" = "I2C_VOLTAGE_3V3"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "i2c[0]" = "{</span><br><span style="color: hsl(120, 100%, 40%);">+ .speed = I2C_SPEED_FAST,</span><br><span style="color: hsl(120, 100%, 40%);">+ .speed_config[0] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .speed = I2C_SPEED_FAST,</span><br><span style="color: hsl(120, 100%, 40%);">+ .scl_lcnt = 185,</span><br><span style="color: hsl(120, 100%, 40%);">+ .scl_hcnt = 90,</span><br><span style="color: hsl(120, 100%, 40%);">+ .sda_hold = 36,</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ }"</span><br><span> </span><br><span> # Trackpad</span><br><span> register "i2c_voltage[1]" = "I2C_VOLTAGE_3V3"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "i2c[1]" = "{</span><br><span style="color: hsl(120, 100%, 40%);">+ .early_init = 1,</span><br><span style="color: hsl(120, 100%, 40%);">+ .speed = I2C_SPEED_FAST,</span><br><span style="color: hsl(120, 100%, 40%);">+ .speed_config[0] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .speed = I2C_SPEED_FAST,</span><br><span style="color: hsl(120, 100%, 40%);">+ .scl_lcnt = 185,</span><br><span style="color: hsl(120, 100%, 40%);">+ .scl_hcnt = 90,</span><br><span style="color: hsl(120, 100%, 40%);">+ .sda_hold = 36,</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ }"</span><br><span> </span><br><span> # Pen</span><br><span> register "i2c_voltage[2]" = "I2C_VOLTAGE_1V8"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "i2c[2]" = "{</span><br><span style="color: hsl(120, 100%, 40%);">+ .speed = I2C_SPEED_FAST,</span><br><span style="color: hsl(120, 100%, 40%);">+ .speed_config[0] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .speed = I2C_SPEED_FAST,</span><br><span style="color: hsl(120, 100%, 40%);">+ .scl_lcnt = 185,</span><br><span style="color: hsl(120, 100%, 40%);">+ .scl_hcnt = 100,</span><br><span style="color: hsl(120, 100%, 40%);">+ .sda_hold = 36,</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ }"</span><br><span> </span><br><span> # Audio</span><br><span> register "i2c_voltage[3]" = "I2C_VOLTAGE_1V8"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "i2c[3]" = "{</span><br><span style="color: hsl(120, 100%, 40%);">+ .speed = I2C_SPEED_FAST,</span><br><span style="color: hsl(120, 100%, 40%);">+ .speed_config[0] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .speed = I2C_SPEED_FAST,</span><br><span style="color: hsl(120, 100%, 40%);">+ .scl_lcnt = 195,</span><br><span style="color: hsl(120, 100%, 40%);">+ .scl_hcnt = 90,</span><br><span style="color: hsl(120, 100%, 40%);">+ .sda_hold = 36,</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ }"</span><br><span> </span><br><span> # Use GSPI0 for cr50 TPM. Early init is required to set up a BAR for TPM</span><br><span> # communication before memory is up.</span><br><span>@@ -301,11 +338,11 @@</span><br><span> end</span><br><span> chip drivers/generic/gpio_keys</span><br><span> register "name" = ""PENH""</span><br><span style="color: hsl(0, 100%, 40%);">- register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_HIGH(GPP_E8)"</span><br><span style="color: hsl(0, 100%, 40%);">- register "key.dev_name" = ""INST""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_E8)"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "key.dev_name" = ""EJCT""</span><br><span> register "key.linux_code" = "SW_PEN_INSERTED"</span><br><span> register "key.linux_input_type" = "EV_SW"</span><br><span style="color: hsl(0, 100%, 40%);">- register "key.label" = ""pen_insert""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "key.label" = ""pen_eject""</span><br><span> device generic 0 on end</span><br><span> end</span><br><span> end # I2C #2</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26282">change 26282</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26282"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I2c3012b5b59c089801cda8fd7b0c433aad9df36d </div>
<div style="display:none"> Gerrit-Change-Number: 26282 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Chris Zhou <chris_zhou@compal.corp-partner.google.com> </div>