<p>Subrata Banik has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26215">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">drivers/intel/gma: Allocate vbt_data on heap instead of .bss<br><br>TEST=Display in working find on KBL platform.<br><br>Change-Id: Iac5d52847389298f48baaf497e9bf5dff18175c7<br>Signed-off-by: Subrata Banik <subrata.banik@intel.com><br>---<br>M src/drivers/intel/gma/opregion.c<br>1 file changed, 6 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/26215/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/intel/gma/opregion.c b/src/drivers/intel/gma/opregion.c</span><br><span>index c52c06f1..6fe03f6 100644</span><br><span>--- a/src/drivers/intel/gma/opregion.c</span><br><span>+++ b/src/drivers/intel/gma/opregion.c</span><br><span>@@ -33,12 +33,16 @@</span><br><span>      return "vbt.bin";</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static char vbt_data[8 * KiB];</span><br><span> static int vbt_data_used;</span><br><span> </span><br><span> void *locate_vbt(size_t *vbt_size)</span><br><span> {</span><br><span>       uint32_t vbtsig = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+  size_t length = 8 * KiB;</span><br><span style="color: hsl(120, 100%, 40%);">+      char *vbt_data = malloc(length);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+    if (!vbt_data)</span><br><span style="color: hsl(120, 100%, 40%);">+                return NULL;</span><br><span> </span><br><span>     if (vbt_data_used == 1)</span><br><span>              return (void *)vbt_data;</span><br><span>@@ -46,7 +50,7 @@</span><br><span>         const char *filename = mainboard_vbt_filename();</span><br><span> </span><br><span>         size_t file_size = cbfs_boot_load_file(filename,</span><br><span style="color: hsl(0, 100%, 40%);">-                vbt_data, sizeof(vbt_data), CBFS_TYPE_RAW);</span><br><span style="color: hsl(120, 100%, 40%);">+           vbt_data, length, CBFS_TYPE_RAW);</span><br><span> </span><br><span>        if (file_size == 0)</span><br><span>          return NULL;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26215">change 26215</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26215"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iac5d52847389298f48baaf497e9bf5dff18175c7 </div>
<div style="display:none"> Gerrit-Change-Number: 26215 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>