<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26151">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/mainboard: Serialize methods with named objects inside<br><br>Change-Id: I90e1d8b9f8e37bec8fc2796637b4548ea17e076b<br>Signed-off-by: Martin Roth <martinroth@google.com><br>---<br>M src/mainboard/amd/mahogany/acpi/ide.asl<br>M src/mainboard/getac/p470/acpi/battery.asl<br>M src/mainboard/getac/p470/acpi/ec.asl<br>M src/mainboard/getac/p470/acpi/superio.asl<br>M src/mainboard/google/cyan/acpi/mainboard.asl<br>M src/mainboard/intel/strago/acpi/mainboard.asl<br>6 files changed, 14 insertions(+), 14 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/26151/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/amd/mahogany/acpi/ide.asl b/src/mainboard/amd/mahogany/acpi/ide.asl</span><br><span>index 5c155cf..694ab23 100644</span><br><span>--- a/src/mainboard/amd/mahogany/acpi/ide.asl</span><br><span>+++ b/src/mainboard/amd/mahogany/acpi/ide.asl</span><br><span>@@ -73,7 +73,7 @@</span><br><span> Device(PRID)</span><br><span> {</span><br><span> Name (_ADR, Zero)</span><br><span style="color: hsl(0, 100%, 40%);">- Method(_GTM, 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ Method(_GTM, 0, Serialized)</span><br><span> {</span><br><span> NAME(OTBF, Buffer(20) { /* out buffer */</span><br><span> 0xFF, 0xFF, 0xFF, 0xFF,</span><br><span>@@ -118,7 +118,7 @@</span><br><span> Return(OTBF) /* out buffer */</span><br><span> } /* End Method(_GTM) */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Method(_STM, 3, NotSerialized)</span><br><span style="color: hsl(120, 100%, 40%);">+ Method(_STM, 3, Serialized)</span><br><span> {</span><br><span> NAME(INBF, Buffer(20) { /* in buffer */</span><br><span> 0xFF, 0xFF, 0xFF, 0xFF,</span><br><span>@@ -169,7 +169,7 @@</span><br><span> Device(MST)</span><br><span> {</span><br><span> Name(_ADR, 0)</span><br><span style="color: hsl(0, 100%, 40%);">- Method(_GTF) {</span><br><span style="color: hsl(120, 100%, 40%);">+ Method(_GTF, 0, Serialized) {</span><br><span> Name(CMBF, Buffer(21) {</span><br><span> 0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,</span><br><span> 0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,</span><br><span>@@ -205,7 +205,7 @@</span><br><span> Device(SLAV)</span><br><span> {</span><br><span> Name(_ADR, 1)</span><br><span style="color: hsl(0, 100%, 40%);">- Method(_GTF) {</span><br><span style="color: hsl(120, 100%, 40%);">+ Method(_GTF, 0, Serialized) {</span><br><span> Name(CMBF, Buffer(21) {</span><br><span> 0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,</span><br><span> 0x03, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xEF,</span><br><span>diff --git a/src/mainboard/getac/p470/acpi/battery.asl b/src/mainboard/getac/p470/acpi/battery.asl</span><br><span>index 48f1eca..592bce0 100644</span><br><span>--- a/src/mainboard/getac/p470/acpi/battery.asl</span><br><span>+++ b/src/mainboard/getac/p470/acpi/battery.asl</span><br><span>@@ -40,7 +40,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Battery Info */</span><br><span style="color: hsl(0, 100%, 40%);">- Method(_BIF, 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ Method(_BIF, 0, Serialized)</span><br><span> {</span><br><span> Name(PBIF, Package() {</span><br><span> 0x01,</span><br><span>@@ -145,7 +145,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Battery Info */</span><br><span style="color: hsl(0, 100%, 40%);">- Method(_BIF, 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ Method(_BIF, 0, Serialized)</span><br><span> {</span><br><span> Name(PBIF, Package() {</span><br><span> 0x01,</span><br><span>diff --git a/src/mainboard/getac/p470/acpi/ec.asl b/src/mainboard/getac/p470/acpi/ec.asl</span><br><span>index 91846f1..7420d4a 100644</span><br><span>--- a/src/mainboard/getac/p470/acpi/ec.asl</span><br><span>+++ b/src/mainboard/getac/p470/acpi/ec.asl</span><br><span>@@ -86,7 +86,7 @@</span><br><span> ODDS, 1</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Method (_CRS, 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_CRS, 0, Serialized)</span><br><span> {</span><br><span> Name (ECMD, ResourceTemplate()</span><br><span> {</span><br><span>diff --git a/src/mainboard/getac/p470/acpi/superio.asl b/src/mainboard/getac/p470/acpi/superio.asl</span><br><span>index e9b5f0c..9bf07ce 100644</span><br><span>--- a/src/mainboard/getac/p470/acpi/superio.asl</span><br><span>+++ b/src/mainboard/getac/p470/acpi/superio.asl</span><br><span>@@ -106,7 +106,7 @@</span><br><span> })</span><br><span> </span><br><span> /* Current Resource Settings */</span><br><span style="color: hsl(0, 100%, 40%);">- Method(_CRS, 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ Method(_CRS, 0, Serialized)</span><br><span> {</span><br><span> Name(NONE, ResourceTemplate() {</span><br><span> IO(Decode16, 0x000, 0x000, 0x0, 0x1)</span><br><span>@@ -256,7 +256,7 @@</span><br><span> })</span><br><span> </span><br><span> /* Current Resource Settings */</span><br><span style="color: hsl(0, 100%, 40%);">- Method(_CRS, 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ Method(_CRS, 0, Serialized)</span><br><span> {</span><br><span> Name(NONE, ResourceTemplate() {</span><br><span> IO(Decode16, 0x000, 0x000, 0x0, 0x1)</span><br><span>@@ -405,7 +405,7 @@</span><br><span> })</span><br><span> </span><br><span> /* Current Resource Settings */</span><br><span style="color: hsl(0, 100%, 40%);">- Method(_CRS, 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ Method(_CRS, 0, Serialized)</span><br><span> {</span><br><span> Name(NONE, ResourceTemplate() {</span><br><span> IO(Decode16, 0x000, 0x000, 0x0, 0x1)</span><br><span>@@ -552,7 +552,7 @@</span><br><span> })</span><br><span> </span><br><span> /* Current Resource Settings */</span><br><span style="color: hsl(0, 100%, 40%);">- Method(_CRS, 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ Method(_CRS, 0, Serialized)</span><br><span> {</span><br><span> Name(NONE, ResourceTemplate() {</span><br><span> IO(Decode16, 0x000, 0x000, 0x0, 0x1)</span><br><span>diff --git a/src/mainboard/google/cyan/acpi/mainboard.asl b/src/mainboard/google/cyan/acpi/mainboard.asl</span><br><span>index 3228a31..1859fa8 100644</span><br><span>--- a/src/mainboard/google/cyan/acpi/mainboard.asl</span><br><span>+++ b/src/mainboard/google/cyan/acpi/mainboard.asl</span><br><span>@@ -28,7 +28,7 @@</span><br><span> </span><br><span> Scope (\_SB.GPNC)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- Method (_AEI, 0, NotSerialized) // _AEI: ACPI Event Interrupts</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_AEI, 0, Serialized) // _AEI: ACPI Event Interrupts</span><br><span> {</span><br><span> Name (RBUF, ResourceTemplate ()</span><br><span> {</span><br><span>diff --git a/src/mainboard/intel/strago/acpi/mainboard.asl b/src/mainboard/intel/strago/acpi/mainboard.asl</span><br><span>index eaf9e85..68ac133 100644</span><br><span>--- a/src/mainboard/intel/strago/acpi/mainboard.asl</span><br><span>+++ b/src/mainboard/intel/strago/acpi/mainboard.asl</span><br><span>@@ -35,7 +35,7 @@</span><br><span> Name (_UID, 4)</span><br><span> Name (ISTP, 0) /* TouchScreen */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Method(_CRS, 0x0, NotSerialized)</span><br><span style="color: hsl(120, 100%, 40%);">+ Method(_CRS, 0x0, Serialized)</span><br><span> {</span><br><span> Name (BUF0, ResourceTemplate ()</span><br><span> {</span><br><span>@@ -195,7 +195,7 @@</span><br><span> </span><br><span> Scope (\_SB.GPNC)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- Method (_AEI, 0, NotSerialized) // _AEI: ACPI Event Interrupts</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_AEI, 0, Serialized) // _AEI: ACPI Event Interrupts</span><br><span> {</span><br><span> Name (RBUF, ResourceTemplate ()</span><br><span> {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26151">change 26151</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26151"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I90e1d8b9f8e37bec8fc2796637b4548ea17e076b </div>
<div style="display:none"> Gerrit-Change-Number: 26151 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>