<p><a href="https://review.coreboot.org/26164">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26164/1/src/soc/intel/common/block/uart/uart.c">File src/soc/intel/common/block/uart/uart.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26164/1/src/soc/intel/common/block/uart/uart.c@96">Patch Set #1, Line 96:</a> <code style="font-family:monospace,monospace">UART_BASE_0_ADDR(CONFIG_UART_FOR_CONSOLE);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">use something like this</p><p style="white-space: pre-wrap; word-wrap: break-word;">in skylake/cannonlake soc/iomap.h<br>#define UART_BAR  UART_BASE_0_ADDR(CONFIG_UART_FOR_CONSOLE)</p><p style="white-space: pre-wrap; word-wrap: break-word;">in apl soc/iomap.h</p><p style="white-space: pre-wrap; word-wrap: break-word;">#define UART_BAR CONFIG_CONSOLE_UART_BASE_ADDRESS</p><p style="white-space: pre-wrap; word-wrap: break-word;">in this way u can get-rid of ugly https://review.coreboot.org/#/c/coreboot/+/26164/1/src/soc/intel/apollolake/include/soc/iomap.h</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/26164">change 26164</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26164"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I109d0e5c942e499cb763bde47cb7d53dfbf5cef6 </div>
<div style="display:none"> Gerrit-Change-Number: 26164 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 08 May 2018 09:05:53 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>