<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26150">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/bap/ode_e20xx: Remove commented out asl code.<br><br>Change-Id: I64229d12e9e7fd54eaae3425ae9546872c5bf8f3<br>Signed-off-by: Martin Roth <martinroth@google.com><br>---<br>M src/mainboard/bap/ode_e20XX/acpi/sata.asl<br>1 file changed, 0 insertions(+), 145 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/26150/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/bap/ode_e20XX/acpi/sata.asl b/src/mainboard/bap/ode_e20XX/acpi/sata.asl</span><br><span>index 6755258..f675323 100644</span><br><span>--- a/src/mainboard/bap/ode_e20XX/acpi/sata.asl</span><br><span>+++ b/src/mainboard/bap/ode_e20XX/acpi/sata.asl</span><br><span>@@ -1,146 +1 @@</span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(0, 100%, 40%);">- * This file is part of the coreboot project.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * Copyright (C) 2012-2013 Advanced Micro Devices, Inc.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(0, 100%, 40%);">- * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(0, 100%, 40%);">- * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(0, 100%, 40%);">- * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(0, 100%, 40%);">- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(0, 100%, 40%);">- * GNU General Public License for more details.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* No SATA functionality */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#if 0</span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(0, 100%, 40%);">-Scope (_SB) {</span><br><span style="color: hsl(0, 100%, 40%);">- Device(PCI0) {</span><br><span style="color: hsl(0, 100%, 40%);">- Device(SATA) {</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_ADR, 0x00110000)</span><br><span style="color: hsl(0, 100%, 40%);">- #include "sata.asl"</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-*/</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-Name(STTM, Buffer(20) {</span><br><span style="color: hsl(0, 100%, 40%);">- 0x78, 0x00, 0x00, 0x00, 0x0f, 0x00, 0x00, 0x00,</span><br><span style="color: hsl(0, 100%, 40%);">- 0x78, 0x00, 0x00, 0x00, 0x0f, 0x00, 0x00, 0x00,</span><br><span style="color: hsl(0, 100%, 40%);">- 0x1f, 0x00, 0x00, 0x00</span><br><span style="color: hsl(0, 100%, 40%);">-})</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/* Start by clearing the PhyRdyChg bits */</span><br><span style="color: hsl(0, 100%, 40%);">-Method(_INI) {</span><br><span style="color: hsl(0, 100%, 40%);">- \_GPE._L1F()</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-Device(PMRY)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_ADR, 0)</span><br><span style="color: hsl(0, 100%, 40%);">- Method(_GTM, 0x0, NotSerialized) {</span><br><span style="color: hsl(0, 100%, 40%);">- Return(STTM)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- Method(_STM, 0x3, NotSerialized) {}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Device(PMST) {</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_ADR, 0)</span><br><span style="color: hsl(0, 100%, 40%);">- Method(_STA,0) {</span><br><span style="color: hsl(0, 100%, 40%);">- if (LGreater(P0IS,0)) {</span><br><span style="color: hsl(0, 100%, 40%);">- return (0x0F) /* sata is visible */</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- else {</span><br><span style="color: hsl(0, 100%, 40%);">- return (0x00) /* sata is missing */</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }/* end of PMST */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Device(PSLA)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_ADR, 1)</span><br><span style="color: hsl(0, 100%, 40%);">- Method(_STA,0) {</span><br><span style="color: hsl(0, 100%, 40%);">- if (LGreater(P1IS,0)) {</span><br><span style="color: hsl(0, 100%, 40%);">- return (0x0F) /* sata is visible */</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- else {</span><br><span style="color: hsl(0, 100%, 40%);">- return (0x00) /* sata is missing */</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- } /* end of PSLA */</span><br><span style="color: hsl(0, 100%, 40%);">-} /* end of PMRY */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-Device(SEDY)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_ADR, 1) /* IDE Scondary Channel */</span><br><span style="color: hsl(0, 100%, 40%);">- Method(_GTM, 0x0, NotSerialized) {</span><br><span style="color: hsl(0, 100%, 40%);">- Return(STTM)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- Method(_STM, 0x3, NotSerialized) {}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Device(SMST)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_ADR, 0)</span><br><span style="color: hsl(0, 100%, 40%);">- Method(_STA,0) {</span><br><span style="color: hsl(0, 100%, 40%);">- if (LGreater(P2IS,0)) {</span><br><span style="color: hsl(0, 100%, 40%);">- return (0x0F) /* sata is visible */</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- else {</span><br><span style="color: hsl(0, 100%, 40%);">- return (0x00) /* sata is missing */</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- } /* end of SMST */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Device(SSLA)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_ADR, 1)</span><br><span style="color: hsl(0, 100%, 40%);">- Method(_STA,0) {</span><br><span style="color: hsl(0, 100%, 40%);">- if (LGreater(P3IS,0)) {</span><br><span style="color: hsl(0, 100%, 40%);">- return (0x0F) /* sata is visible */</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- else {</span><br><span style="color: hsl(0, 100%, 40%);">- return (0x00) /* sata is missing */</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- } /* end of SSLA */</span><br><span style="color: hsl(0, 100%, 40%);">-} /* end of SEDY */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/* SATA Hot Plug Support */</span><br><span style="color: hsl(0, 100%, 40%);">-Scope(\_GPE) {</span><br><span style="color: hsl(0, 100%, 40%);">- Method(_L1F,0x0,NotSerialized) {</span><br><span style="color: hsl(0, 100%, 40%);">- if (\_SB.P0PR) {</span><br><span style="color: hsl(0, 100%, 40%);">- if (LGreater(\_SB.P0IS,0)) {</span><br><span style="color: hsl(0, 100%, 40%);">- sleep(32)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- Notify(\_SB.PCI0.STCR.PMRY.PMST, 0x01) /* NOTIFY_DEVICE_CHECK */</span><br><span style="color: hsl(0, 100%, 40%);">- store(one, \_SB.P0PR)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (\_SB.P1PR) {</span><br><span style="color: hsl(0, 100%, 40%);">- if (LGreater(\_SB.P1IS,0)) {</span><br><span style="color: hsl(0, 100%, 40%);">- sleep(32)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- Notify(\_SB.PCI0.STCR.PMRY.PSLA, 0x01) /* NOTIFY_DEVICE_CHECK */</span><br><span style="color: hsl(0, 100%, 40%);">- store(one, \_SB.P1PR)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (\_SB.P2PR) {</span><br><span style="color: hsl(0, 100%, 40%);">- if (LGreater(\_SB.P2IS,0)) {</span><br><span style="color: hsl(0, 100%, 40%);">- sleep(32)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- Notify(\_SB.PCI0.STCR.SEDY.SMST, 0x01) /* NOTIFY_DEVICE_CHECK */</span><br><span style="color: hsl(0, 100%, 40%);">- store(one, \_SB.P2PR)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (\_SB.P3PR) {</span><br><span style="color: hsl(0, 100%, 40%);">- if (LGreater(\_SB.P3IS,0)) {</span><br><span style="color: hsl(0, 100%, 40%);">- sleep(32)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- Notify(\_SB.PCI0.STCR.SEDY.SSLA, 0x01) /* NOTIFY_DEVICE_CHECK */</span><br><span style="color: hsl(0, 100%, 40%);">- store(one, \_SB.P3PR)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26150">change 26150</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26150"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I64229d12e9e7fd54eaae3425ae9546872c5bf8f3 </div>
<div style="display:none"> Gerrit-Change-Number: 26150 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>