<p>Duncan Laurie has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26176">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/eve: Describe USB devices in devicetree<br><br>Describe the USB devices in the devicetree so they can get<br>generated into the SSDT and presented to the OS.<br><br>This was tested on an eve board and the resulting SSDT was<br>verified to show the expected values in _UPC and _PLD.<br><br>Change-Id: I292426f588ea74d61a5c4e4b01386bb18834c117<br>Signed-off-by: Duncan Laurie <dlaurie@google.com><br>---<br>M src/mainboard/google/eve/Kconfig<br>M src/mainboard/google/eve/devicetree.cb<br>2 files changed, 44 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/26176/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/eve/Kconfig b/src/mainboard/google/eve/Kconfig</span><br><span>index ea65030..93d6f70 100644</span><br><span>--- a/src/mainboard/google/eve/Kconfig</span><br><span>+++ b/src/mainboard/google/eve/Kconfig</span><br><span>@@ -9,6 +9,7 @@</span><br><span> select DRIVERS_I2C_MAX98927</span><br><span> select DRIVERS_I2C_RT5663</span><br><span> select DRIVERS_SPI_ACPI</span><br><span style="color: hsl(120, 100%, 40%);">+ select DRIVERS_USB_ACPI</span><br><span> select EC_GOOGLE_CHROMEEC</span><br><span> select EC_GOOGLE_CHROMEEC_BOARDID</span><br><span> select EC_GOOGLE_CHROMEEC_LPC</span><br><span>diff --git a/src/mainboard/google/eve/devicetree.cb b/src/mainboard/google/eve/devicetree.cb</span><br><span>index f24d5c9..15be533 100644</span><br><span>--- a/src/mainboard/google/eve/devicetree.cb</span><br><span>+++ b/src/mainboard/google/eve/devicetree.cb</span><br><span>@@ -240,7 +240,49 @@</span><br><span> device domain 0 on</span><br><span> device pci 00.0 on end # Host Bridge</span><br><span> device pci 02.0 on end # Integrated Graphics Device</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 14.0 on end # USB xHCI</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 14.0 on</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Root Hub""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_HUB"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 0.0 on</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""USB2 Type-C Left""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.0 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""USB2 Camera""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_INTERNAL"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.1 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""USB2 Bluetooth""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_INTERNAL"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.2 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""USB2 Type-C Right""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.4 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""USB2 H1 TPM""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_INTERNAL"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.6 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""USB3 Type-C Left""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 3.0 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""USB3 Type-C Right""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 3.1 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ end # USB xHCI</span><br><span> device pci 14.1 off end # USB xDCI (OTG)</span><br><span> device pci 14.2 on end # Thermal Subsystem</span><br><span> device pci 15.0 on</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26176">change 26176</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26176"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I292426f588ea74d61a5c4e4b01386bb18834c117 </div>
<div style="display:none"> Gerrit-Change-Number: 26176 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> </div>