<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26134">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vendorcode/amd/pi/00670F00: Remove unneeded includes<br><br>Vendor code has several headers included into source code that are not<br>needed in order to build them. Remove unneeded #include. This is part of<br>controlling the build of unneeded procedures within vendor code.<br><br>BUG=b:78610011<br>TEST=Build grunt.<br><br>Change-Id: Id7d451b6be564632836fc64fd343131edb85183a<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/vendorcode/amd/pi/00670F00/Lib/amdlib.c<br>M src/vendorcode/amd/pi/00670F00/Proc/Fch/Common/FchPeLib.c<br>M src/vendorcode/amd/pi/00670F00/Proc/Fch/Common/MemLib.c<br>M src/vendorcode/amd/pi/00670F00/Proc/Psp/PspBaseLib/PspBaseLib.c<br>M src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c<br>5 files changed, 0 insertions(+), 13 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/26134/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vendorcode/amd/pi/00670F00/Lib/amdlib.c b/src/vendorcode/amd/pi/00670F00/Lib/amdlib.c</span><br><span>index 38df878..849d1a2 100644</span><br><span>--- a/src/vendorcode/amd/pi/00670F00/Lib/amdlib.c</span><br><span>+++ b/src/vendorcode/amd/pi/00670F00/Lib/amdlib.c</span><br><span>@@ -45,8 +45,6 @@</span><br><span> </span><br><span> #include <AGESA.h></span><br><span> #include <cpuRegisters.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <Ids.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <Porting.h></span><br><span> #include "amdlib.h"</span><br><span> CODE_GROUP (G1_PEICC)</span><br><span> RDATA_GROUP (G1_PEICC)</span><br><span>diff --git a/src/vendorcode/amd/pi/00670F00/Proc/Fch/Common/FchPeLib.c b/src/vendorcode/amd/pi/00670F00/Proc/Fch/Common/FchPeLib.c</span><br><span>index c833a9f..46125584 100644</span><br><span>--- a/src/vendorcode/amd/pi/00670F00/Proc/Fch/Common/FchPeLib.c</span><br><span>+++ b/src/vendorcode/amd/pi/00670F00/Proc/Fch/Common/FchPeLib.c</span><br><span>@@ -43,10 +43,6 @@</span><br><span> </span><br><span> #include "FchPlatform.h"</span><br><span> #include  "cpuFamilyTranslation.h"</span><br><span style="color: hsl(0, 100%, 40%);">-//#include  "Porting.h"</span><br><span style="color: hsl(0, 100%, 40%);">-//#include  "AMD.h"</span><br><span style="color: hsl(0, 100%, 40%);">-//#include  "amdlib.h"</span><br><span style="color: hsl(0, 100%, 40%);">-#include  "heapManager.h"</span><br><span> #define FILECODE PROC_FCH_COMMON_FCHPELIB_FILECODE</span><br><span> </span><br><span> /*----------------------------------------------------------------------------------------*/</span><br><span>diff --git a/src/vendorcode/amd/pi/00670F00/Proc/Fch/Common/MemLib.c b/src/vendorcode/amd/pi/00670F00/Proc/Fch/Common/MemLib.c</span><br><span>index 8313d81..2ab39a3 100644</span><br><span>--- a/src/vendorcode/amd/pi/00670F00/Proc/Fch/Common/MemLib.c</span><br><span>+++ b/src/vendorcode/amd/pi/00670F00/Proc/Fch/Common/MemLib.c</span><br><span>@@ -41,7 +41,6 @@</span><br><span>  *</span><br><span>  ***************************************************************************/</span><br><span> #include "FchPlatform.h"</span><br><span style="color: hsl(0, 100%, 40%);">-#include "Ids.h"</span><br><span> #define FILECODE PROC_FCH_COMMON_MEMLIB_FILECODE</span><br><span> </span><br><span> </span><br><span>diff --git a/src/vendorcode/amd/pi/00670F00/Proc/Psp/PspBaseLib/PspBaseLib.c b/src/vendorcode/amd/pi/00670F00/Proc/Psp/PspBaseLib/PspBaseLib.c</span><br><span>index e49fb78..199c3ff 100644</span><br><span>--- a/src/vendorcode/amd/pi/00670F00/Proc/Psp/PspBaseLib/PspBaseLib.c</span><br><span>+++ b/src/vendorcode/amd/pi/00670F00/Proc/Psp/PspBaseLib/PspBaseLib.c</span><br><span>@@ -48,7 +48,6 @@</span><br><span>  */</span><br><span> #include "AGESA.h"</span><br><span> #include "Filecode.h"</span><br><span style="color: hsl(0, 100%, 40%);">-#include "Fch.h"</span><br><span> #include "PspBaseLib.h"</span><br><span> </span><br><span> #define FILECODE PROC_PSP_PSPBASELIB_PSPBASELIB_FILECODE</span><br><span>diff --git a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c</span><br><span>index 0985504..4e6262d 100644</span><br><span>--- a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c</span><br><span>+++ b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c</span><br><span>@@ -39,12 +39,7 @@</span><br><span>  * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.</span><br><span>  *</span><br><span>  ***************************************************************************/</span><br><span style="color: hsl(0, 100%, 40%);">-// TODO This list needs to be pruned of anything that is not API</span><br><span style="color: hsl(0, 100%, 40%);">-#include "AGESA.h"</span><br><span> #include <amdblocks/agesawrapper.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include "cbfs.h"</span><br><span style="color: hsl(0, 100%, 40%);">-#include <console/console.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <commonlib/loglevel.h></span><br><span> </span><br><span> CONST UINT32 ImageSignature = IMAGE_SIGNATURE;</span><br><span> CONST UINT32 ModuleSignature = MODULE_SIGNATURE;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26134">change 26134</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26134"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id7d451b6be564632836fc64fd343131edb85183a </div>
<div style="display:none"> Gerrit-Change-Number: 26134 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>