<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25983">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ec/google/chromeec: Update Tablet event call<br><br>The tablet event handler method TPET is defined as an extern, then<br>defined again in skylake, the only platform that supports it.  In newer<br>versions of IASL, this generates an error, as the method is defined in<br>two places.<br><br>Remove the extern and the CondRefOf check.  That's not needed if we<br>only set the EC_ENABLE_TABLET_EVENT define on platforms that have a<br>TPET handler.<br><br>Change-Id: I8bee069fc95637446593dfaaae1254e931421517<br>Signed-off-by: Martin Roth <martinroth@google.com><br>---<br>M src/ec/google/chromeec/acpi/ec.asl<br>1 file changed, 2 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/25983/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl</span><br><span>index 9ec5f7f..ac4ceb1 100644</span><br><span>--- a/src/ec/google/chromeec/acpi/ec.asl</span><br><span>+++ b/src/ec/google/chromeec/acpi/ec.asl</span><br><span>@@ -24,7 +24,7 @@</span><br><span> #ifdef DPTF_ENABLE_CHARGER</span><br><span> External (\_SB.DPTF.TCHG, DeviceObj)</span><br><span> #endif</span><br><span style="color: hsl(0, 100%, 40%);">-External (\_SB.DPTF.TPET, MethodObj)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> </span><br><span> Device (EC0)</span><br><span> {</span><br><span>@@ -373,9 +373,7 @@</span><br><span>              Store ("EC: TABLET mode switch Event", Debug)</span><br><span>              Notify (CREC, 0x2)</span><br><span> #ifdef EC_ENABLE_TABLET_EVENT</span><br><span style="color: hsl(0, 100%, 40%);">-             If (CondRefOf (\_SB.DPTF.TPET)) {</span><br><span style="color: hsl(0, 100%, 40%);">-                       \_SB.DPTF.TPET()</span><br><span style="color: hsl(0, 100%, 40%);">-                }</span><br><span style="color: hsl(120, 100%, 40%);">+             \_SB.DPTF.TPET()</span><br><span> #endif</span><br><span> #ifdef EC_ENABLE_TBMC_DEVICE</span><br><span>           Notify (TBMC, 0x80)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25983">change 25983</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25983"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I8bee069fc95637446593dfaaae1254e931421517 </div>
<div style="display:none"> Gerrit-Change-Number: 25983 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>