<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25990">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/hp/dl145_g1: Remove commented code<br><br>Change-Id: I4528eb064e8b9c5ebb235ca16e13582df9efd4cd<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/mainboard/hp/dl145_g1/acpi_tables.c<br>M src/mainboard/hp/dl145_g1/romstage.c<br>2 files changed, 0 insertions(+), 50 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/25990/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/hp/dl145_g1/acpi_tables.c b/src/mainboard/hp/dl145_g1/acpi_tables.c</span><br><span>index 1b4ada1..ca6cea0 100644</span><br><span>--- a/src/mainboard/hp/dl145_g1/acpi_tables.c</span><br><span>+++ b/src/mainboard/hp/dl145_g1/acpi_tables.c</span><br><span>@@ -62,51 +62,6 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /*</span><br><span style="color: hsl(0, 100%, 40%);">- int i;</span><br><span style="color: hsl(0, 100%, 40%);">- int j = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- for(i = 1; i< sysconf.hc_possible_num; i++) {</span><br><span style="color: hsl(0, 100%, 40%);">- unsigned d = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- if(!(sysconf.pci1234[i] & 0x1) ) continue;</span><br><span style="color: hsl(0, 100%, 40%);">- // 8131 need to use +4</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- switch (sysconf.hcid[i]) {</span><br><span style="color: hsl(0, 100%, 40%);">- case 1:</span><br><span style="color: hsl(0, 100%, 40%);">- d = 7;</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case 3:</span><br><span style="color: hsl(0, 100%, 40%);">- d = 4;</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- switch (sysconf.hcid[i]) {</span><br><span style="color: hsl(0, 100%, 40%);">- case 1:</span><br><span style="color: hsl(0, 100%, 40%);">- case 3:</span><br><span style="color: hsl(0, 100%, 40%);">- dev = dev_find_slot(m->bus_8132a[j][0], PCI_DEVFN(m->sbdn3a[j], 1));</span><br><span style="color: hsl(0, 100%, 40%);">- if (dev) {</span><br><span style="color: hsl(0, 100%, 40%);">- res = find_resource(dev, PCI_BASE_ADDRESS_0);</span><br><span style="color: hsl(0, 100%, 40%);">- if (res) {</span><br><span style="color: hsl(0, 100%, 40%);">- current += acpi_create_madt_ioapic((acpi_madt_ioapic_t *)current, m->apicid_8132a[j][0],</span><br><span style="color: hsl(0, 100%, 40%);">- res->base, gsi_base );</span><br><span style="color: hsl(0, 100%, 40%);">- gsi_base+=d;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- dev = dev_find_slot(m->bus_8132a[j][0], PCI_DEVFN(m->sbdn3a[j]+1, 1));</span><br><span style="color: hsl(0, 100%, 40%);">- if (dev) {</span><br><span style="color: hsl(0, 100%, 40%);">- res = find_resource(dev, PCI_BASE_ADDRESS_0);</span><br><span style="color: hsl(0, 100%, 40%);">- if (res) {</span><br><span style="color: hsl(0, 100%, 40%);">- current += acpi_create_madt_ioapic((acpi_madt_ioapic_t *)current, m->apicid_8132a[j][1],</span><br><span style="color: hsl(0, 100%, 40%);">- res->base, gsi_base );</span><br><span style="color: hsl(0, 100%, 40%);">- gsi_base+=d;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- j++;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span> </span><br><span> }</span><br><span> </span><br><span>diff --git a/src/mainboard/hp/dl145_g1/romstage.c b/src/mainboard/hp/dl145_g1/romstage.c</span><br><span>index 91f03a7..7406f77 100644</span><br><span>--- a/src/mainboard/hp/dl145_g1/romstage.c</span><br><span>+++ b/src/mainboard/hp/dl145_g1/romstage.c</span><br><span>@@ -125,7 +125,6 @@</span><br><span> printk(BIOS_DEBUG, "*sysinfo range: [%p,%p]\n",sysinfo,sysinfo+1);</span><br><span> </span><br><span> setup_dl145g1_resource_map();</span><br><span style="color: hsl(0, 100%, 40%);">- //setup_default_resource_map();</span><br><span> </span><br><span> setup_coherent_ht_domain();</span><br><span> wait_all_core0_started();</span><br><span>@@ -182,10 +181,6 @@</span><br><span> change_i2c_mux(i);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- //dump_spd_registers(&sysinfo->ctrl[0]);</span><br><span style="color: hsl(0, 100%, 40%);">- //dump_spd_registers(&sysinfo->ctrl[1]);</span><br><span style="color: hsl(0, 100%, 40%);">- //dump_smbus_registers();</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> allow_all_aps_stop(bsp_apicid);</span><br><span> </span><br><span> //It's the time to set ctrl now;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25990">change 25990</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25990"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4528eb064e8b9c5ebb235ca16e13582df9efd4cd </div>
<div style="display:none"> Gerrit-Change-Number: 25990 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>