<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25999">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[WIP]acpigen: Always return buffer with requested size<br><br>Pad a buffer with zero bytes to return the exact requested size.<br>Might be requied for nouveau.<br><br>Needs test on real hardware.<br><br>Change-Id: I3f0ecc42a21945f66eb67f73e511bd516acf0fa9<br>Signed-off-by: Patrick Rudolph <siro@das-labor.org><br>---<br>M src/arch/x86/acpigen.c<br>1 file changed, 10 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/25999/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/arch/x86/acpigen.c b/src/arch/x86/acpigen.c</span><br><span>index fc6cc66..d73f03a 100644</span><br><span>--- a/src/arch/x86/acpigen.c</span><br><span>+++ b/src/arch/x86/acpigen.c</span><br><span>@@ -1340,6 +1340,8 @@</span><br><span>  *                Store (0x1000, Local1)</span><br><span>  *    }</span><br><span>  *</span><br><span style="color: hsl(120, 100%, 40%);">+ *     Store (Local1, Local3)</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span>  *        If (LGreater (Local0, 0x10000))</span><br><span>  *   {</span><br><span>  *         Return(Buffer(Local1){0})</span><br><span>@@ -1354,7 +1356,7 @@</span><br><span>  *         }</span><br><span>  * }</span><br><span>  *</span><br><span style="color: hsl(0, 100%, 40%);">- *       Name (ROM1, Buffer (Local1) {0})</span><br><span style="color: hsl(120, 100%, 40%);">+ *    Name (ROM1, Buffer (Local3) {0})</span><br><span>  *</span><br><span>  *    Multiply (Local0, 0x08, Local0)</span><br><span>  *   Multiply (Local1, 0x08, Local1)</span><br><span>@@ -1416,6 +1418,11 @@</span><br><span>     /* Pop if */</span><br><span>         acpigen_pop_len();</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+        /* Store (Local1, Local3) */</span><br><span style="color: hsl(120, 100%, 40%);">+  acpigen_write_store();</span><br><span style="color: hsl(120, 100%, 40%);">+        acpigen_emit_byte(LOCAL1_OP);</span><br><span style="color: hsl(120, 100%, 40%);">+ acpigen_emit_byte(LOCAL3_OP);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>      /* If (LGreater (Local0, length)) */</span><br><span>         acpigen_write_if();</span><br><span>  acpigen_emit_byte(LGREATER_OP);</span><br><span>@@ -1462,11 +1469,11 @@</span><br><span>    /* Pop if */</span><br><span>         acpigen_pop_len();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  /* Name (ROM1, Buffer (Local1) {0}) */</span><br><span style="color: hsl(120, 100%, 40%);">+        /* Name (ROM1, Buffer (Local3) {0}) */</span><br><span>       acpigen_write_name("ROM1");</span><br><span>        acpigen_emit_byte(BUFFER_OP);</span><br><span>        acpigen_write_len_f();</span><br><span style="color: hsl(0, 100%, 40%);">-  acpigen_emit_byte(LOCAL1_OP);</span><br><span style="color: hsl(120, 100%, 40%);">+ acpigen_emit_byte(LOCAL3_OP);</span><br><span>        acpigen_emit_byte(0);</span><br><span>        acpigen_pop_len();</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25999">change 25999</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25999"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3f0ecc42a21945f66eb67f73e511bd516acf0fa9 </div>
<div style="display:none"> Gerrit-Change-Number: 25999 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>