<p style="white-space: pre-wrap; word-wrap: break-word;">Looks good. A few very minor nits though.</p><p><a href="https://review.coreboot.org/25912">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25912/1/src/mainboard/gigabyte/ga-h61m-s2pv/devicetree.cb">File src/mainboard/gigabyte/ga-h61m-s2pv/devicetree.cb:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25912/1/src/mainboard/gigabyte/ga-h61m-s2pv/devicetree.cb@114">Patch Set #1, Line 114:</a> <code style="font-family:monospace,monospace">io 0x62 = 0xa20</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">usually put about irq 0x70 = ...</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25912/1/src/mainboard/gigabyte/ga-h61m-s2pv/devicetree.cb@119">Patch Set #1, Line 119:</a> <code style="font-family:monospace,monospace">io 0x62 = 0x64</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">same</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25912/1/src/mainboard/gigabyte/ga-h61m-s2pv/romstage.c">File src/mainboard/gigabyte/ga-h61m-s2pv/romstage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25912/1/src/mainboard/gigabyte/ga-h61m-s2pv/romstage.c@16">Patch Set #1, Line 16:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">#define SUPERIO_BASE 0x2e<br>#define SUPERIO_DEV PNP_DEV(SUPERIO_BASE, 0)<br>#define SUPERIO_GPIO PNP_DEV(SUPERIO_BASE, IT8728F_GPIO)<br>#define SERIAL_DEV PNP_DEV(SUPERIO_BASE, 0x01)<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">usually put below the #include macros.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25912/1/src/mainboard/gigabyte/ga-h61m-s2pv/romstage.c@62">Patch Set #1, Line 62:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">       ite_reg_write(IT8728F_EC, 0xf1, 0xc0);<br>        ite_reg_write(IT8728F_EC, 0xf6, 0xf0);<br>        ite_reg_write(IT8728F_EC, 0xf9, 0x48);<br>        ite_reg_write(IT8728F_EC, 0x60, 0x0a);<br>        ite_reg_write(IT8728F_EC, 0x61, 0x30);<br>        ite_reg_write(IT8728F_EC, 0x62, 0x0a);<br>        ite_reg_write(IT8728F_EC, 0x63, 0x20);<br>        ite_reg_write(IT8728F_EC, 0x30, 0x01);<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">you could probably set most of these in the devicetree/ramstage or is the fan not working in romstage if you don't do this?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25912/1/src/mainboard/gigabyte/ga-h61m-s2pv/romstage.c@84">Patch Set #1, Line 84:</a> <code style="font-family:monospace,monospace">    pci_write_config32(PCH_LPC_DEV, LPC_GEN1_DEC, 0x3c0a01);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">might not be needed to be set in romstage.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/25912">change 25912</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25912"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I598a0b75093a0f1aef2ac615035d66786a8c22cb </div>
<div style="display:none"> Gerrit-Change-Number: 25912 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Angel Pons </div>
<div style="display:none"> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 29 Apr 2018 18:32:35 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>