<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25900">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/octopus: Enable pull on ESPI_IO1 line<br><br>This change configures a weak internal pull-up on ESPI_IO1 line for<br>octopus baseboard and variant bip. ESPI_IO1 is used as ALERT# line and<br>is expected to be open-drain. However, there is no external pull on<br>this line and so an internal pull-up is required to ensure proper eSPI<br>communication.<br><br>BUG=b:78497502<br>TEST=Verified that there is no eSPI communication failure between AP<br>and EC during boot-up and on suspend/resume.<br><br>Change-Id: Ic494aa7397b94bfd233ce10da8287660997b3377<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/mainboard/google/octopus/variants/baseboard/gpio.c<br>M src/mainboard/google/octopus/variants/bip/gpio.c<br>2 files changed, 16 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/25900/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/octopus/variants/baseboard/gpio.c b/src/mainboard/google/octopus/variants/baseboard/gpio.c</span><br><span>index 8863bbb..732653a 100644</span><br><span>--- a/src/mainboard/google/octopus/variants/baseboard/gpio.c</span><br><span>+++ b/src/mainboard/google/octopus/variants/baseboard/gpio.c</span><br><span>@@ -279,6 +279,14 @@</span><br><span> /* Enable power to wifi early in bootblock and de-assert PERST#. */</span><br><span> PAD_CFG_GPO(GPIO_178, 1, DEEP), /* EN_PP3300_WLAN */</span><br><span> PAD_CFG_GPO(GPIO_164, 0, DEEP), /* WLAN_PE_RST */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * ESPI_IO1 acts as ALERT# (which is open-drain) and requies a weak</span><br><span style="color: hsl(120, 100%, 40%);">+ * pull-up for proper operation. Since there is no external pull present</span><br><span style="color: hsl(120, 100%, 40%);">+ * on this platform, configure an internal weak pull-up.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_151, UP_20K, DEEP, NF2, HIZCRx1,</span><br><span style="color: hsl(120, 100%, 40%);">+ ENPU), /* ESPI_IO1 */</span><br><span> };</span><br><span> </span><br><span> const struct pad_config *__weak</span><br><span>diff --git a/src/mainboard/google/octopus/variants/bip/gpio.c b/src/mainboard/google/octopus/variants/bip/gpio.c</span><br><span>index fe7a2e2..84285d7 100644</span><br><span>--- a/src/mainboard/google/octopus/variants/bip/gpio.c</span><br><span>+++ b/src/mainboard/google/octopus/variants/bip/gpio.c</span><br><span>@@ -278,6 +278,14 @@</span><br><span> /* Enable power to wifi early in bootblock and de-assert PERST#. */</span><br><span> PAD_CFG_GPO(GPIO_178, 1, DEEP), /* EN_PP3300_WLAN */</span><br><span> PAD_CFG_GPO(GPIO_164, 0, DEEP), /* WLAN_PE_RST */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * ESPI_IO1 acts as ALERT# (which is open-drain) and requies a weak</span><br><span style="color: hsl(120, 100%, 40%);">+ * pull-up for proper operation. Since there is no external pull present</span><br><span style="color: hsl(120, 100%, 40%);">+ * on this platform, configure an internal weak pull-up.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_151, UP_20K, DEEP, NF2, HIZCRx1,</span><br><span style="color: hsl(120, 100%, 40%);">+ ENPU), /* ESPI_IO1 */</span><br><span> };</span><br><span> </span><br><span> const struct pad_config *variant_early_gpio_table(size_t *num)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25900">change 25900</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25900"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic494aa7397b94bfd233ce10da8287660997b3377 </div>
<div style="display:none"> Gerrit-Change-Number: 25900 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>