<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25871">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/amd/stoneyridge/gpio.c: Fix gpio_output()<br><br>Function gpio_output() is only setting the pin as an output, when in fact<br>it should also set the state (high/low) of the pin. Fix the procedure to<br>set the state of the pin.<br><br>BUG=b:78328773<br>TEST=None<br><br>Change-Id: I516192a0782a9bbb40124029f264a2711114c800<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/soc/amd/stoneyridge/gpio.c<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/25871/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/stoneyridge/gpio.c b/src/soc/amd/stoneyridge/gpio.c</span><br><span>index 088f199..4520df7 100644</span><br><span>--- a/src/soc/amd/stoneyridge/gpio.c</span><br><span>+++ b/src/soc/amd/stoneyridge/gpio.c</span><br><span>@@ -95,6 +95,7 @@</span><br><span>       reg = read32((void *)gpio_address);</span><br><span>  reg |=  GPIO_OUTPUT_ENABLE;</span><br><span>  write32((void *)(uintptr_t)gpio_num, reg);</span><br><span style="color: hsl(120, 100%, 40%);">+    gpio_set(gpio_num, value);</span><br><span> }</span><br><span> </span><br><span> const char *gpio_acpi_path(gpio_t gpio)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25871">change 25871</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25871"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I516192a0782a9bbb40124029f264a2711114c800 </div>
<div style="display:none"> Gerrit-Change-Number: 25871 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>