<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25853">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/southbridge: Add whitespace around '=='<br><br>Change-Id: Ic81601cef841076a7548ccb3bdf0ed1b5420873e<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/southbridge/intel/common/smihandler.c<br>M src/southbridge/intel/common/usb_debug.c<br>M src/southbridge/intel/fsp_bd82x6x/smihandler.c<br>M src/southbridge/intel/fsp_i89xx/smihandler.c<br>M src/southbridge/intel/ibexpeak/smihandler.c<br>M src/southbridge/intel/lynxpoint/early_usb.c<br>M src/southbridge/intel/lynxpoint/smihandler.c<br>M src/southbridge/nvidia/mcp55/nic.c<br>M src/southbridge/sis/sis966/nic.c<br>M src/southbridge/sis/sis966/sis966.c<br>10 files changed, 15 insertions(+), 15 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/25853/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/southbridge/intel/common/smihandler.c b/src/southbridge/intel/common/smihandler.c</span><br><span>index 17fae11..65a1b96 100644</span><br><span>--- a/src/southbridge/intel/common/smihandler.c</span><br><span>+++ b/src/southbridge/intel/common/smihandler.c</span><br><span>@@ -234,11 +234,11 @@</span><br><span> for (node = 0; node < CONFIG_MAX_CPUS; node++) {</span><br><span> state = smm_get_save_state(node);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Check for Synchronous IO (bit0==1) */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Check for Synchronous IO (bit0 == 1) */</span><br><span> if (!(state->io_misc_info & (1 << 0)))</span><br><span> continue;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Make sure it was a write (bit4==0) */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Make sure it was a write (bit4 == 0) */</span><br><span> if (state->io_misc_info & (1 << 4))</span><br><span> continue;</span><br><span> </span><br><span>diff --git a/src/southbridge/intel/common/usb_debug.c b/src/southbridge/intel/common/usb_debug.c</span><br><span>index f74da65..d87e018 100644</span><br><span>--- a/src/southbridge/intel/common/usb_debug.c</span><br><span>+++ b/src/southbridge/intel/common/usb_debug.c</span><br><span>@@ -30,7 +30,7 @@</span><br><span> if (!IS_ENABLED(CONFIG_HAVE_USBDEBUG_OPTIONS))</span><br><span> return PCI_DEV(0, 0x1d, 7);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (hcd_idx==2)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (hcd_idx == 2)</span><br><span> dev = PCI_DEV(0, 0x1a, 0);</span><br><span> else</span><br><span> dev = PCI_DEV(0, 0x1d, 0);</span><br><span>diff --git a/src/southbridge/intel/fsp_bd82x6x/smihandler.c b/src/southbridge/intel/fsp_bd82x6x/smihandler.c</span><br><span>index 394e0a9..83eab79 100644</span><br><span>--- a/src/southbridge/intel/fsp_bd82x6x/smihandler.c</span><br><span>+++ b/src/southbridge/intel/fsp_bd82x6x/smihandler.c</span><br><span>@@ -411,11 +411,11 @@</span><br><span> for (node = 0; node < CONFIG_MAX_CPUS; node++) {</span><br><span> state = smm_get_save_state(node);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Check for Synchronous IO (bit0==1) */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Check for Synchronous IO (bit0 == 1) */</span><br><span> if (!(state->io_misc_info & (1 << 0)))</span><br><span> continue;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Make sure it was a write (bit4==0) */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Make sure it was a write (bit4 == 0) */</span><br><span> if (state->io_misc_info & (1 << 4))</span><br><span> continue;</span><br><span> </span><br><span>diff --git a/src/southbridge/intel/fsp_i89xx/smihandler.c b/src/southbridge/intel/fsp_i89xx/smihandler.c</span><br><span>index ff76c20..8a6506b 100644</span><br><span>--- a/src/southbridge/intel/fsp_i89xx/smihandler.c</span><br><span>+++ b/src/southbridge/intel/fsp_i89xx/smihandler.c</span><br><span>@@ -411,11 +411,11 @@</span><br><span> for (node = 0; node < CONFIG_MAX_CPUS; node++) {</span><br><span> state = smm_get_save_state(node);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Check for Synchronous IO (bit0==1) */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Check for Synchronous IO (bit0 == 1) */</span><br><span> if (!(state->io_misc_info & (1 << 0)))</span><br><span> continue;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Make sure it was a write (bit4==0) */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Make sure it was a write (bit4 == 0) */</span><br><span> if (state->io_misc_info & (1 << 4))</span><br><span> continue;</span><br><span> </span><br><span>diff --git a/src/southbridge/intel/ibexpeak/smihandler.c b/src/southbridge/intel/ibexpeak/smihandler.c</span><br><span>index 29c46e8..12a7ac0 100644</span><br><span>--- a/src/southbridge/intel/ibexpeak/smihandler.c</span><br><span>+++ b/src/southbridge/intel/ibexpeak/smihandler.c</span><br><span>@@ -514,11 +514,11 @@</span><br><span> for (node = 0; node < CONFIG_MAX_CPUS; node++) {</span><br><span> state = smm_get_save_state(node);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Check for Synchronous IO (bit0==1) */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Check for Synchronous IO (bit0 == 1) */</span><br><span> if (!(state->io_misc_info & (1 << 0)))</span><br><span> continue;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Make sure it was a write (bit4==0) */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Make sure it was a write (bit4 == 0) */</span><br><span> if (state->io_misc_info & (1 << 4))</span><br><span> continue;</span><br><span> </span><br><span>diff --git a/src/southbridge/intel/lynxpoint/early_usb.c b/src/southbridge/intel/lynxpoint/early_usb.c</span><br><span>index 8262de8..a64530e 100644</span><br><span>--- a/src/southbridge/intel/lynxpoint/early_usb.c</span><br><span>+++ b/src/southbridge/intel/lynxpoint/early_usb.c</span><br><span>@@ -20,7 +20,7 @@</span><br><span> #include <device/pci_def.h></span><br><span> #include "pch.h"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* HCD_INDEX==2 selects 0:1a.0 (PCH_EHCI2), any other index</span><br><span style="color: hsl(120, 100%, 40%);">+/* HCD_INDEX == 2 selects 0:1a.0 (PCH_EHCI2), any other index</span><br><span> * selects 0:1d.0 (PCH_EHCI1) for usbdebug use.</span><br><span> */</span><br><span> #if CONFIG_USBDEBUG_HCD_INDEX != 2</span><br><span>diff --git a/src/southbridge/intel/lynxpoint/smihandler.c b/src/southbridge/intel/lynxpoint/smihandler.c</span><br><span>index 37a7a2b..dcec3f0 100644</span><br><span>--- a/src/southbridge/intel/lynxpoint/smihandler.c</span><br><span>+++ b/src/southbridge/intel/lynxpoint/smihandler.c</span><br><span>@@ -221,11 +221,11 @@</span><br><span> for (node = 0; node < CONFIG_MAX_CPUS; node++) {</span><br><span> state = smm_get_save_state(node);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Check for Synchronous IO (bit0==1) */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Check for Synchronous IO (bit0 == 1) */</span><br><span> if (!(state->io_misc_info & (1 << 0)))</span><br><span> continue;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Make sure it was a write (bit4==0) */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Make sure it was a write (bit4 == 0) */</span><br><span> if (state->io_misc_info & (1 << 4))</span><br><span> continue;</span><br><span> </span><br><span>diff --git a/src/southbridge/nvidia/mcp55/nic.c b/src/southbridge/nvidia/mcp55/nic.c</span><br><span>index be9daf7..788b6ef 100644</span><br><span>--- a/src/southbridge/nvidia/mcp55/nic.c</span><br><span>+++ b/src/southbridge/nvidia/mcp55/nic.c</span><br><span>@@ -42,7 +42,7 @@</span><br><span> write32(base + 0x190, (phy_addr << 5) | (phy_reg));</span><br><span> do {</span><br><span> dword = read32(base + 0x190);</span><br><span style="color: hsl(0, 100%, 40%);">- if (--loop==0)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (--loop == 0)</span><br><span> return -4;</span><br><span> } while ((dword & (1 << 15)));</span><br><span> </span><br><span>diff --git a/src/southbridge/sis/sis966/nic.c b/src/southbridge/sis/sis966/nic.c</span><br><span>index 448514b..642d691 100644</span><br><span>--- a/src/southbridge/sis/sis966/nic.c</span><br><span>+++ b/src/southbridge/sis/sis966/nic.c</span><br><span>@@ -150,7 +150,7 @@</span><br><span> </span><br><span> mdelay(50);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (i==LoopNum) data=0x10000;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (i == LoopNum) data=0x10000;</span><br><span> else {</span><br><span> ulValue=read32(base + 0x3c);</span><br><span> data = ((ulValue & 0xffff0000) >> 16);</span><br><span>diff --git a/src/southbridge/sis/sis966/sis966.c b/src/southbridge/sis/sis966/sis966.c</span><br><span>index 57d6498..d84b373 100644</span><br><span>--- a/src/southbridge/sis/sis966/sis966.c</span><br><span>+++ b/src/southbridge/sis/sis966/sis966.c</span><br><span>@@ -70,7 +70,7 @@</span><br><span> conf = dev->chip_info;</span><br><span> int i;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (dev->device==0x0000) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (dev->device == 0x0000) {</span><br><span> reg = pci_read_config32(dev, PCI_VENDOR_ID);</span><br><span> deviceid = (reg >> 16) & 0xffff;</span><br><span> vendorid = reg & 0xffff;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25853">change 25853</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25853"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic81601cef841076a7548ccb3bdf0ed1b5420873e </div>
<div style="display:none"> Gerrit-Change-Number: 25853 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>