<p>Oleksii Kurochko has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25753">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/emulation/qemu-i440fx/fw_cfg: fix checksum for ACPI tables<br><br>Current pacth fixes problem with validation of ACPI in Linux kernel:<br>ACPI BIOS Error (bug): A valid RSDP was not found (20180313/tbxfroot-210)<br>1. function acpi_checksum() return u8, so seems that is not good idea to<br>use write_le32().<br>2. at least RSDP (https://wiki.osdev.org/RSDP#Validating_the_RSDP) has<br>u8 Checksum.<br><br>Change-Id: I1fb29ef4e58982aab0c54b1f715c5658d2a663d8<br>Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com><br>---<br>M src/mainboard/emulation/qemu-i440fx/fw_cfg.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/25753/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c</span><br><span>index 4db148c..7e33374 100644</span><br><span>--- a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c</span><br><span>+++ b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c</span><br><span>@@ -294,7 +294,7 @@</span><br><span>                       ptr = (uint8_t *)(addrs[dst] + s[i].cksum.offset);</span><br><span>                   cksum_data = (void *)(addrs[dst] + s[i].cksum.start);</span><br><span>                        cksum = acpi_checksum(cksum_data, s[i].cksum.length);</span><br><span style="color: hsl(0, 100%, 40%);">-                   write_le32(ptr, cksum);</span><br><span style="color: hsl(120, 100%, 40%);">+                       write_le8(ptr, cksum);</span><br><span>                       break;</span><br><span> </span><br><span>           default:</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25753">change 25753</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25753"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I1fb29ef4e58982aab0c54b1f715c5658d2a663d8 </div>
<div style="display:none"> Gerrit-Change-Number: 25753 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Oleksii Kurochko <oleksii.kurochko@gmail.com> </div>