<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25702">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb//google/cyan/spd/spd.c: Fix module part number transfer<br><br>With the increase of dimm->module_part_number size from 19 to 21 (commit<br>35b273eea3), this code is now advancing outside DDR3 SPD designated space.<br>The correct size is already defined as LPDDR3_SPD_PART_LEN, use it. Also make<br>sure to 0 terminate the string.<br><br>BUG=b:77943312<br>TEST=Build cyan.<br><br>Change-Id: Iba0ef4149acfc09b7672fce079df06bf1a01dff6<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/mainboard/google/cyan/spd/spd.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/25702/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/cyan/spd/spd.c b/src/mainboard/google/cyan/spd/spd.c</span><br><span>index a3db2ed..3b93db1 100644</span><br><span>--- a/src/mainboard/google/cyan/spd/spd.c</span><br><span>+++ b/src/mainboard/google/cyan/spd/spd.c</span><br><span>@@ -145,7 +145,8 @@</span><br><span>       dimm->dimm_size = capmb / 8 * busw / devw * ranks;  /* MiB */</span><br><span>     dimm->mod_type = spd[3] & 0xf;</span><br><span>        memcpy((char *)&dimm->module_part_number[0], &spd[0x80],</span><br><span style="color: hsl(0, 100%, 40%);">-             sizeof(dimm->module_part_number) - 1);</span><br><span style="color: hsl(120, 100%, 40%);">+             LPDDR3_SPD_PART_LEN);</span><br><span style="color: hsl(120, 100%, 40%);">+ dimm->module_part_number[LPDDR3_SPD_PART_LEN] = 0;</span><br><span>        dimm->mod_id = *(uint16_t *)&spd[0x94];</span><br><span> </span><br><span>   switch (busw) {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25702">change 25702</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25702"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iba0ef4149acfc09b7672fce079df06bf1a01dff6 </div>
<div style="display:none"> Gerrit-Change-Number: 25702 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>