<p>Frank Wu has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25614">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/skylake: check DPTF_TSR0_ACTIVE_AC* in _ACx methods<br><br>Because thermal table is not included the values of DPTF_TSR0_ACTIVE_AC5<br>and DPTF_TSR0_ACTIVE_AC6 from internal nami/vayne thermal team.<br>Add conditional compilation in _ACx methods if DPTF_ENABLE_FAN_CONTROL<br>is defined in the dptf.asl.<br><br>BUG=b:72974136<br>BRANCH=poppy<br>TEST=emerge-nami coreboot and booted on nami board.<br><br>Change-Id: I3e36ce94f714ff13f8ccee65992d7a9c7e0bb5b2<br>Signed-off-by: Frank Wu <frank_wu@compal.corp-partner.google.com><br>---<br>M src/soc/intel/skylake/acpi/dptf/thermal.asl<br>1 file changed, 14 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/25614/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/skylake/acpi/dptf/thermal.asl b/src/soc/intel/skylake/acpi/dptf/thermal.asl</span><br><span>index f1a3cef..d84807b 100644</span><br><span>--- a/src/soc/intel/skylake/acpi/dptf/thermal.asl</span><br><span>+++ b/src/soc/intel/skylake/acpi/dptf/thermal.asl</span><br><span>@@ -155,41 +155,49 @@</span><br><span>        }</span><br><span> </span><br><span> #ifdef DPTF_ENABLE_FAN_CONTROL</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef DPTF_TSR0_ACTIVE_AC0</span><br><span>         Method (_AC0)</span><br><span>        {</span><br><span>            Return (\_SB.DPTF.CTOK (DPTF_TSR0_ACTIVE_AC0))</span><br><span>       }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef DPTF_TSR0_ACTIVE_AC1</span><br><span>       Method (_AC1)</span><br><span>        {</span><br><span>            Return (\_SB.DPTF.CTOK (DPTF_TSR0_ACTIVE_AC1))</span><br><span>       }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef DPTF_TSR0_ACTIVE_AC2</span><br><span>       Method (_AC2)</span><br><span>        {</span><br><span>            Return (\_SB.DPTF.CTOK (DPTF_TSR0_ACTIVE_AC2))</span><br><span>       }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef DPTF_TSR0_ACTIVE_AC3</span><br><span>       Method (_AC3)</span><br><span>        {</span><br><span>            Return (\_SB.DPTF.CTOK (DPTF_TSR0_ACTIVE_AC3))</span><br><span>       }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef DPTF_TSR0_ACTIVE_AC4</span><br><span>       Method (_AC4)</span><br><span>        {</span><br><span>            Return (\_SB.DPTF.CTOK (DPTF_TSR0_ACTIVE_AC4))</span><br><span>       }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef DPTF_TSR0_ACTIVE_AC5</span><br><span>       Method (_AC5)</span><br><span>        {</span><br><span>            Return (\_SB.DPTF.CTOK (DPTF_TSR0_ACTIVE_AC5))</span><br><span>       }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef DPTF_TSR0_ACTIVE_AC6</span><br><span>       Method (_AC6)</span><br><span>        {</span><br><span>            Return (\_SB.DPTF.CTOK (DPTF_TSR0_ACTIVE_AC6))</span><br><span>       }</span><br><span> #endif</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> }</span><br><span> #endif</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25614">change 25614</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25614"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3e36ce94f714ff13f8ccee65992d7a9c7e0bb5b2 </div>
<div style="display:none"> Gerrit-Change-Number: 25614 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Frank Wu <frank_wu@compal.corp-partner.google.com> </div>