<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25583">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lib/bootmem: Add method to walk memory tables<br><br>Add a method to walk specified memory tables and call a function<br>for each memory range.<br><br>Merge LB_MEM_RAM_DONT_OVERLAP into LB_MEM_RAM on request, to<br>ease working with memory regions intended for payloads.<br><br>Required for uImage support in coreboot.<br><br>Tested on Cavium SoC.<br><br>Change-Id: I0004e5ad5fe2289827f370f0d0f9979d3cbd3926<br>Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com><br>---<br>M src/include/bootmem.h<br>M src/lib/bootmem.c<br>2 files changed, 48 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/25583/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/include/bootmem.h b/src/include/bootmem.h</span><br><span>index b825272..b16bcc0 100644</span><br><span>--- a/src/include/bootmem.h</span><br><span>+++ b/src/include/bootmem.h</span><br><span>@@ -41,6 +41,23 @@</span><br><span> /* Print current range map of boot memory. */</span><br><span> void bootmem_dump_ranges(void);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+typedef bool (*range_action_t)(const struct range_entry *r, void *arg);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/**</span><br><span style="color: hsl(120, 100%, 40%);">+ * Walk memory tables and call the provided function, for every region,</span><br><span style="color: hsl(120, 100%, 40%);">+ * that is bigger than min_size. The caller has to return false to break</span><br><span style="color: hsl(120, 100%, 40%);">+ * out of the loop any time, or return true to continue.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * @param merge_ram_dont_overlap If true, LB_MEM_RAM_DONT_OVERLAP regions</span><br><span style="color: hsl(120, 100%, 40%);">+ * appear as usable RAM and will never appear in one callback.</span><br><span style="color: hsl(120, 100%, 40%);">+ * The regions are merged with usable RAM regions.</span><br><span style="color: hsl(120, 100%, 40%);">+ * If false, all regions are provided as is.</span><br><span style="color: hsl(120, 100%, 40%);">+ * @param action The function to call for each memory range.</span><br><span style="color: hsl(120, 100%, 40%);">+ * @param Pointer passed to function @action. Set to NULL if unused.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+void bootmem_walk(const bool merge_ram_dont_overlap, range_action_t action,</span><br><span style="color: hsl(120, 100%, 40%);">+ void *arg);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Return 1 if region targets usable RAM, 0 otherwise. */</span><br><span> int bootmem_region_targets_usable_ram(uint64_t start, uint64_t size);</span><br><span> </span><br><span>diff --git a/src/lib/bootmem.c b/src/lib/bootmem.c</span><br><span>index f00ce13..f34e773 100644</span><br><span>--- a/src/lib/bootmem.c</span><br><span>+++ b/src/lib/bootmem.c</span><br><span>@@ -133,6 +133,37 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+void bootmem_walk(const bool merge_ram_dont_overlap, range_action_t action,</span><br><span style="color: hsl(120, 100%, 40%);">+ void *arg)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct range_entry *r;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct memranges *memranges;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct memranges bm;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ assert (action);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (merge_ram_dont_overlap) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /**</span><br><span style="color: hsl(120, 100%, 40%);">+ * Convert LB_MEM_RAM_DONT_OVERLAP to LB_MEM_RAM and merge</span><br><span style="color: hsl(120, 100%, 40%);">+ * ranges:</span><br><span style="color: hsl(120, 100%, 40%);">+ * The caller doesn't care about memory used by firmware.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ memranges_clone(&bm, &bootmem);</span><br><span style="color: hsl(120, 100%, 40%);">+ memranges_update_tag(&bm, LB_MEM_RAM_DONT_OVERLAP, LB_MEM_RAM);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ memranges = merge_ram_dont_overlap ? &bm : &bootmem ;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ memranges_each_entry(r, memranges) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!action(r, arg))</span><br><span style="color: hsl(120, 100%, 40%);">+ goto out;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+out:</span><br><span style="color: hsl(120, 100%, 40%);">+ if (merge_ram_dont_overlap)</span><br><span style="color: hsl(120, 100%, 40%);">+ memranges_teardown(&bm);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> int bootmem_region_targets_usable_ram(uint64_t start, uint64_t size)</span><br><span> {</span><br><span> const struct range_entry *r;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25583">change 25583</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25583"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I0004e5ad5fe2289827f370f0d0f9979d3cbd3926 </div>
<div style="display:none"> Gerrit-Change-Number: 25583 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> </div>