<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25593">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/pineview: Enable and allocate 8M for TSEG<br><br>TSEG can be used as a stage cache and SMM can be relocated here.<br><br>Change-Id: Ifa3acce57f0c13eee326b7c203a43453c74c3161<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/northbridge/intel/pineview/pineview.h<br>M src/northbridge/intel/pineview/raminit.c<br>2 files changed, 7 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/25593/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/intel/pineview/pineview.h b/src/northbridge/intel/pineview/pineview.h</span><br><span>index a2cda84..9873d4d 100644</span><br><span>--- a/src/northbridge/intel/pineview/pineview.h</span><br><span>+++ b/src/northbridge/intel/pineview/pineview.h</span><br><span>@@ -62,7 +62,7 @@</span><br><span> #define REMAPBASE      0x98</span><br><span> #define REMAPLIMIT      0x9a</span><br><span> #define SMRAM           0x9d    /* System Management RAM Control */</span><br><span style="color: hsl(0, 100%, 40%);">-#define ESMRAM               0x9e    /* Extended System Management RAM Control */</span><br><span style="color: hsl(120, 100%, 40%);">+#define ESMRAMC           0x9e    /* Extended System Management RAM Control */</span><br><span> </span><br><span> #define TOM         0xa0</span><br><span> #define TOUUD           0xa2</span><br><span>diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c</span><br><span>index 1f03820..98addb1 100644</span><br><span>--- a/src/northbridge/intel/pineview/raminit.c</span><br><span>+++ b/src/northbridge/intel/pineview/raminit.c</span><br><span>@@ -2040,7 +2040,7 @@</span><br><span>    gttsize = ggc_to_gtt[(ggc & 0x300) >> 8];</span><br><span>  tom = s->channel_capacity[0];</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    tsegsize = 0x1; // 1MB</span><br><span style="color: hsl(120, 100%, 40%);">+        tsegsize = 0x8; // 1MB</span><br><span>       mmiosize = 0x400; // 1GB</span><br><span> </span><br><span>         reclaim = false;</span><br><span>@@ -2075,6 +2075,11 @@</span><br><span>    pci_write_config32(PCI_DEV(0,0,0), BGSM, gttbase << 20);</span><br><span>       pci_write_config32(PCI_DEV(0,0,0), TSEG, tsegbase << 20);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   u8 reg8 = pci_read_config8(PCI_DEV(0, 0, 0), ESMRAMC);</span><br><span style="color: hsl(120, 100%, 40%);">+        reg8 &= ~0x7;</span><br><span style="color: hsl(120, 100%, 40%);">+     reg8 |= (2 << 1) | (1 << 0); /* 8M and TSEG_Enable */</span><br><span style="color: hsl(120, 100%, 40%);">+     pci_write_config8(PCI_DEV(0, 0, 0), ESMRAMC, reg8);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>        printk(BIOS_DEBUG, "GBSM (igd) = verified %08x (written %08x)\n",</span><br><span>          pci_read_config32(PCI_DEV(0,0,0), GBSM), gfxbase << 20);</span><br><span>       printk(BIOS_DEBUG, "BGSM (gtt) = verified %08x (written %08x)\n",</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25593">change 25593</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25593"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ifa3acce57f0c13eee326b7c203a43453c74c3161 </div>
<div style="display:none"> Gerrit-Change-Number: 25593 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>