<p>Shamile Khan has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25573">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/common/block/gspi: Set Clock Update Bit for clock updates.<br><br>This is required for clock parameter settings to take effect.<br><br>BUG=b:75306520<br>BRANCH=None<br>TEST=On Octopus, used a scope to check that spi_clk fed to tpm is<br>1 MHz<br><br>Change-Id: Icdb617aa4aa944d46b3a56dab88d2008b01dea0d<br>Signed-off-by: Shamile Khan <shamile.khan@intel.com><br>---<br>M src/soc/intel/common/block/gspi/gspi.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/25573/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/common/block/gspi/gspi.c b/src/soc/intel/common/block/gspi/gspi.c</span><br><span>index 60c7391..d86fd27 100644</span><br><span>--- a/src/soc/intel/common/block/gspi/gspi.c</span><br><span>+++ b/src/soc/intel/common/block/gspi/gspi.c</span><br><span>@@ -464,7 +464,8 @@</span><br><span>     * Program m/n divider.</span><br><span>       * Set m and n to 1, so that this divider acts as a pass-through.</span><br><span>     */</span><br><span style="color: hsl(0, 100%, 40%);">-     clocks = (1 << CLOCKS_N_SHIFT) | (1 << CLOCKS_M_SHIFT) | CLOCKS_ENABLE;</span><br><span style="color: hsl(120, 100%, 40%);">+   clocks = (1 << CLOCKS_N_SHIFT) | (1 << CLOCKS_M_SHIFT) | CLOCKS_ENABLE |</span><br><span style="color: hsl(120, 100%, 40%);">+           CLOCKS_UPDATE;</span><br><span>      gspi_write_mmio_reg(p, CLOCKS, clocks);</span><br><span>      udelay(10);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25573">change 25573</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25573"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Icdb617aa4aa944d46b3a56dab88d2008b01dea0d </div>
<div style="display:none"> Gerrit-Change-Number: 25573 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Shamile Khan <shamile.khan@intel.com> </div>