<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25572">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel: Remove superfluous pointers variables<br><br>Change-Id: I639be58df358129c1f420cf8d1540edd408859a7<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/soc/intel/cannonlake/memmap.c<br>M src/soc/intel/common/block/ebda/ebda.c<br>M src/soc/intel/skylake/memmap.c<br>3 files changed, 7 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/25572/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/cannonlake/memmap.c b/src/soc/intel/cannonlake/memmap.c</span><br><span>index 0636b08..108a1b0 100644</span><br><span>--- a/src/soc/intel/cannonlake/memmap.c</span><br><span>+++ b/src/soc/intel/cannonlake/memmap.c</span><br><span>@@ -316,7 +316,6 @@</span><br><span> void *cbmem_top(void)</span><br><span> {</span><br><span> struct ebda_config ebda_cfg;</span><br><span style="color: hsl(0, 100%, 40%);">- struct ebda_config *cfg = &ebda_cfg;</span><br><span> </span><br><span> /*</span><br><span> * Check if Tseg has been initialized, we will use this as a flag</span><br><span>@@ -327,7 +326,7 @@</span><br><span> if (sa_get_tseg_base() == 0)</span><br><span> return NULL;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- retrieve_ebda_object(cfg);</span><br><span style="color: hsl(120, 100%, 40%);">+ retrieve_ebda_object(&ebda_cfg);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- return (void *)(uintptr_t)cfg->tolum_base;</span><br><span style="color: hsl(120, 100%, 40%);">+ return (void *)(uintptr_t)ebda_cfg.tolum_base;</span><br><span> }</span><br><span>diff --git a/src/soc/intel/common/block/ebda/ebda.c b/src/soc/intel/common/block/ebda/ebda.c</span><br><span>index 4f60490..d16ad6e 100644</span><br><span>--- a/src/soc/intel/common/block/ebda/ebda.c</span><br><span>+++ b/src/soc/intel/common/block/ebda/ebda.c</span><br><span>@@ -40,13 +40,12 @@</span><br><span> void fill_ebda_area(void)</span><br><span> {</span><br><span> struct ebda_config ebda_cfg;</span><br><span style="color: hsl(0, 100%, 40%);">- struct ebda_config *cfg = &ebda_cfg;</span><br><span> </span><br><span> /* Initialize EBDA area early during romstage. */</span><br><span> setup_default_ebda();</span><br><span style="color: hsl(0, 100%, 40%);">- create_soc_ebda(cfg);</span><br><span style="color: hsl(0, 100%, 40%);">- create_mainboard_ebda(cfg);</span><br><span style="color: hsl(0, 100%, 40%);">- write_ebda_data(cfg, sizeof(*cfg));</span><br><span style="color: hsl(120, 100%, 40%);">+ create_soc_ebda(&ebda_cfg);</span><br><span style="color: hsl(120, 100%, 40%);">+ create_mainboard_ebda(&ebda_cfg);</span><br><span style="color: hsl(120, 100%, 40%);">+ write_ebda_data(&ebda_cfg, sizeof(ebda_cfg));</span><br><span> }</span><br><span> </span><br><span> void retrieve_ebda_object(struct ebda_config *cfg)</span><br><span>diff --git a/src/soc/intel/skylake/memmap.c b/src/soc/intel/skylake/memmap.c</span><br><span>index 9151d96..f0ccb1d 100644</span><br><span>--- a/src/soc/intel/skylake/memmap.c</span><br><span>+++ b/src/soc/intel/skylake/memmap.c</span><br><span>@@ -338,7 +338,6 @@</span><br><span> void *cbmem_top(void)</span><br><span> {</span><br><span> struct ebda_config ebda_cfg;</span><br><span style="color: hsl(0, 100%, 40%);">- struct ebda_config *cfg = &ebda_cfg;</span><br><span> </span><br><span> /*</span><br><span> * Check if Tseg has been initialized, we will use this as a flag</span><br><span>@@ -349,7 +348,7 @@</span><br><span> if (sa_get_tseg_base() == 0)</span><br><span> return NULL;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- retrieve_ebda_object(cfg);</span><br><span style="color: hsl(120, 100%, 40%);">+ retrieve_ebda_object(&ebda_cfg);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- return (void *)(uintptr_t)cfg->tolum_base;</span><br><span style="color: hsl(120, 100%, 40%);">+ return (void *)(uintptr_t)ebda_cfg.tolum_base;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25572">change 25572</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25572"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I639be58df358129c1f420cf8d1540edd408859a7 </div>
<div style="display:none"> Gerrit-Change-Number: 25572 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>