<p>Frank Wu has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25564">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/nami: Enable DPTF and configure DPTF parameters<br><br>The commit enables DPTF function. The DPTF parameters are provided by thermal team.<br><br>BUG=b:72974136<br>BRANCH=poppy<br>TEST=emerge-nami coreboot then check the parameters in DPTF ui tool<br><br>Change-Id: I9b7ae34ee64f19ef783a8c1571831b2293105a18<br>Signed-off-by: Frank Wu <frank_wu@compal.corp-partner.google.com><br>---<br>M src/mainboard/google/poppy/variants/nami/devicetree.cb<br>M src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl<br>2 files changed, 118 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/25564/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb</span><br><span>index a04dd95..de5fb67 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nami/devicetree.cb</span><br><span>+++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb</span><br><span>@@ -21,6 +21,9 @@</span><br><span> # EC memory map range is 0x900-0x9ff</span><br><span> register "gen3_dec" = "0x00fc0901"</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ # Enable DPTF</span><br><span style="color: hsl(120, 100%, 40%);">+ register "dptf_enable" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> # Enable S0ix</span><br><span> register "s0ix_enable" = "1"</span><br><span> </span><br><span>diff --git a/src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl b/src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl</span><br><span>index 216b76f..e5a71fa 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl</span><br><span>+++ b/src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl</span><br><span>@@ -13,4 +13,118 @@</span><br><span> * GNU General Public License for more details.</span><br><span> */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Dummy file until DPTF support is added. */</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_CPU_PASSIVE 98</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_CPU_CRITICAL 125</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_CPU_ACTIVE_AC0 71</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_CPU_ACTIVE_AC1 69</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_CPU_ACTIVE_AC2 67</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_CPU_ACTIVE_AC3 65</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_CPU_ACTIVE_AC4 60</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR0_SENSOR_ID 0</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR0_SENSOR_NAME "Thermal_Sensor_Remote_CPU"</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR0_PASSIVE 81</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR0_CRITICAL 125</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR0_ACTIVE_AC0 62</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR0_ACTIVE_AC1 60</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR0_ACTIVE_AC2 55</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR0_ACTIVE_AC3 50</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR0_ACTIVE_AC4 45</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR1_SENSOR_ID 1</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR1_SENSOR_NAME "Thermal_Sensor_Remote_PMIC"</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR1_PASSIVE 78</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR1_CRITICAL 125</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR1_ACTIVE_AC0 60</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR1_ACTIVE_AC1 55</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR1_ACTIVE_AC2 50</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR1_ACTIVE_AC3 45</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR1_ACTIVE_AC4 40</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_ENABLE_CHARGER</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_ENABLE_FAN_CONTROL</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Charger performance states, board-specific values from charger and EC */</span><br><span style="color: hsl(120, 100%, 40%);">+Name (CHPS, Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { 0, 0, 0, 0, 255, 0x6a4, "mA", 0 }, /* 1.7A (MAX) */</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { 0, 0, 0, 0, 24, 0x600, "mA", 0 }, /* 1.5A */</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { 0, 0, 0, 0, 16, 0x400, "mA", 0 }, /* 1.0A */</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { 0, 0, 0, 0, 8, 0x200, "mA", 0 }, /* 0.5A */</span><br><span style="color: hsl(120, 100%, 40%);">+})</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef DPTF_ENABLE_FAN_CONTROL</span><br><span style="color: hsl(120, 100%, 40%);">+/* DFPS: Fan Performance States */</span><br><span style="color: hsl(120, 100%, 40%);">+Name (DFPS, Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ 0, // Revision</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * TODO : Need to update this Table after characterization.</span><br><span style="color: hsl(120, 100%, 40%);">+ * These are initial reference values.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Control, Trip Point, Speed, NoiseLevel, Power */</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {90, 0xFFFFFFFF, 6700, 220, 2200},</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {72, 0xFFFFFFFF, 5800, 180, 1800},</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {59, 0xFFFFFFFF, 5000, 145, 1450},</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {57, 0xFFFFFFFF, 4900, 115, 1150},</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {40, 0xFFFFFFFF, 3900, 90, 900}</span><br><span style="color: hsl(120, 100%, 40%);">+})</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Name (DART, Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Fan effect on CPU */</span><br><span style="color: hsl(120, 100%, 40%);">+ 0, // Revision</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * Source, Target, Weight, AC0, AC1, AC2, AC3, AC4, AC5, AC6,</span><br><span style="color: hsl(120, 100%, 40%);">+ * AC7, AC8, AC9</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ \_SB.DPTF.TFN1, \_SB.PCI0.B0D4, 100, 100, 90, 72, 59, 40, 0, 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ 0, 0, 0</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ \_SB.DPTF.TFN1, \_SB.DPTF.TSR0, 100, 100, 90, 72, 59, 40, 0, 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ 0, 0, 0</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ \_SB.DPTF.TFN1, \_SB.DPTF.TSR1, 100, 100, 90, 72, 59, 40, 0, 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ 0, 0, 0</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+})</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Name (DTRT, Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* CPU Throttle Effect on CPU */</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { \_SB.PCI0.B0D4, \_SB.PCI0.B0D4, 100, 0.1, 0, 0, 0, 0 },</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* CPU Throttle Effect on TSR0 */</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { \_SB.PCI0.B0D4, \_SB.DPTF.TSR0, 100, 0.1, 0, 0, 0, 0 },</span><br><span style="color: hsl(120, 100%, 40%);">+#if 0</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Charger Throttle Effect on Charger (TSR1) */</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { \_SB.DPTF.TCHG, \_SB.DPTF.TSR1, 100, 600, 0, 0, 0, 0 },</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+})</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Name (MPPC, Package ()</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ 0x2, /* Revision */</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { /* Power Limit 1 */</span><br><span style="color: hsl(120, 100%, 40%);">+ 0, /* PowerLimitIndex, 0 for Power Limit 1 */</span><br><span style="color: hsl(120, 100%, 40%);">+ 3000, /* PowerLimitMinimum */</span><br><span style="color: hsl(120, 100%, 40%);">+ 15000, /* PowerLimitMaximum */</span><br><span style="color: hsl(120, 100%, 40%);">+ 28000, /* TimeWindowMinimum */</span><br><span style="color: hsl(120, 100%, 40%);">+ 32000, /* TimeWindowMaximum */</span><br><span style="color: hsl(120, 100%, 40%);">+ 100 /* StepSize */</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { /* Power Limit 2 */</span><br><span style="color: hsl(120, 100%, 40%);">+ 1, /* PowerLimitIndex, 1 for Power Limit 2 */</span><br><span style="color: hsl(120, 100%, 40%);">+ 15000, /* PowerLimitMinimum */</span><br><span style="color: hsl(120, 100%, 40%);">+ 25000, /* PowerLimitMaximum */</span><br><span style="color: hsl(120, 100%, 40%);">+ 28000, /* TimeWindowMinimum */</span><br><span style="color: hsl(120, 100%, 40%);">+ 32000, /* TimeWindowMaximum */</span><br><span style="color: hsl(120, 100%, 40%);">+ 100 /* StepSize */</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+})</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Include DPTF */</span><br><span style="color: hsl(120, 100%, 40%);">+#include <soc/intel/skylake/acpi/dptf/dptf.asl></span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25564">change 25564</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25564"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I9b7ae34ee64f19ef783a8c1571831b2293105a18 </div>
<div style="display:none"> Gerrit-Change-Number: 25564 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Frank Wu <frank_wu@compal.corp-partner.google.com> </div>