<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/25457">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Richard Spiegel: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">amd/common/block/pi: Make agesa_heap_base() static<br><br>Convert agesa_heap_base() to static since it's unused outside of<br>heapmanager.c.<br><br>Change-Id: I3ee162985ca1ea36461ea413416d98451a700f8c<br>Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com><br>Reviewed-on: https://review.coreboot.org/25457<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/soc/amd/common/block/include/amdblocks/agesawrapper.h<br>M src/soc/amd/common/block/pi/heapmanager.c<br>2 files changed, 1 insertion(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/common/block/include/amdblocks/agesawrapper.h b/src/soc/amd/common/block/include/amdblocks/agesawrapper.h</span><br><span>index 44ddba2..986d6f8 100644</span><br><span>--- a/src/soc/amd/common/block/include/amdblocks/agesawrapper.h</span><br><span>+++ b/src/soc/amd/common/block/include/amdblocks/agesawrapper.h</span><br><span>@@ -63,6 +63,4 @@</span><br><span> void SetFchMidParams(FCH_INTERFACE *params);</span><br><span> void SetNbMidParams(GNB_MID_CONFIGURATION *params);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void *agesa_heap_base(void);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> #endif /* __AGESAWRAPPER_H__ */</span><br><span>diff --git a/src/soc/amd/common/block/pi/heapmanager.c b/src/soc/amd/common/block/pi/heapmanager.c</span><br><span>index 79c8403..a469a45 100644</span><br><span>--- a/src/soc/amd/common/block/pi/heapmanager.c</span><br><span>+++ b/src/soc/amd/common/block/pi/heapmanager.c</span><br><span>@@ -19,7 +19,7 @@</span><br><span> #include <cbmem.h></span><br><span> #include <string.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void *agesa_heap_base(void)</span><br><span style="color: hsl(120, 100%, 40%);">+static void *agesa_heap_base(void)</span><br><span> {</span><br><span>   return cbmem_add(CBMEM_ID_RESUME_SCRATCH, BIOS_HEAP_SIZE);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25457">change 25457</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25457"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I3ee162985ca1ea36461ea413416d98451a700f8c </div>
<div style="display:none"> Gerrit-Change-Number: 25457 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>