<p>Werner Zeh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25534">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fsp_broadwell_de: Provide valid ACPI path names for domain and LPC<br><br>Provide ACPI path names for PCI domain and LPC device so that generated<br>ACPI tables have valid device paths.<br><br>Change-Id: I5a97e45ef50ec5ee9d64c5d2834968a02455cf72<br>Signed-off-by: Werner Zeh <werner.zeh@siemens.com><br>---<br>M src/soc/intel/fsp_broadwell_de/chip.c<br>M src/soc/intel/fsp_broadwell_de/southcluster.c<br>2 files changed, 25 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/25534/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/fsp_broadwell_de/chip.c b/src/soc/intel/fsp_broadwell_de/chip.c</span><br><span>index b8db395..118fb99 100644</span><br><span>--- a/src/soc/intel/fsp_broadwell_de/chip.c</span><br><span>+++ b/src/soc/intel/fsp_broadwell_de/chip.c</span><br><span>@@ -30,6 +30,15 @@</span><br><span> assign_resources(dev->link_list);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)</span><br><span style="color: hsl(120, 100%, 40%);">+static const char *domain_acpi_name(const struct device *dev)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ if (dev->path.type == DEVICE_PATH_DOMAIN)</span><br><span style="color: hsl(120, 100%, 40%);">+ return "PCI0";</span><br><span style="color: hsl(120, 100%, 40%);">+ return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static struct device_operations pci_domain_ops = {</span><br><span> .read_resources = pci_domain_read_resources,</span><br><span> .set_resources = pci_domain_set_resources,</span><br><span>@@ -37,6 +46,9 @@</span><br><span> .init = NULL,</span><br><span> .scan_bus = pci_domain_scan_bus,</span><br><span> .ops_pci_bus = pci_bus_default_ops,</span><br><span style="color: hsl(120, 100%, 40%);">+#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)</span><br><span style="color: hsl(120, 100%, 40%);">+ .acpi_name = domain_acpi_name</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> };</span><br><span> </span><br><span> static struct device_operations cpu_bus_ops = {</span><br><span>diff --git a/src/soc/intel/fsp_broadwell_de/southcluster.c b/src/soc/intel/fsp_broadwell_de/southcluster.c</span><br><span>index 3bf5429..8ad27af 100644</span><br><span>--- a/src/soc/intel/fsp_broadwell_de/southcluster.c</span><br><span>+++ b/src/soc/intel/fsp_broadwell_de/southcluster.c</span><br><span>@@ -263,6 +263,16 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)</span><br><span style="color: hsl(120, 100%, 40%);">+static const char *lpc_acpi_name(const struct device *dev)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ if (dev->path.pci.devfn == LPC_DEV_FUNC)</span><br><span style="color: hsl(120, 100%, 40%);">+ return "LPC0";</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+ return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static struct device_operations device_ops = {</span><br><span> .read_resources = sc_read_resources,</span><br><span> .set_resources = pci_dev_set_resources,</span><br><span>@@ -271,6 +281,9 @@</span><br><span> .enable = southcluster_enable_dev,</span><br><span> .scan_bus = scan_lpc_bus,</span><br><span> .ops_pci = &soc_pci_ops,</span><br><span style="color: hsl(120, 100%, 40%);">+#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)</span><br><span style="color: hsl(120, 100%, 40%);">+ .acpi_name = lpc_acpi_name,</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> };</span><br><span> </span><br><span> static const struct pci_driver southcluster __pci_driver = {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25534">change 25534</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25534"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I5a97e45ef50ec5ee9d64c5d2834968a02455cf72 </div>
<div style="display:none"> Gerrit-Change-Number: 25534 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Werner Zeh <werner.zeh@siemens.com> </div>