<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25527">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/amd: Add "halt this AP" callback to romstage<br><br>As part of moving AGESA calls from bootblock to romstage, callback function<br>AGESA_HALT_THIS_AP must be available at romstage.<br><br>BUG=b:74236170<br>TEST=Build and boot grunt, actual test will be performed at a later patch.<br><br>Change-Id: I0992b2de5856881c19191ec4f637168727686524<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/soc/amd/common/block/cpu/Makefile.inc<br>M src/soc/amd/common/block/pi/def_callouts.c<br>2 files changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/25527/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/common/block/cpu/Makefile.inc b/src/soc/amd/common/block/cpu/Makefile.inc</span><br><span>index fed208a..395ab08 100644</span><br><span>--- a/src/soc/amd/common/block/cpu/Makefile.inc</span><br><span>+++ b/src/soc/amd/common/block/cpu/Makefile.inc</span><br><span>@@ -4,4 +4,5 @@</span><br><span> </span><br><span> postcar-$(CONFIG_SOC_AMD_COMMON_BLOCK_CAR) += car/exit_car.S</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+romstage-$(CONFIG_SOC_AMD_COMMON_BLOCK_CAR) += car/ap_exit_car.S</span><br><span> romstage-$(CONFIG_SOC_AMD_COMMON_BLOCK_CAR) += car/exit_car.S</span><br><span>diff --git a/src/soc/amd/common/block/pi/def_callouts.c b/src/soc/amd/common/block/pi/def_callouts.c</span><br><span>index beb2d18..fec1776 100644</span><br><span>--- a/src/soc/amd/common/block/pi/def_callouts.c</span><br><span>+++ b/src/soc/amd/common/block/pi/def_callouts.c</span><br><span>@@ -35,6 +35,9 @@</span><br><span> #else</span><br><span> const BIOS_CALLOUT_STRUCT BiosCallouts[] = {</span><br><span>       /* Required callouts */</span><br><span style="color: hsl(120, 100%, 40%);">+#if ENV_ROMSTAGE</span><br><span style="color: hsl(120, 100%, 40%);">+     { AGESA_HALT_THIS_AP,             agesa_HaltThisAp },</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span>        { AGESA_ALLOCATE_BUFFER,          agesa_AllocateBuffer },</span><br><span>    { AGESA_DEALLOCATE_BUFFER,        agesa_DeallocateBuffer },</span><br><span>  { AGESA_DO_RESET,                 agesa_Reset },</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25527">change 25527</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25527"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I0992b2de5856881c19191ec4f637168727686524 </div>
<div style="display:none"> Gerrit-Change-Number: 25527 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>