<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25469">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google/kahlee: Update WP to active low<br><br>The WP signal to the AP isn't inverted as it is on other platforms, so<br>it was reporting incorrectly.  Change the ACPI table to be active low,<br>and invert the signal when reporting it to everything else.<br><br>BUG=b:74946358<br>TEST=Boot grunt with battery inserted, WP signals both report 1.  Remove<br>battery, WP_CUR reports 0, WP_BOOT still reports 1.<br><br>Change-Id: Ic1369dbda609e34b308af308880449643be6af39<br>Signed-off-by: Martin Roth <martinroth@google.com><br>---<br>M src/mainboard/google/kahlee/chromeos.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/25469/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/chromeos.c b/src/mainboard/google/kahlee/chromeos.c</span><br><span>index e74e3b9..4b0f9a2 100644</span><br><span>--- a/src/mainboard/google/kahlee/chromeos.c</span><br><span>+++ b/src/mainboard/google/kahlee/chromeos.c</span><br><span>@@ -37,12 +37,13 @@</span><br><span> </span><br><span> int get_write_protect_state(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-     return gpio_get(CROS_WP_GPIO);</span><br><span style="color: hsl(120, 100%, 40%);">+        /* Write protect is active low, so invert it here */</span><br><span style="color: hsl(120, 100%, 40%);">+  return !gpio_get(CROS_WP_GPIO);</span><br><span> }</span><br><span> </span><br><span> static const struct cros_gpio cros_gpios[] = {</span><br><span>   CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, GPIO_DEVICE_NAME),</span><br><span style="color: hsl(0, 100%, 40%);">-  CROS_GPIO_WP_AH(CROS_WP_GPIO, GPIO_DEVICE_NAME),</span><br><span style="color: hsl(120, 100%, 40%);">+      CROS_GPIO_WP_AL(CROS_WP_GPIO, GPIO_DEVICE_NAME),</span><br><span> };</span><br><span> </span><br><span> void mainboard_chromeos_acpi_generate(void)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25469">change 25469</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25469"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic1369dbda609e34b308af308880449643be6af39 </div>
<div style="display:none"> Gerrit-Change-Number: 25469 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>