<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25468">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/soc/stoneyridge: Add a check for CMOS failure<br><br>BUG=b:77345148<br>TEST=Pull power from grunt, verify CMOS power failure is detected.<br>Reboot and verify that CMOS power failure is not detected.<br><br>Change-Id: Idbf0254e197a6d282e618a98bced52ea5a44917f<br>Signed-off-by: Martin Roth <martinroth@google.com><br>---<br>M src/soc/amd/stoneyridge/pmutil.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/25468/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/stoneyridge/pmutil.c b/src/soc/amd/stoneyridge/pmutil.c</span><br><span>index 25c9ec1..baabba5 100644</span><br><span>--- a/src/soc/amd/stoneyridge/pmutil.c</span><br><span>+++ b/src/soc/amd/stoneyridge/pmutil.c</span><br><span>@@ -17,11 +17,12 @@</span><br><span> #include <soc/southbridge.h></span><br><span> #include <security/vboot/vboot_common.h></span><br><span> #include <security/vboot/vbnv.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <pc80/mc146818rtc.h></span><br><span> </span><br><span> int vbnv_cmos_failed(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-    /* FIXME: RTC failure checking not supported. */</span><br><span style="color: hsl(0, 100%, 40%);">-        return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     /* If CMOS power has failed, the century will be set to 0xff */</span><br><span style="color: hsl(120, 100%, 40%);">+       return cmos_read(RTC_CLK_ALTCENTURY) == 0xff;</span><br><span> }</span><br><span> </span><br><span> int vboot_platform_is_resuming(void)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25468">change 25468</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25468"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Idbf0254e197a6d282e618a98bced52ea5a44917f </div>
<div style="display:none"> Gerrit-Change-Number: 25468 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>