<p>Julien Viard de Galbert has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25445">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">arch/x86/acpi: Add DMAR RMRR helper functions<br><br>Change-Id: Id4e7d95d2d13a7f7b49fcb6f6b9e8ccd6ae12a9e<br>Signed-off-by: Julien Viard de Galbert <jviarddegalbert@online.net><br>---<br>M src/arch/x86/acpi.c<br>M src/arch/x86/include/arch/acpi.h<br>2 files changed, 33 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/25445/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c</span><br><span>index 601b6f0..7d66285 100644</span><br><span>--- a/src/arch/x86/acpi.c</span><br><span>+++ b/src/arch/x86/acpi.c</span><br><span>@@ -9,6 +9,7 @@</span><br><span>  * Copyright (C) 2015 Timothy Pearson <tpearson@raptorengineeringinc.com>,</span><br><span>  * Raptor Engineering</span><br><span>  * Copyright (C) 2016-2017 Siemens AG</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2018 Online SAS</span><br><span>  *</span><br><span>  * ACPI FADT, FACS, and DSDT table support added by</span><br><span>  * Nick Barker <nick.barker9@btinternet.com>, and those portions</span><br><span>@@ -461,6 +462,20 @@</span><br><span>         return drhd->length;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+unsigned long acpi_create_dmar_rmrr(unsigned long current, u16 segment,</span><br><span style="color: hsl(120, 100%, 40%);">+                                 u32 bar, u64 limit)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+    dmar_rmrr_entry_t *rmrr = (dmar_rmrr_entry_t *)current;</span><br><span style="color: hsl(120, 100%, 40%);">+       memset(rmrr, 0, sizeof(*rmrr));</span><br><span style="color: hsl(120, 100%, 40%);">+       rmrr->type = DMAR_RMRR;</span><br><span style="color: hsl(120, 100%, 40%);">+    rmrr->length = sizeof(*rmrr); /* will be fixed up later */</span><br><span style="color: hsl(120, 100%, 40%);">+ rmrr->segment = segment;</span><br><span style="color: hsl(120, 100%, 40%);">+   rmrr->bar = bar;</span><br><span style="color: hsl(120, 100%, 40%);">+   rmrr->limit = limit;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     return rmrr->length;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> unsigned long acpi_create_dmar_atsr(unsigned long current, u8 flags,</span><br><span>         u16 segment)</span><br><span> {</span><br><span>@@ -480,6 +495,12 @@</span><br><span>     drhd->length = current - base;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+void acpi_dmar_rmrr_fixup(unsigned long base, unsigned long current)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+   dmar_rmrr_entry_t *rmrr = (dmar_rmrr_entry_t *)base;</span><br><span style="color: hsl(120, 100%, 40%);">+  rmrr->length = current - base;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> void acpi_dmar_atsr_fixup(unsigned long base, unsigned long current)</span><br><span> {</span><br><span>  dmar_atsr_entry_t *atsr = (dmar_atsr_entry_t *)base;</span><br><span>diff --git a/src/arch/x86/include/arch/acpi.h b/src/arch/x86/include/arch/acpi.h</span><br><span>index 5418420..a1ed338 100644</span><br><span>--- a/src/arch/x86/include/arch/acpi.h</span><br><span>+++ b/src/arch/x86/include/arch/acpi.h</span><br><span>@@ -331,6 +331,15 @@</span><br><span>     u64 bar;</span><br><span> } __packed dmar_entry_t;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+typedef struct dmar_rmrr_entry {</span><br><span style="color: hsl(120, 100%, 40%);">+    u16 type;</span><br><span style="color: hsl(120, 100%, 40%);">+     u16 length;</span><br><span style="color: hsl(120, 100%, 40%);">+   u16 reserved;</span><br><span style="color: hsl(120, 100%, 40%);">+ u16 segment;</span><br><span style="color: hsl(120, 100%, 40%);">+  u64 bar;</span><br><span style="color: hsl(120, 100%, 40%);">+      u64 limit;</span><br><span style="color: hsl(120, 100%, 40%);">+} __packed dmar_rmrr_entry_t;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> typedef struct dmar_atsr_entry {</span><br><span>      u16 type;</span><br><span>    u16 length;</span><br><span>@@ -715,9 +724,12 @@</span><br><span>                 unsigned long (*acpi_fill_dmar)(unsigned long));</span><br><span> unsigned long acpi_create_dmar_drhd(unsigned long current, u8 flags,</span><br><span>                                   u16 segment, u32 bar);</span><br><span style="color: hsl(120, 100%, 40%);">+unsigned long acpi_create_dmar_rmrr(unsigned long current, u16 segment,</span><br><span style="color: hsl(120, 100%, 40%);">+                               u32 bar, u64 limit);</span><br><span> unsigned long acpi_create_dmar_atsr(unsigned long current, u8 flags,</span><br><span>                                 u16 segment);</span><br><span> void acpi_dmar_drhd_fixup(unsigned long base, unsigned long current);</span><br><span style="color: hsl(120, 100%, 40%);">+void acpi_dmar_rmrr_fixup(unsigned long base, unsigned long current);</span><br><span> void acpi_dmar_atsr_fixup(unsigned long base, unsigned long current);</span><br><span> unsigned long acpi_create_dmar_drhd_ds_pci_br(unsigned long current,</span><br><span>                                      u8 bus, u8 dev, u8 fn);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25445">change 25445</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25445"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id4e7d95d2d13a7f7b49fcb6f6b9e8ccd6ae12a9e </div>
<div style="display:none"> Gerrit-Change-Number: 25445 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert@online.net> </div>