<p><a href="https://review.coreboot.org/25419">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25419/1/src/soc/amd/common/block/pi/amd_late_init.c">File src/soc/amd/common/block/pi/amd_late_init.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25419/1/src/soc/amd/common/block/pi/amd_late_init.c@53">Patch Set #1, Line 53:</a> <code style="font-family:monospace,monospace">sizeof(dimm->module_part_number) - 1)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is this the correct solution here?  Isn't this going to truncate the last byte of the spd's part number?  Maybe use memcpy and manually terminate the string instead?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/25419">change 25419</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25419"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I18fa5e9c73401575441b6810f1db80d11666368c </div>
<div style="display:none"> Gerrit-Change-Number: 25419 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 29 Mar 2018 06:43:30 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>