<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25452">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">drivers/intel/gma: Depend less on default fb values<br><br>Instead of hard-coding a lot of default values of the framebuffer config,<br>we use the values provided by Display_Probing.Scan_Ports() and only<br>overwrite what is necessary. This way we are more independent from<br>changes inside libgfxinit.<br><br>Change-Id: I121bbd926532c27321446282aa334cc45cdbeef1<br>Signed-off-by: Nico Huber <nico.huber@secunet.com><br>---<br>M src/drivers/intel/gma/hires_fb/gma.adb<br>M src/drivers/intel/gma/text_fb/gma.adb<br>2 files changed, 10 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/25452/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/intel/gma/hires_fb/gma.adb b/src/drivers/intel/gma/hires_fb/gma.adb</span><br><span>index 086da9b..839d2d3 100644</span><br><span>--- a/src/drivers/intel/gma/hires_fb/gma.adb</span><br><span>+++ b/src/drivers/intel/gma/hires_fb/gma.adb</span><br><span>@@ -79,12 +79,11 @@</span><br><span>                min_v := pos16'min (min_v, configs (i).Mode.V_Visible);</span><br><span>             end loop;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-            fb :=</span><br><span style="color: hsl(0, 100%, 40%);">-               (Width   => Width_Type (min_h),</span><br><span style="color: hsl(0, 100%, 40%);">-                Height  => Height_Type (min_v),</span><br><span style="color: hsl(0, 100%, 40%);">-                BPC     => 8,</span><br><span style="color: hsl(0, 100%, 40%);">-                Stride  => Div_Round_Up (Width_Type (min_h), 16) * 16,</span><br><span style="color: hsl(0, 100%, 40%);">-                Offset  => 0);</span><br><span style="color: hsl(120, 100%, 40%);">+            fb := configs (Primary).Framebuffer;</span><br><span style="color: hsl(120, 100%, 40%);">+            fb.Width    := Width_Type (min_h);</span><br><span style="color: hsl(120, 100%, 40%);">+            fb.Height   := Height_Type (min_v);</span><br><span style="color: hsl(120, 100%, 40%);">+            fb.Stride   := Div_Round_Up (fb.Width, 16) * 16;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>             for i in Pipe_Index loop</span><br><span>                exit when configs (i).Port = Disabled;</span><br><span> </span><br><span>diff --git a/src/drivers/intel/gma/text_fb/gma.adb b/src/drivers/intel/gma/text_fb/gma.adb</span><br><span>index 8f61d1d..145b9a0 100644</span><br><span>--- a/src/drivers/intel/gma/text_fb/gma.adb</span><br><span>+++ b/src/drivers/intel/gma/text_fb/gma.adb</span><br><span>@@ -51,12 +51,11 @@</span><br><span>             vga_io_init;</span><br><span>             vga_textmode_init;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-            configs (Primary).Framebuffer :=</span><br><span style="color: hsl(0, 100%, 40%);">-              (Width    => 640,</span><br><span style="color: hsl(0, 100%, 40%);">-               Height   => 400,</span><br><span style="color: hsl(0, 100%, 40%);">-               BPC      => Auto_BPC,   -- ignored for VGA plane</span><br><span style="color: hsl(0, 100%, 40%);">-               Stride   => 320,        -- ignored</span><br><span style="color: hsl(0, 100%, 40%);">-               Offset   => VGA_PLANE_FRAMEBUFFER_OFFSET);</span><br><span style="color: hsl(120, 100%, 40%);">+            -- override probed framebuffer config</span><br><span style="color: hsl(120, 100%, 40%);">+            configs (Primary).Framebuffer.Width    := 640;</span><br><span style="color: hsl(120, 100%, 40%);">+            configs (Primary).Framebuffer.Height   := 400;</span><br><span style="color: hsl(120, 100%, 40%);">+            configs (Primary).Framebuffer.Offset   :=</span><br><span style="color: hsl(120, 100%, 40%);">+               VGA_PLANE_FRAMEBUFFER_OFFSET;</span><br><span> </span><br><span>             HW.GFX.GMA.Dump_Configs (configs);</span><br><span>             HW.GFX.GMA.Update_Outputs (configs);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25452">change 25452</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25452"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I121bbd926532c27321446282aa334cc45cdbeef1 </div>
<div style="display:none"> Gerrit-Change-Number: 25452 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>