<p>Srinidhi N Kaushik has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25420">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel: Change in timeout value for mp_init<br><br>This patch chnages the timeout for all the mp_run_on_all_cpus calls<br>to fix the Parking AP error.<br><br>BUG=76442753<br>BRANCH=none<br>TEST=Build and boot, perform Suspend and during resume should not see<br>"Parking APs failed" error.<br><br>Change-Id: I7f09c1407ccbcc3bae90fb3806f1c754b1d9ac09<br>Signed-off-by: Srinidhi N Kaushik <srinidhi.n.kaushik@intel.com><br>---<br>M src/soc/intel/apollolake/chip.c<br>M src/soc/intel/apollolake/cpu.c<br>M src/soc/intel/common/block/cpu/mp_init.c<br>3 files changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/25420/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c</span><br><span>index 1dd6daf..242ce37 100644</span><br><span>--- a/src/soc/intel/apollolake/chip.c</span><br><span>+++ b/src/soc/intel/apollolake/chip.c</span><br><span>@@ -604,7 +604,7 @@</span><br><span> static void drop_privilege_all(void)</span><br><span> {</span><br><span> /* Drop privilege level on all the CPUs */</span><br><span style="color: hsl(0, 100%, 40%);">- if (mp_run_on_all_cpus(&cpu_enable_untrusted_mode, 1000) < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (mp_run_on_all_cpus(&cpu_enable_untrusted_mode, 3000) < 0)</span><br><span> printk(BIOS_ERR, "failed to enable untrusted mode\n");</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/soc/intel/apollolake/cpu.c b/src/soc/intel/apollolake/cpu.c</span><br><span>index d093acc..cadf50a 100644</span><br><span>--- a/src/soc/intel/apollolake/cpu.c</span><br><span>+++ b/src/soc/intel/apollolake/cpu.c</span><br><span>@@ -241,7 +241,7 @@</span><br><span> smm_southbridge_enable(PWRBTN_EN | GBL_EN);</span><br><span> </span><br><span> if (IS_ENABLED(CONFIG_SOC_INTEL_COMMON_BLOCK_SGX))</span><br><span style="color: hsl(0, 100%, 40%);">- mp_run_on_all_cpus(sgx_configure, 2000);</span><br><span style="color: hsl(120, 100%, 40%);">+ mp_run_on_all_cpus(sgx_configure, 3000);</span><br><span> }</span><br><span> </span><br><span> static const struct mp_ops mp_ops = {</span><br><span>diff --git a/src/soc/intel/common/block/cpu/mp_init.c b/src/soc/intel/common/block/cpu/mp_init.c</span><br><span>index 085a340..462c01a 100644</span><br><span>--- a/src/soc/intel/common/block/cpu/mp_init.c</span><br><span>+++ b/src/soc/intel/common/block/cpu/mp_init.c</span><br><span>@@ -132,7 +132,7 @@</span><br><span> /* Ensure to re-program all MTRRs based on DRAM resource settings */</span><br><span> static void post_cpus_init(void *unused)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- if (mp_run_on_all_cpus(&x86_setup_mtrrs_with_detect, 1000) < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (mp_run_on_all_cpus(&x86_setup_mtrrs_with_detect, 2000) < 0)</span><br><span> printk(BIOS_ERR, "MTRR programming failure\n");</span><br><span> </span><br><span> x86_mtrr_check();</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25420">change 25420</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25420"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7f09c1407ccbcc3bae90fb3806f1c754b1d9ac09 </div>
<div style="display:none"> Gerrit-Change-Number: 25420 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik@intel.com> </div>