<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25422">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">x86: Increase time out for parking APs to 250ms<br><br>Change f43adf0 (intel/common/block/cpu: Change post_cpus_init after<br>BS_DEV RESOURCES) moved post_cpus_init to BS_OS_RESUME for S3<br>path. This results in BSP timing out waiting for APs to be<br>parked. This change increases the time out value for APs to be parked<br>to 250ms. This value was chosen after running suspend-resume stress<br>test and capturing the maximum time taken for APs to be parked for<br>100 iterations. Typical values observed were ~150ms. Maximum value<br>observed was 152ms.<br><br>BUG=b:76442753<br>TEST=Verified for 100 iterations that suspend-resume does not run into<br>any AP park time out.<br><br>Change-Id: Id3e59db4fe7a5a2fb60357b05565bba89be1e00e<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/arch/x86/cpu.c<br>M src/cpu/x86/mp_init.c<br>2 files changed, 19 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/25422/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/arch/x86/cpu.c b/src/arch/x86/cpu.c</span><br><span>index cfcfdbd..142f2b1 100644</span><br><span>--- a/src/arch/x86/cpu.c</span><br><span>+++ b/src/arch/x86/cpu.c</span><br><span>@@ -309,6 +309,5 @@</span><br><span> return;</span><br><span> </span><br><span> /* APs are waiting for work. Last thing to do is park them. */</span><br><span style="color: hsl(0, 100%, 40%);">- if (mp_park_aps())</span><br><span style="color: hsl(0, 100%, 40%);">- printk(BIOS_ERR, "Parking APs failed.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ mp_park_aps();</span><br><span> }</span><br><span>diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c</span><br><span>index 409caa5..f99abaf 100644</span><br><span>--- a/src/cpu/x86/mp_init.c</span><br><span>+++ b/src/cpu/x86/mp_init.c</span><br><span>@@ -962,7 +962,24 @@</span><br><span> </span><br><span> int mp_park_aps(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- return mp_run_on_aps(park_this_cpu, 10 * USECS_PER_MSEC);</span><br><span style="color: hsl(120, 100%, 40%);">+ struct stopwatch sw;</span><br><span style="color: hsl(120, 100%, 40%);">+ int ret;</span><br><span style="color: hsl(120, 100%, 40%);">+ long duration_msecs;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ stopwatch_init(&sw);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ ret = mp_run_on_aps(park_this_cpu, 250 * USECS_PER_MSEC);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ duration_msecs = stopwatch_duration_msecs(&sw);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!ret)</span><br><span style="color: hsl(120, 100%, 40%);">+ printk(BIOS_DEBUG, "%s done after %ld msecs.\n", __func__,</span><br><span style="color: hsl(120, 100%, 40%);">+ duration_msecs);</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+ printk(BIOS_ERR, "%s failed after %ld msecs.\n", __func__,</span><br><span style="color: hsl(120, 100%, 40%);">+ duration_msecs);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return ret;</span><br><span> }</span><br><span> </span><br><span> static struct mp_flight_record mp_steps[] = {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25422">change 25422</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25422"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id3e59db4fe7a5a2fb60357b05565bba89be1e00e </div>
<div style="display:none"> Gerrit-Change-Number: 25422 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>