<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25409">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Add flag to set up GMCH Panel Fitter<br><br>Change-Id: I4949fbb5356bd244d3d6f3eec71847b6e683079a<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M common/hw-gfx-gma-config.ads.template<br>M common/hw-gfx-gma-pipe_setup.adb<br>M common/hw-gfx-gma-registers.ads<br>3 files changed, 15 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/09/25409/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template</span><br><span>index 75e1481..ceac67b 100644</span><br><span>--- a/common/hw-gfx-gma-config.ads.template</span><br><span>+++ b/common/hw-gfx-gma-config.ads.template</span><br><span>@@ -58,6 +58,7 @@</span><br><span>    VGA_Plane_Workaround    : constant Boolean := CPU = Ivybridge;</span><br><span>    Has_GMCH_VGACNTRL       : constant Boolean := false;</span><br><span>    Has_GMCH_DP_Transcoder  : constant Boolean := false;</span><br><span style="color: hsl(120, 100%, 40%);">+   Has_GMCH_PFIT_CONTROL   : constant Boolean := false;</span><br><span> </span><br><span>    ----- Panel power: -----</span><br><span>    Has_PP_Write_Protection : constant Boolean := CPU <= Ivybridge;</span><br><span>diff --git a/common/hw-gfx-gma-pipe_setup.adb b/common/hw-gfx-gma-pipe_setup.adb</span><br><span>index 8b02798..5328582 100644</span><br><span>--- a/common/hw-gfx-gma-pipe_setup.adb</span><br><span>+++ b/common/hw-gfx-gma-pipe_setup.adb</span><br><span>@@ -419,6 +419,16 @@</span><br><span>          Value    => Shift_Left (Word32 (Width), 16) or Word32 (Height));</span><br><span>    end Setup_Ironlake_Panel_Fitter;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   -- Simply set the pannel fitter to pipe A on which</span><br><span style="color: hsl(120, 100%, 40%);">+   -- the legacy VGA cycles are also displayed</span><br><span style="color: hsl(120, 100%, 40%);">+   procedure Setup_Gmch_Panel_Fitter</span><br><span style="color: hsl(120, 100%, 40%);">+   is</span><br><span style="color: hsl(120, 100%, 40%);">+   begin</span><br><span style="color: hsl(120, 100%, 40%);">+      Registers.Write</span><br><span style="color: hsl(120, 100%, 40%);">+     (Register => Registers.GMCH_PFIT_CONTROL,</span><br><span style="color: hsl(120, 100%, 40%);">+   Value    => PF_CTRL_ENABLE);</span><br><span style="color: hsl(120, 100%, 40%);">+   end Setup_Gmch_Panel_Fitter;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    procedure Setup_Scaling</span><br><span>      (Controller  : in     Controller_Type;</span><br><span>       Mode        : in     HW.GFX.Mode_Type;</span><br><span>@@ -434,6 +444,8 @@</span><br><span>       then</span><br><span>          if Config.Has_Plane_Control then</span><br><span>             Setup_Skylake_Pipe_Scaler (Controller, Mode, Framebuffer);</span><br><span style="color: hsl(120, 100%, 40%);">+    elsif Config.Has_GMCH_PFIT_CONTROL then</span><br><span style="color: hsl(120, 100%, 40%);">+          Setup_Gmch_Panel_Fitter;</span><br><span>          else</span><br><span>             Setup_Ironlake_Panel_Fitter (Controller, Mode, Framebuffer);</span><br><span>          end if;</span><br><span>diff --git a/common/hw-gfx-gma-registers.ads b/common/hw-gfx-gma-registers.ads</span><br><span>index 468d79d..480ee32 100644</span><br><span>--- a/common/hw-gfx-gma-registers.ads</span><br><span>+++ b/common/hw-gfx-gma-registers.ads</span><br><span>@@ -160,6 +160,7 @@</span><br><span>       GMCH_PP_ON_DELAYS,</span><br><span>       GMCH_PP_OFF_DELAYS,</span><br><span>       GMCH_PP_DIVISOR,</span><br><span style="color: hsl(120, 100%, 40%);">+      GMCH_PFIT_CONTROL,</span><br><span>       PIPEB_DDI_FUNC_CTL,</span><br><span>       PIPEB_MSA_MISC,</span><br><span>       SRD_CTL_B,</span><br><span>@@ -1293,6 +1294,7 @@</span><br><span>       GMCH_PP_ON_DELAYS     => 16#06_1208# / Register_Width,</span><br><span>       GMCH_PP_OFF_DELAYS    => 16#06_120c# / Register_Width,</span><br><span>       GMCH_PP_DIVISOR       => 16#06_1210# / Register_Width,</span><br><span style="color: hsl(120, 100%, 40%);">+      GMCH_PFIT_CONTROL     => 16#06_1230# / Register_Width,</span><br><span>       PCH_PP_STATUS         => 16#0c_7200# / Register_Width,</span><br><span>       PCH_PP_CONTROL        => 16#0c_7204# / Register_Width,</span><br><span>       PCH_PP_ON_DELAYS      => 16#0c_7208# / Register_Width,</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25409">change 25409</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25409"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libgfxinit </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4949fbb5356bd244d3d6f3eec71847b6e683079a </div>
<div style="display:none"> Gerrit-Change-Number: 25409 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>