<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25410">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Add Pipe_Index to the Connectors.Post_On method<br><br>On GMCH targets the Pipe index needs to be programmed in the output<br>register.<br><br>Change-Id: I6a614a9359c95adb59a1b6d0e34febe302fcfbf8<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M common/haswell_shared/hw-gfx-gma-connectors.adb<br>M common/hw-gfx-gma-connectors.ads<br>M common/hw-gfx-gma.adb<br>M common/ironlake/hw-gfx-gma-connectors.adb<br>4 files changed, 8 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/10/25410/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/common/haswell_shared/hw-gfx-gma-connectors.adb b/common/haswell_shared/hw-gfx-gma-connectors.adb</span><br><span>index 0aed750..6d5ec52 100644</span><br><span>--- a/common/haswell_shared/hw-gfx-gma-connectors.adb</span><br><span>+++ b/common/haswell_shared/hw-gfx-gma-connectors.adb</span><br><span>@@ -49,7 +49,8 @@</span><br><span>    end Pre_On;</span><br><span> </span><br><span>    procedure Post_On</span><br><span style="color: hsl(0, 100%, 40%);">-     (Port_Cfg : in     Port_Config;</span><br><span style="color: hsl(120, 100%, 40%);">+     (Pipe     : in     Pipe_Index;</span><br><span style="color: hsl(120, 100%, 40%);">+      Port_Cfg : in     Port_Config;</span><br><span>       PLL_Hint : in     Word32;</span><br><span>       Success  :    out Boolean)</span><br><span>    is</span><br><span>diff --git a/common/hw-gfx-gma-connectors.ads b/common/hw-gfx-gma-connectors.ads</span><br><span>index 134b076..a1d0d1e 100644</span><br><span>--- a/common/hw-gfx-gma-connectors.ads</span><br><span>+++ b/common/hw-gfx-gma-connectors.ads</span><br><span>@@ -29,7 +29,8 @@</span><br><span>       Success     :    out Boolean);</span><br><span> </span><br><span>    procedure Post_On</span><br><span style="color: hsl(0, 100%, 40%);">-     (Port_Cfg : in     Port_Config;</span><br><span style="color: hsl(120, 100%, 40%);">+     (Pipe     : in     Pipe_Index;</span><br><span style="color: hsl(120, 100%, 40%);">+      Port_Cfg : in     Port_Config;</span><br><span>       PLL_Hint : in     Word32;</span><br><span>       Success  :    out Boolean);</span><br><span>    pragma Warnings (GNATprove, On, "unused variable ""P*""");</span><br><span>diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb</span><br><span>index a4445ba..d6aa7cb 100644</span><br><span>--- a/common/hw-gfx-gma.adb</span><br><span>+++ b/common/hw-gfx-gma.adb</span><br><span>@@ -150,7 +150,8 @@</span><br><span>                      Framebuffer => Pipe_Cfg.Framebuffer);</span><br><span> </span><br><span>                   Connectors.Post_On</span><br><span style="color: hsl(0, 100%, 40%);">-                    (Port_Cfg => Port_Cfg,</span><br><span style="color: hsl(120, 100%, 40%);">+                    (Pipe     => Pipe,</span><br><span style="color: hsl(120, 100%, 40%);">+                     Port_Cfg => Port_Cfg,</span><br><span>                      PLL_Hint => PLLs.Register_Value (Allocated_PLLs (Pipe)),</span><br><span>                      Success  => Success);</span><br><span> </span><br><span>diff --git a/common/ironlake/hw-gfx-gma-connectors.adb b/common/ironlake/hw-gfx-gma-connectors.adb</span><br><span>index f18f64f..9bb0b68 100644</span><br><span>--- a/common/ironlake/hw-gfx-gma-connectors.adb</span><br><span>+++ b/common/ironlake/hw-gfx-gma-connectors.adb</span><br><span>@@ -60,7 +60,8 @@</span><br><span>    end Pre_On;</span><br><span> </span><br><span>    procedure Post_On</span><br><span style="color: hsl(0, 100%, 40%);">-     (Port_Cfg : in     Port_Config;</span><br><span style="color: hsl(120, 100%, 40%);">+     (Pipe     : in     Pipe_Index;</span><br><span style="color: hsl(120, 100%, 40%);">+      Port_Cfg : in     Port_Config;</span><br><span>       PLL_Hint : in     Word32;</span><br><span>       Success  :    out Boolean)</span><br><span>    is</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25410">change 25410</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25410"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libgfxinit </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I6a614a9359c95adb59a1b6d0e34febe302fcfbf8 </div>
<div style="display:none"> Gerrit-Change-Number: 25410 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>