<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25362">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/skylake: Do a heci_reset before reading ME firmware version<br><br>This change adds a call to heci_reset before attempting to read<br>ME firmware version. This is important to ensure that both ME and BIOS<br>are in sync.<br><br>BUG=b:76167737<br>BRANCH=poppy<br>TEST=Verfied that ME firmware version read does not fail on first boot<br>after power failure (i.e. removing battery and AC power).<br><br>Change-Id: Ib6b39c398d2e1177b087352a4acb8bcf5a9897d6<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/soc/intel/skylake/me.c<br>1 file changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/25362/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/skylake/me.c b/src/soc/intel/skylake/me.c</span><br><span>index 67d7bc0..9a721bc 100644</span><br><span>--- a/src/soc/intel/skylake/me.c</span><br><span>+++ b/src/soc/intel/skylake/me.c</span><br><span>@@ -254,6 +254,12 @@</span><br><span>       (hfs.fields.operation_mode != ME_HFS_MODE_NORMAL))</span><br><span>               goto failed;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+      /*</span><br><span style="color: hsl(120, 100%, 40%);">+     * It is important to do a heci_reset to ensure BIOS and ME are in sync</span><br><span style="color: hsl(120, 100%, 40%);">+        * before reading firmware version.</span><br><span style="color: hsl(120, 100%, 40%);">+    */</span><br><span style="color: hsl(120, 100%, 40%);">+   heci_reset();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>      if (!heci_send(&fw_ver_msg, sizeof(fw_ver_msg), BIOS_HOST_ADD,</span><br><span>                  HECI_MKHI_ADD))</span><br><span>               goto failed;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25362">change 25362</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25362"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib6b39c398d2e1177b087352a4acb8bcf5a9897d6 </div>
<div style="display:none"> Gerrit-Change-Number: 25362 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>