<p>Amanda Hwang has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25336">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy: Mask the leftmost 16 bits of board_sku_id<br><br>We use uint32_t(4 bytes) to read sku id from EC, but get the wrong<br>value of higher 16 bits.<br><br>BUG=b:74177699<br>BRANCH=poppy<br>TEST=Verify SKU ID value by mosys or ectool cbi command.<br><br>Change-Id: Id831b7c30ad9f02328292700622bfc485a374fdc<br>Signed-off-by: amanda_hwang <amanda_hwang@compal.corp-partner.google.com><br>---<br>M src/mainboard/google/poppy/variants/nami/mainboard.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/25336/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c</span><br><span>index 4fc3d88..2d5079d 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nami/mainboard.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/nami/mainboard.c</span><br><span>@@ -33,7 +33,7 @@</span><br><span>              return sku_id;</span><br><span>       if (google_chromeec_cbi_get_sku_id(&id))</span><br><span>                 return SKU_UNKNOWN;</span><br><span style="color: hsl(0, 100%, 40%);">-     sku_id = id;</span><br><span style="color: hsl(120, 100%, 40%);">+  sku_id = id & 0xFFFF;</span><br><span> </span><br><span>        return sku_id;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25336">change 25336</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25336"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id831b7c30ad9f02328292700622bfc485a374fdc </div>
<div style="display:none"> Gerrit-Change-Number: 25336 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Amanda Hwang <amanda_hwang@compal.corp-partner.google.com> </div>