<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25324">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">purism/librem_skl: Add AC/DC LoadLine to VR Config<br><br>The FSP 2.0 needs to set the ac_loadline and dc_loadline for<br>each VR config. Without it, the Loadline is considered to be<br>0 mOhm and this causes CPU temp to jump all over the place<br>whenever the CPU is used.<br><br>These values were copied from the Google Poppy devicetree.<br><br>Change-Id: I6aeb6ee521988b94f2ae94a60d1a28b87ba984d4<br>Signed-off-by: Youness Alaoui <youness.alaoui@puri.sm><br>---<br>M src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb<br>M src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb<br>2 files changed, 50 insertions(+), 30 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/25324/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb b/src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb</span><br><span>index 159d921..86808eb 100644</span><br><span>--- a/src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb</span><br><span>+++ b/src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb</span><br><span>@@ -31,8 +31,8 @@</span><br><span> # Enable "Intel Speed Shift Technology"</span><br><span> register "speed_shift_enable" = "1"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- # Enable DPTF</span><br><span style="color: hsl(0, 100%, 40%);">- register "dptf_enable" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+ # Disable DPTF</span><br><span style="color: hsl(120, 100%, 40%);">+ register "dptf_enable" = "0"</span><br><span> </span><br><span> # FSP Configuration</span><br><span> register "ProbelessTrace" = "0"</span><br><span>@@ -82,19 +82,21 @@</span><br><span> register "pirqh_routing" = "PCH_IRQ11"</span><br><span> </span><br><span> # VR Settings Configuration for 4 Domains</span><br><span style="color: hsl(0, 100%, 40%);">- #+----------------+-------+-------+-------------+-------+</span><br><span style="color: hsl(0, 100%, 40%);">- #| Domain/Setting | SA | IA | GT Unsliced | GT |</span><br><span style="color: hsl(0, 100%, 40%);">- #+----------------+-------+-------+-------------+-------+</span><br><span style="color: hsl(0, 100%, 40%);">- #| Psi1Threshold | 20A | 20A | 20A | 20A |</span><br><span style="color: hsl(0, 100%, 40%);">- #| Psi2Threshold | 4A | 5A | 5A | 5A |</span><br><span style="color: hsl(0, 100%, 40%);">- #| Psi3Threshold | 1A | 1A | 1A | 1A |</span><br><span style="color: hsl(0, 100%, 40%);">- #| Psi3Enable | 1 | 1 | 1 | 1 |</span><br><span style="color: hsl(0, 100%, 40%);">- #| Psi4Enable | 1 | 1 | 1 | 1 |</span><br><span style="color: hsl(0, 100%, 40%);">- #| ImonSlope | 0 | 0 | 0 | 0 |</span><br><span style="color: hsl(0, 100%, 40%);">- #| ImonOffset | 0 | 0 | 0 | 0 |</span><br><span style="color: hsl(0, 100%, 40%);">- #| IccMax | 7A | 34A | 35A | 35A |</span><br><span style="color: hsl(0, 100%, 40%);">- #| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V |</span><br><span style="color: hsl(0, 100%, 40%);">- #+----------------+-------+-------+-------------+-------+</span><br><span style="color: hsl(120, 100%, 40%);">+ #+----------------+-----------+-----------+-------------+----------+</span><br><span style="color: hsl(120, 100%, 40%);">+ #| Domain/Setting | SA | IA | GT Unsliced | GT |</span><br><span style="color: hsl(120, 100%, 40%);">+ #+----------------+-----------+-----------+-------------+----------+</span><br><span style="color: hsl(120, 100%, 40%);">+ #| Psi1Threshold | 20A | 20A | 20A | 20A |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| Psi2Threshold | 4A | 5A | 5A | 5A |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| Psi3Threshold | 1A | 1A | 1A | 1A |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| Psi3Enable | 1 | 1 | 1 | 1 |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| Psi4Enable | 1 | 1 | 1 | 1 |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| ImonSlope | 0 | 0 | 0 | 0 |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| ImonOffset | 0 | 0 | 0 | 0 |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| IccMax | 7A | 34A | 35A | 35A |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| AC LoadLine | 15 mOhm | 5.7 mOhm | 5.2 mOhm | 5.2 mOhm |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| DC LoadLine | 14.3 mOhm | 4.83 mOhm | 4.2 mOhm | 4.2 mOhm |</span><br><span style="color: hsl(120, 100%, 40%);">+ #+----------------+-----------+-----------+-------------+----------+</span><br><span> register "domain_vr_config[VR_SYSTEM_AGENT]" = "{</span><br><span> .vr_config_enable = 1,</span><br><span> .psi1threshold = VR_CFG_AMP(20),</span><br><span>@@ -106,6 +108,8 @@</span><br><span> .imon_offset = 0x0,</span><br><span> .icc_max = VR_CFG_AMP(7),</span><br><span> .voltage_limit = 1520,</span><br><span style="color: hsl(120, 100%, 40%);">+ .ac_loadline = 1500,</span><br><span style="color: hsl(120, 100%, 40%);">+ .dc_loadline = 1430,</span><br><span> }"</span><br><span> </span><br><span> register "domain_vr_config[VR_IA_CORE]" = "{</span><br><span>@@ -119,6 +123,8 @@</span><br><span> .imon_offset = 0x0,</span><br><span> .icc_max = VR_CFG_AMP(34),</span><br><span> .voltage_limit = 1520,</span><br><span style="color: hsl(120, 100%, 40%);">+ .ac_loadline = 570,</span><br><span style="color: hsl(120, 100%, 40%);">+ .dc_loadline = 483,</span><br><span> }"</span><br><span> </span><br><span> register "domain_vr_config[VR_GT_UNSLICED]" = "{</span><br><span>@@ -132,6 +138,8 @@</span><br><span> .imon_offset = 0x0,</span><br><span> .icc_max = VR_CFG_AMP(35),</span><br><span> .voltage_limit = 1520,</span><br><span style="color: hsl(120, 100%, 40%);">+ .ac_loadline = 520,</span><br><span style="color: hsl(120, 100%, 40%);">+ .dc_loadline = 420,</span><br><span> }"</span><br><span> </span><br><span> register "domain_vr_config[VR_GT_SLICED]" = "{</span><br><span>@@ -145,6 +153,8 @@</span><br><span> .imon_offset = 0x0,</span><br><span> .icc_max = VR_CFG_AMP(35),</span><br><span> .voltage_limit = 1520,</span><br><span style="color: hsl(120, 100%, 40%);">+ .ac_loadline = 520,</span><br><span style="color: hsl(120, 100%, 40%);">+ .dc_loadline = 420,</span><br><span> }"</span><br><span> </span><br><span> # Enable Root Ports 5 and 9</span><br><span>diff --git a/src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb b/src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb</span><br><span>index 035db18..fddb0aa 100644</span><br><span>--- a/src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb</span><br><span>+++ b/src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb</span><br><span>@@ -31,8 +31,8 @@</span><br><span> # Enable "Intel Speed Shift Technology"</span><br><span> register "speed_shift_enable" = "1"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- # Enable DPTF</span><br><span style="color: hsl(0, 100%, 40%);">- register "dptf_enable" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+ # Disable DPTF</span><br><span style="color: hsl(120, 100%, 40%);">+ register "dptf_enable" = "0"</span><br><span> </span><br><span> # FSP Configuration</span><br><span> register "ProbelessTrace" = "0"</span><br><span>@@ -82,19 +82,21 @@</span><br><span> register "pirqh_routing" = "PCH_IRQ11"</span><br><span> </span><br><span> # VR Settings Configuration for 4 Domains</span><br><span style="color: hsl(0, 100%, 40%);">- #+----------------+-------+-------+-------------+-------+</span><br><span style="color: hsl(0, 100%, 40%);">- #| Domain/Setting | SA | IA | GT Unsliced | GT |</span><br><span style="color: hsl(0, 100%, 40%);">- #+----------------+-------+-------+-------------+-------+</span><br><span style="color: hsl(0, 100%, 40%);">- #| Psi1Threshold | 20A | 20A | 20A | 20A |</span><br><span style="color: hsl(0, 100%, 40%);">- #| Psi2Threshold | 4A | 5A | 5A | 5A |</span><br><span style="color: hsl(0, 100%, 40%);">- #| Psi3Threshold | 1A | 1A | 1A | 1A |</span><br><span style="color: hsl(0, 100%, 40%);">- #| Psi3Enable | 1 | 1 | 1 | 1 |</span><br><span style="color: hsl(0, 100%, 40%);">- #| Psi4Enable | 1 | 1 | 1 | 1 |</span><br><span style="color: hsl(0, 100%, 40%);">- #| ImonSlope | 0 | 0 | 0 | 0 |</span><br><span style="color: hsl(0, 100%, 40%);">- #| ImonOffset | 0 | 0 | 0 | 0 |</span><br><span style="color: hsl(0, 100%, 40%);">- #| IccMax | 7A | 34A | 35A | 35A |</span><br><span style="color: hsl(0, 100%, 40%);">- #| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V |</span><br><span style="color: hsl(0, 100%, 40%);">- #+----------------+-------+-------+-------------+-------+</span><br><span style="color: hsl(120, 100%, 40%);">+ #+----------------+-----------+-----------+-------------+----------+</span><br><span style="color: hsl(120, 100%, 40%);">+ #| Domain/Setting | SA | IA | GT Unsliced | GT |</span><br><span style="color: hsl(120, 100%, 40%);">+ #+----------------+-----------+-----------+-------------+----------+</span><br><span style="color: hsl(120, 100%, 40%);">+ #| Psi1Threshold | 20A | 20A | 20A | 20A |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| Psi2Threshold | 4A | 5A | 5A | 5A |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| Psi3Threshold | 1A | 1A | 1A | 1A |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| Psi3Enable | 1 | 1 | 1 | 1 |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| Psi4Enable | 1 | 1 | 1 | 1 |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| ImonSlope | 0 | 0 | 0 | 0 |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| ImonOffset | 0 | 0 | 0 | 0 |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| IccMax | 7A | 34A | 35A | 35A |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| AC LoadLine | 15 mOhm | 5.7 mOhm | 5.2 mOhm | 5.2 mOhm |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| DC LoadLine | 14.3 mOhm | 4.83 mOhm | 4.2 mOhm | 4.2 mOhm |</span><br><span style="color: hsl(120, 100%, 40%);">+ #+----------------+-----------+-----------+-------------+----------+</span><br><span> register "domain_vr_config[VR_SYSTEM_AGENT]" = "{</span><br><span> .vr_config_enable = 1,</span><br><span> .psi1threshold = VR_CFG_AMP(20),</span><br><span>@@ -106,6 +108,8 @@</span><br><span> .imon_offset = 0x0,</span><br><span> .icc_max = VR_CFG_AMP(7),</span><br><span> .voltage_limit = 1520,</span><br><span style="color: hsl(120, 100%, 40%);">+ .ac_loadline = 1500,</span><br><span style="color: hsl(120, 100%, 40%);">+ .dc_loadline = 1430,</span><br><span> }"</span><br><span> </span><br><span> register "domain_vr_config[VR_IA_CORE]" = "{</span><br><span>@@ -119,6 +123,8 @@</span><br><span> .imon_offset = 0x0,</span><br><span> .icc_max = VR_CFG_AMP(34),</span><br><span> .voltage_limit = 1520,</span><br><span style="color: hsl(120, 100%, 40%);">+ .ac_loadline = 570,</span><br><span style="color: hsl(120, 100%, 40%);">+ .dc_loadline = 483,</span><br><span> }"</span><br><span> </span><br><span> register "domain_vr_config[VR_GT_UNSLICED]" = "{</span><br><span>@@ -132,6 +138,8 @@</span><br><span> .imon_offset = 0x0,</span><br><span> .icc_max = VR_CFG_AMP(35),</span><br><span> .voltage_limit = 1520,</span><br><span style="color: hsl(120, 100%, 40%);">+ .ac_loadline = 520,</span><br><span style="color: hsl(120, 100%, 40%);">+ .dc_loadline = 420,</span><br><span> }"</span><br><span> </span><br><span> register "domain_vr_config[VR_GT_SLICED]" = "{</span><br><span>@@ -145,6 +153,8 @@</span><br><span> .imon_offset = 0x0,</span><br><span> .icc_max = VR_CFG_AMP(35),</span><br><span> .voltage_limit = 1520,</span><br><span style="color: hsl(120, 100%, 40%);">+ .ac_loadline = 520,</span><br><span style="color: hsl(120, 100%, 40%);">+ .dc_loadline = 420,</span><br><span> }"</span><br><span> </span><br><span> # Enable Root Ports 5 and 9</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25324">change 25324</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25324"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I6aeb6ee521988b94f2ae94a60d1a28b87ba984d4 </div>
<div style="display:none"> Gerrit-Change-Number: 25324 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>