<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25329">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ec/purism: Fix CPU Turbo value (PPCM) set by the EC<br><br>The EC needs to set the PPCM value depending on whether<br>Turbo is enabled or not, and the values differ between<br>Broadwell (0, 1) and Skylake (1, 2) platforms.<br><br>Change-Id: I662dce54415e685c054ffc00b6afde0f1f7765e2<br>Signed-off-by: Youness Alaoui <youness.alaoui@puri.sm><br>---<br>M src/ec/purism/librem/acpi/ec.asl<br>M src/mainboard/purism/librem13v1/acpi/ec.asl<br>M src/mainboard/purism/librem_skl/acpi/ec.asl<br>3 files changed, 6 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/25329/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ec/purism/librem/acpi/ec.asl b/src/ec/purism/librem/acpi/ec.asl</span><br><span>index e95f126..ff325aa 100644</span><br><span>--- a/src/ec/purism/librem/acpi/ec.asl</span><br><span>+++ b/src/ec/purism/librem/acpi/ec.asl</span><br><span>@@ -218,11 +218,11 @@</span><br><span>             * when the system is charging.</span><br><span>               */</span><br><span>          If (TURB) {</span><br><span style="color: hsl(0, 100%, 40%);">-                     Store (Zero, PPCM)</span><br><span style="color: hsl(120, 100%, 40%);">+                    Store (PPCM_TURBO, PPCM)</span><br><span>                     PPCN ()</span><br><span>                      Store (One, EDTB)</span><br><span>            } Else {</span><br><span style="color: hsl(0, 100%, 40%);">-                        Store (One, PPCM)</span><br><span style="color: hsl(120, 100%, 40%);">+                     Store (PPCM_NOTURBO, PPCM)</span><br><span>                   PPCN ()</span><br><span>                      Store (Zero, EDTB)</span><br><span>           }</span><br><span>diff --git a/src/mainboard/purism/librem13v1/acpi/ec.asl b/src/mainboard/purism/librem13v1/acpi/ec.asl</span><br><span>index cf8b9a9..b2fa5b9 100644</span><br><span>--- a/src/mainboard/purism/librem13v1/acpi/ec.asl</span><br><span>+++ b/src/mainboard/purism/librem13v1/acpi/ec.asl</span><br><span>@@ -14,5 +14,7 @@</span><br><span>  */</span><br><span> </span><br><span> #define EC_SCI_GPI 10</span><br><span style="color: hsl(120, 100%, 40%);">+#define PPCM_TURBO Zero</span><br><span style="color: hsl(120, 100%, 40%);">+#define PPCM_NOTURBO One</span><br><span> </span><br><span> #include <ec/purism/librem/acpi/ec.asl></span><br><span>diff --git a/src/mainboard/purism/librem_skl/acpi/ec.asl b/src/mainboard/purism/librem_skl/acpi/ec.asl</span><br><span>index 4215213..c667b6c 100644</span><br><span>--- a/src/mainboard/purism/librem_skl/acpi/ec.asl</span><br><span>+++ b/src/mainboard/purism/librem_skl/acpi/ec.asl</span><br><span>@@ -14,5 +14,7 @@</span><br><span>  */</span><br><span> </span><br><span> #define EC_SCI_GPI 0x50</span><br><span style="color: hsl(120, 100%, 40%);">+#define PPCM_TURBO One</span><br><span style="color: hsl(120, 100%, 40%);">+#define PPCM_NOTURBO 0x02</span><br><span> </span><br><span> #include <ec/purism/librem/acpi/ec.asl></span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25329">change 25329</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25329"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I662dce54415e685c054ffc00b6afde0f1f7765e2 </div>
<div style="display:none"> Gerrit-Change-Number: 25329 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>