<p>Gaggery Tsai has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25305">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel: Add KBL-S MCH and some KBL PCH support<br><br>This patch adds the support for KBL-S MCH and Z270, H270, B250 and<br>Q250 PCH chips.<br><br>Change-Id: If03abb215f225d648505e05274e2f08ff02cebdc<br>Signed-off-by: Gaggery Tsai <gaggery.tsai@intel.com><br>---<br>M src/include/device/pci_ids.h<br>M src/soc/intel/common/block/lpc/lpc.c<br>M src/soc/intel/common/block/systemagent/systemagent.c<br>M src/soc/intel/skylake/bootblock/report_platform.c<br>4 files changed, 15 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/25305/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h</span><br><span>index c184383..e53d1b0 100644</span><br><span>--- a/src/include/device/pci_ids.h</span><br><span>+++ b/src/include/device/pci_ids.h</span><br><span>@@ -2669,7 +2669,11 @@</span><br><span> #define PCI_DEVICE_ID_INTEL_SPT_H_C236                  0xa150</span><br><span> #define PCI_DEVICE_ID_INTEL_SPT_H_PREMIUM             0xa14e</span><br><span> #define PCI_DEVICE_ID_INTEL_SPT_H_QM170                       0xa14d</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_KBP_H_H270                  0xa2c4</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_KBP_H_Z270                  0xa2c5</span><br><span> #define PCI_DEVICE_ID_INTEL_KBP_H_Q270                        0xa2c6</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_KBP_H_Q250                  0xa2c7</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_KBP_H_B250                  0xa2c8</span><br><span> #define PCI_DEVICE_ID_INTEL_SPT_LP_Y_PREMIUM_HDCP22           0x9d4b</span><br><span> #define PCI_DEVICE_ID_INTEL_SPT_LP_U_PREMIUM_HDCP22           0x9d4e</span><br><span> #define PCI_DEVICE_ID_INTEL_SPT_LP_U_BASE_HDCP22              0x9d50</span><br><span>@@ -2883,6 +2887,7 @@</span><br><span> #define PCI_DEVICE_ID_INTEL_SKL_ID_Y  0x190c</span><br><span> #define PCI_DEVICE_ID_INTEL_SKL_ID_ULX        0x1924</span><br><span> #define PCI_DEVICE_ID_INTEL_SKL_ID_H  0x1910</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_KBL_ID_S    0x590f</span><br><span> #define PCI_DEVICE_ID_INTEL_SKL_ID_H_EM       0x1918</span><br><span> #define PCI_DEVICE_ID_INTEL_KBL_ID_U  0x5904</span><br><span> #define PCI_DEVICE_ID_INTEL_KBL_ID_Y  0x590c</span><br><span>diff --git a/src/soc/intel/common/block/lpc/lpc.c b/src/soc/intel/common/block/lpc/lpc.c</span><br><span>index 2efdc8d..079ecde 100644</span><br><span>--- a/src/soc/intel/common/block/lpc/lpc.c</span><br><span>+++ b/src/soc/intel/common/block/lpc/lpc.c</span><br><span>@@ -128,6 +128,10 @@</span><br><span>   PCI_DEVICE_ID_INTEL_SPT_H_PREMIUM,</span><br><span>   PCI_DEVICE_ID_INTEL_SPT_H_QM170,</span><br><span>     PCI_DEVICE_ID_INTEL_KBP_H_Q270,</span><br><span style="color: hsl(120, 100%, 40%);">+       PCI_DEVICE_ID_INTEL_KBP_H_H270,</span><br><span style="color: hsl(120, 100%, 40%);">+       PCI_DEVICE_ID_INTEL_KBP_H_Z270,</span><br><span style="color: hsl(120, 100%, 40%);">+       PCI_DEVICE_ID_INTEL_KBP_H_Q250,</span><br><span style="color: hsl(120, 100%, 40%);">+       PCI_DEVICE_ID_INTEL_KBP_H_B250,</span><br><span>      PCI_DEVICE_ID_INTEL_SPT_LP_Y_PREMIUM_HDCP22,</span><br><span>         PCI_DEVICE_ID_INTEL_SPT_LP_U_PREMIUM_HDCP22,</span><br><span>         PCI_DEVICE_ID_INTEL_SPT_LP_U_BASE_HDCP22,</span><br><span>diff --git a/src/soc/intel/common/block/systemagent/systemagent.c b/src/soc/intel/common/block/systemagent/systemagent.c</span><br><span>index 027222b..25b4773 100644</span><br><span>--- a/src/soc/intel/common/block/systemagent/systemagent.c</span><br><span>+++ b/src/soc/intel/common/block/systemagent/systemagent.c</span><br><span>@@ -293,6 +293,7 @@</span><br><span>         PCI_DEVICE_ID_INTEL_SKL_ID_Y,</span><br><span>        PCI_DEVICE_ID_INTEL_SKL_ID_ULX,</span><br><span>      PCI_DEVICE_ID_INTEL_SKL_ID_H,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_DEVICE_ID_INTEL_KBL_ID_S,</span><br><span>        PCI_DEVICE_ID_INTEL_SKL_ID_H_EM,</span><br><span>     PCI_DEVICE_ID_INTEL_KBL_ID_U,</span><br><span>        PCI_DEVICE_ID_INTEL_KBL_ID_Y,</span><br><span>diff --git a/src/soc/intel/skylake/bootblock/report_platform.c b/src/soc/intel/skylake/bootblock/report_platform.c</span><br><span>index 6f2e98e..7473c57 100644</span><br><span>--- a/src/soc/intel/skylake/bootblock/report_platform.c</span><br><span>+++ b/src/soc/intel/skylake/bootblock/report_platform.c</span><br><span>@@ -56,6 +56,7 @@</span><br><span>   { PCI_DEVICE_ID_INTEL_KBL_U_R, "Kabylake-R ULT"},</span><br><span>  { PCI_DEVICE_ID_INTEL_KBL_ID_Y, "Kabylake-Y" },</span><br><span>    { PCI_DEVICE_ID_INTEL_KBL_ID_H, "Kabylake-H" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { PCI_DEVICE_ID_INTEL_KBL_ID_S, "Kabylake-S" },</span><br><span>    { PCI_DEVICE_ID_INTEL_KBL_ID_DT, "Kabylake DT" },</span><br><span> };</span><br><span> </span><br><span>@@ -71,6 +72,10 @@</span><br><span>   { PCI_DEVICE_ID_INTEL_SPT_H_C236, "Skylake PCH-H C236" },</span><br><span>  { PCI_DEVICE_ID_INTEL_SPT_H_QM170, "Skylake PCH-H QM170" },</span><br><span>        { PCI_DEVICE_ID_INTEL_KBP_H_Q270, "Kabylake-H Q270" },</span><br><span style="color: hsl(120, 100%, 40%);">+      { PCI_DEVICE_ID_INTEL_KBP_H_H270, "Kabylake-H H270" },</span><br><span style="color: hsl(120, 100%, 40%);">+      { PCI_DEVICE_ID_INTEL_KBP_H_Z270, "Kabylake-H Z270" },</span><br><span style="color: hsl(120, 100%, 40%);">+      { PCI_DEVICE_ID_INTEL_KBP_H_B250, "Kabylake-H B250" },</span><br><span style="color: hsl(120, 100%, 40%);">+      { PCI_DEVICE_ID_INTEL_KBP_H_Q250, "Kabylake-H Q250" },</span><br><span>     { PCI_DEVICE_ID_INTEL_KBP_LP_U_PREMIUM, "Kabylake-U Premium" },</span><br><span>    { PCI_DEVICE_ID_INTEL_KBP_LP_Y_PREMIUM, "Kabylake-Y Premium" },</span><br><span>    { PCI_DEVICE_ID_INTEL_KBP_LP_SUPER_SKU, "Kabylake Super Sku" },</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25305">change 25305</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25305"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If03abb215f225d648505e05274e2f08ff02cebdc </div>
<div style="display:none"> Gerrit-Change-Number: 25305 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Gaggery Tsai <gaggery.tsai@intel.com> </div>