<p>Vaibhav Shankar has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25291">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/cannonlake_rvp: Enable low power S0 Idle capability<br><br>This patch sets the ACPI FADT flag ACPI_FADT_LOW_POWER_S0<br>if S0ix is enabled for the platform.<br><br>TEST= Boot to OS and check the ACPI_FADT_LOW_PWR_IDLE_S0 flag<br>      is set in FACP table - FADT.Flags[21] bit.<br><br>Change-Id: I50245de95c9024b8a2fecba95772d25feba21446<br>Signed-off-by: Vaibhav Shankar <vaibhav.shankar@intel.com><br>---<br>M src/mainboard/intel/cannonlake_rvp/variants/cnl_u/devicetree.cb<br>M src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb<br>M src/soc/intel/cannonlake/acpi.c<br>3 files changed, 9 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/25291/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/intel/cannonlake_rvp/variants/cnl_u/devicetree.cb b/src/mainboard/intel/cannonlake_rvp/variants/cnl_u/devicetree.cb</span><br><span>index 3e60ed9..cb80deb 100644</span><br><span>--- a/src/mainboard/intel/cannonlake_rvp/variants/cnl_u/devicetree.cb</span><br><span>+++ b/src/mainboard/intel/cannonlake_rvp/variants/cnl_u/devicetree.cb</span><br><span>@@ -70,6 +70,9 @@</span><br><span>   # GPIO for SD card detect</span><br><span>    register "sdcard_cd_gpio" = "GPP_G5"</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+  #Enable S0ix</span><br><span style="color: hsl(120, 100%, 40%);">+  register "s0ix_enable" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>   # Audio</span><br><span>      register "i2c[3]" = "{</span><br><span>                .speed = I2C_SPEED_STANDARD,</span><br><span>diff --git a/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb b/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb</span><br><span>index 8502048..24d25ec 100644</span><br><span>--- a/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb</span><br><span>+++ b/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb</span><br><span>@@ -68,6 +68,9 @@</span><br><span>    # GPIO for SD card detect</span><br><span>    register "sdcard_cd_gpio" = "GPP_G5"</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+  #Enable S0ix</span><br><span style="color: hsl(120, 100%, 40%);">+  register "s0ix_enable" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>   device domain 0 on</span><br><span>           device pci 00.0 on  end # Host Bridge</span><br><span>                device pci 02.0 on  end # Integrated Graphics Device</span><br><span>diff --git a/src/soc/intel/cannonlake/acpi.c b/src/soc/intel/cannonlake/acpi.c</span><br><span>index 9dcaa33..0134b86 100644</span><br><span>--- a/src/soc/intel/cannonlake/acpi.c</span><br><span>+++ b/src/soc/intel/cannonlake/acpi.c</span><br><span>@@ -187,6 +187,9 @@</span><br><span>  fadt->x_pm_tmr_blk.resv = 0;</span><br><span>      fadt->x_pm_tmr_blk.addrl = pmbase + PM1_TMR;</span><br><span>      fadt->x_pm_tmr_blk.addrh = 0x0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  if(config->s0ix_enable)</span><br><span style="color: hsl(120, 100%, 40%);">+            fadt->flags |= ACPI_FADT_LOW_PWR_IDLE_S0;</span><br><span> }</span><br><span> uint32_t soc_read_sci_irq_select(void)</span><br><span> {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25291">change 25291</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25291"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I50245de95c9024b8a2fecba95772d25feba21446 </div>
<div style="display:none"> Gerrit-Change-Number: 25291 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vaibhav Shankar <vaibhav.shankar@intel.com> </div>