<p>Thomas Heijligen has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25296">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ifdtool: dump all PCH Straps<br><br>The length of the PCH Strap is defined in FLMAP1 as ISL.<br>Use this value to dump all PCH Straps.<br>Set MAX_PCHSTRP to 0x58 (Skylake-H), the lagest value known to me.<br><br>Change-Id: I56c02c00923e018bbd6a0409a08715f39b854d0a<br>Signed-off-by: Thomas Heijligen <src@posteo.de><br>---<br>M util/ifdtool/ifdtool.c<br>M util/ifdtool/ifdtool.h<br>2 files changed, 7 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/25296/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c</span><br><span>index 8397f5c..4fade18 100644</span><br><span>--- a/util/ifdtool/ifdtool.c</span><br><span>+++ b/util/ifdtool/ifdtool.c</span><br><span>@@ -411,11 +411,13 @@</span><br><span>                 (fcba->flpb & 0xfff) << 12);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void dump_fpsba(const fpsba_t *fpsba)</span><br><span style="color: hsl(120, 100%, 40%);">+static void dump_fpsba(const fpsba_t *fpsba, const uint32_t isl)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-   unsigned int i;</span><br><span>      printf("Found PCH Strap Section\n");</span><br><span style="color: hsl(0, 100%, 40%);">-  for (i = 0; i < ARRAY_SIZE(fpsba->pchstrp); i++)</span><br><span style="color: hsl(120, 100%, 40%);">+        if (isl > MAX_PCHSTRP)</span><br><span style="color: hsl(120, 100%, 40%);">+             printf("PCH Strap Length is bigger than known\n");</span><br><span style="color: hsl(120, 100%, 40%);">+  uint32_t i;</span><br><span style="color: hsl(120, 100%, 40%);">+   for (i = 0; i < isl; i++)</span><br><span>                 printf("PCHSTRP%u:%s 0x%08x\n", i,</span><br><span>                        i < 10 ? " " : "", fpsba->pchstrp[i]);</span><br><span>      printf("\n");</span><br><span>@@ -622,7 +624,7 @@</span><br><span>        if (frba && fcba && fpsba && fmba && fmsba) {</span><br><span>                dump_frba(frba);</span><br><span>             dump_fcba(fcba);</span><br><span style="color: hsl(0, 100%, 40%);">-                dump_fpsba(fpsba);</span><br><span style="color: hsl(120, 100%, 40%);">+            dump_fpsba(fpsba, (fdb->flmap1 >> 24) & 0xff);</span><br><span>          dump_fmba(fmba);</span><br><span>             dump_fmsba(fmsba);</span><br><span>   } else {</span><br><span>diff --git a/util/ifdtool/ifdtool.h b/util/ifdtool/ifdtool.h</span><br><span>index cd5af79..bbb94f0 100644</span><br><span>--- a/util/ifdtool/ifdtool.h</span><br><span>+++ b/util/ifdtool/ifdtool.h</span><br><span>@@ -73,7 +73,7 @@</span><br><span> } __attribute__((packed)) fcba_t;</span><br><span> </span><br><span> // pch strap</span><br><span style="color: hsl(0, 100%, 40%);">-#define MAX_PCHSTRP 18</span><br><span style="color: hsl(120, 100%, 40%);">+#define MAX_PCHSTRP 0x58</span><br><span> </span><br><span> typedef struct {</span><br><span>   uint32_t pchstrp[MAX_PCHSTRP];</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25296">change 25296</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25296"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I56c02c00923e018bbd6a0409a08715f39b854d0a </div>
<div style="display:none"> Gerrit-Change-Number: 25296 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Thomas Heijligen <src@posteo.de> </div>