<p>Justin TerAvest has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25285">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/octopus: Create bip variant<br><br>This creates a bip variant for octopus. Nothing is set in the variant<br>files here-- everything is picked up from baseboard.<br><br>BUG=b:75976864<br>TEST=None<br><br>Change-Id: I7a8ac3d8bb71416f05ef1a605684d92d5902abda<br>Signed-off-by: Justin TerAvest <teravest@chromium.org><br>---<br>M src/mainboard/google/octopus/Kconfig<br>M src/mainboard/google/octopus/Kconfig.name<br>A src/mainboard/google/octopus/variants/bip/include/variant/acpi/dptf.asl<br>A src/mainboard/google/octopus/variants/bip/include/variant/ec.h<br>A src/mainboard/google/octopus/variants/bip/include/variant/gpio.h<br>5 files changed, 65 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/25285/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig</span><br><span>index 3321b5c..49d5248 100644</span><br><span>--- a/src/mainboard/google/octopus/Kconfig</span><br><span>+++ b/src/mainboard/google/octopus/Kconfig</span><br><span>@@ -36,6 +36,7 @@</span><br><span> config VARIANT_DIR</span><br><span> string</span><br><span> default "yorp" if BOARD_GOOGLE_YORP</span><br><span style="color: hsl(120, 100%, 40%);">+ default "bip" if BOARD_GOOGLE_BIP</span><br><span> default "octopus" if BOARD_GOOGLE_OCTOPUS</span><br><span> </span><br><span> config DEVICETREE</span><br><span>@@ -45,6 +46,7 @@</span><br><span> config MAINBOARD_PART_NUMBER</span><br><span> string</span><br><span> default "yorp" if BOARD_GOOGLE_YORP</span><br><span style="color: hsl(120, 100%, 40%);">+ default "bip" if BOARD_GOOGLE_BIP</span><br><span> default "octopus" if BOARD_GOOGLE_OCTOPUS</span><br><span> </span><br><span> config MAINBOARD_FAMILY</span><br><span>@@ -55,6 +57,7 @@</span><br><span> string</span><br><span> depends on CHROMEOS</span><br><span> default "YORP TEST 7755" if BOARD_GOOGLE_YORP</span><br><span style="color: hsl(120, 100%, 40%);">+ default "BIP TEST 5732" if BOARD_GOOGLE_BIP</span><br><span> default "OCTOPUS TEST 6859" if BOARD_GOOGLE_OCTOPUS</span><br><span> </span><br><span> config MAX_CPUS</span><br><span>diff --git a/src/mainboard/google/octopus/Kconfig.name b/src/mainboard/google/octopus/Kconfig.name</span><br><span>index fa72b49..f4bd02c 100644</span><br><span>--- a/src/mainboard/google/octopus/Kconfig.name</span><br><span>+++ b/src/mainboard/google/octopus/Kconfig.name</span><br><span>@@ -6,3 +6,7 @@</span><br><span> bool "Yorp"</span><br><span> select BOARD_GOOGLE_BASEBOARD_OCTOPUS</span><br><span> select BASEBOARD_OCTOPUS_LAPTOP</span><br><span style="color: hsl(120, 100%, 40%);">+config BOARD_GOOGLE_BIP</span><br><span style="color: hsl(120, 100%, 40%);">+ bool "Bip"</span><br><span style="color: hsl(120, 100%, 40%);">+ select BOARD_GOOGLE_BASEBOARD_OCTOPUS</span><br><span style="color: hsl(120, 100%, 40%);">+ select BASEBOARD_OCTOPUS_LAPTOP</span><br><span>diff --git a/src/mainboard/google/octopus/variants/bip/include/variant/acpi/dptf.asl b/src/mainboard/google/octopus/variants/bip/include/variant/acpi/dptf.asl</span><br><span>new file mode 100644</span><br><span>index 0000000..cc17d56</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/google/octopus/variants/bip/include/variant/acpi/dptf.asl</span><br><span>@@ -0,0 +1,16 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright 2018 Google LLC</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <baseboard/acpi/dptf.asl></span><br><span>diff --git a/src/mainboard/google/octopus/variants/bip/include/variant/ec.h b/src/mainboard/google/octopus/variants/bip/include/variant/ec.h</span><br><span>new file mode 100644</span><br><span>index 0000000..16f931b</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/google/octopus/variants/bip/include/variant/ec.h</span><br><span>@@ -0,0 +1,21 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright 2018 Google LLC</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#ifndef MAINBOARD_EC_H</span><br><span style="color: hsl(120, 100%, 40%);">+#define MAINBOARD_EC_H</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <baseboard/ec.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span>diff --git a/src/mainboard/google/octopus/variants/bip/include/variant/gpio.h b/src/mainboard/google/octopus/variants/bip/include/variant/gpio.h</span><br><span>new file mode 100644</span><br><span>index 0000000..1fd1e11</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/google/octopus/variants/bip/include/variant/gpio.h</span><br><span>@@ -0,0 +1,21 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright 2018 Google LLC</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#ifndef MAINBOARD_GPIO_H</span><br><span style="color: hsl(120, 100%, 40%);">+#define MAINBOARD_GPIO_H</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <baseboard/gpio.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#endif /* MAINBOARD_GPIO_H */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25285">change 25285</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25285"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7a8ac3d8bb71416f05ef1a605684d92d5902abda </div>
<div style="display:none"> Gerrit-Change-Number: 25285 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Justin TerAvest <teravest@chromium.org> </div>